Bug 1285238

Summary: Corrupted objects list does not get cleared even after all the files in the volume are deleted and count increases as old + new count
Product: [Red Hat Storage] Red Hat Gluster Storage Reporter: RamaKasturi <knarra>
Component: bitrotAssignee: Bug Updates Notification Mailing List <rhs-bugs>
Status: CLOSED ERRATA QA Contact: RamaKasturi <knarra>
Severity: urgent Docs Contact:
Priority: unspecified    
Version: rhgs-3.1CC: byarlaga, rabhat, rhs-bugs, sankarshan, storage-qa-internal, vshankar
Target Milestone: ---Keywords: ZStream
Target Release: RHGS 3.1.2   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: glusterfs-3.7.5-12 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
: 1285241 (view as bug list) Environment:
Last Closed: 2016-03-01 05:57:46 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1260783, 1285241, 1293584    

Description RamaKasturi 2015-11-25 09:37:14 UTC 
Description of problem:
When user deletes all the files from mount point scrub status output still shows the corrupted objects list and it does not get cleared. Due to this next time when scrubber runs and finds an object as bad it just appends the newly corrupted file to the existing list and wrong information is displayed in the output.

Version-Release number of selected component (if applicable):
glusterfs-3.7.5-7.el7rhgs.x86_64

How reproducible:
Always

Steps to Reproduce:
1. Create a volume and enable bitrot on the volume.
2. Fuse mount the volume and create some files
3. corrupt some files from the backend and wait for scrubber to mark those files as bad files.
4. Now run gluster volume bitrot <vol_name> scrub status command and user will be able to see all gfids of files which were deleted.
5. Now delete all the files from mount point and create new files.
6. corrput the newly created file and wait for scrubber to run

Actual results:
1) Even after files are deleted from the mount point scrub status output still shows the gfids of the files.
2) Next time when scrubber runs list of corrupted files increases to old count + new count.

Expected results:
1) Once the files are deleted from the mount point, scrub status should not show the non existing gfid .
2) If the newly created files gets corrupted, corrupted objects count should not appended to the old object count.

Additional info:

scurb status output before deleting the files:
=================================================
[root@rhs-client2 b3]# gluster vol bitrot vol_dis_rep scrub status

Volume name : vol_dis_rep

State of scrub: Active

Scrub impact: lazy

Scrub frequency: hourly

Bitrot error log location: /var/log/glusterfs/bitd.log

Scrubber error log location: /var/log/glusterfs/scrub.log


=========================================================

Node name: localhost

Number of Scrubbed files: 0

Number of Unsigned files: 0

Last completed scrub time: 0

Duration of last scrub: 0

Error count: 6

Corrupted object's:

f56046c2-1bf1-47f1-b3b4-40c40b116d3b

2883c58a-7b81-47ab-a83c-408fe23e9767

b3bfe63e-44fd-46e9-8e01-cf84af2f4f4e

5ddaf82c-1238-4af7-980a-332da1c3e47a

f4151cef-285a-4d76-851e-ffeab7ca78cd

c805d027-2a46-4c97-ad13-9ae919164fe6


=========================================================

Node name: 10.70.36.62

Number of Scrubbed files: 0

Number of Unsigned files: 0

Last completed scrub time: 0

Duration of last scrub: 0

Error count: 6

Corrupted object's:

f47c1450-581b-42d5-ad9b-1955c9d4e7a0

50654920-8894-4a52-8a61-0a2862f012d9

3aa197cf-2c3a-4104-b0ac-0f36b7d86874

4ba25e47-4518-4497-b309-c8dfde6b9a43

bbf6d5b5-d66d-470e-a4ad-c163a4e23dd0

0453fa23-3143-45c5-82c9-803bbc2760ea

=========================================================

scrub status output after deleting the files:
===================================================
[root@rhs-client2 b3]# gluster vol bitrot vol_dis_rep scrub status

Volume name : vol_dis_rep

State of scrub: Active

Scrub impact: lazy

Scrub frequency: hourly

Bitrot error log location: /var/log/glusterfs/bitd.log

Scrubber error log location: /var/log/glusterfs/scrub.log


=========================================================

Node name: localhost

Number of Scrubbed files: 0

Number of Unsigned files: 0

Last completed scrub time: 0

Duration of last scrub: 0

Error count: 6

Corrupted object's:

f56046c2-1bf1-47f1-b3b4-40c40b116d3b

2883c58a-7b81-47ab-a83c-408fe23e9767

b3bfe63e-44fd-46e9-8e01-cf84af2f4f4e

5ddaf82c-1238-4af7-980a-332da1c3e47a

f4151cef-285a-4d76-851e-ffeab7ca78cd

c805d027-2a46-4c97-ad13-9ae919164fe6


=========================================================

Node name: 10.70.36.62

Number of Scrubbed files: 0

Number of Unsigned files: 0

Last completed scrub time: 0

Duration of last scrub: 0

Error count: 6

Corrupted object's:

f47c1450-581b-42d5-ad9b-1955c9d4e7a0

50654920-8894-4a52-8a61-0a2862f012d9

3aa197cf-2c3a-4104-b0ac-0f36b7d86874

4ba25e47-4518-4497-b309-c8dfde6b9a43

bbf6d5b5-d66d-470e-a4ad-c163a4e23dd0

0453fa23-3143-45c5-82c9-803bbc2760ea

=========================================================

scurb status output after deleting old files and creating new files from the mount point:
==========================================================

[root@rhs-client2 b3]# gluster vol bitrot vol_dis_rep scrub status

Volume name : vol_dis_rep

State of scrub: Active

Scrub impact: lazy

Scrub frequency: hourly

Bitrot error log location: /var/log/glusterfs/bitd.log

Scrubber error log location: /var/log/glusterfs/scrub.log


=========================================================

Node name: localhost

Number of Scrubbed files: 0

Number of Unsigned files: 0

Last completed scrub time: 0

Duration of last scrub: 0

Error count: 7

Corrupted object's:

f56046c2-1bf1-47f1-b3b4-40c40b116d3b

2883c58a-7b81-47ab-a83c-408fe23e9767

b3bfe63e-44fd-46e9-8e01-cf84af2f4f4e

5ddaf82c-1238-4af7-980a-332da1c3e47a

f4151cef-285a-4d76-851e-ffeab7ca78cd

c805d027-2a46-4c97-ad13-9ae919164fe6

e8561c6b-f881-499b-808b-7fa2bce190f7


=========================================================

Node name: 10.70.36.62

Number of Scrubbed files: 0

Number of Unsigned files: 0

Last completed scrub time: 0

Duration of last scrub: 0

Error count: 6

Corrupted object's:

f47c1450-581b-42d5-ad9b-1955c9d4e7a0

50654920-8894-4a52-8a61-0a2862f012d9

3aa197cf-2c3a-4104-b0ac-0f36b7d86874

4ba25e47-4518-4497-b309-c8dfde6b9a43

bbf6d5b5-d66d-470e-a4ad-c163a4e23dd0

0453fa23-3143-45c5-82c9-803bbc2760ea

=========================================================
Comment 2 Raghavendra Bhat 2015-12-04 07:04:55 UTC 
Have sent the patch upstream for review.
http://review.gluster.org/#/c/12743/
Comment 4 RamaKasturi 2015-12-22 09:31:27 UTC 
Verified and works fine with build glusterfs-3.7.5-12.el7rhgs.x86_64.

Corrupted objects list gets cleared when  all the files in the volume are deleted and count does not get incremented as old + new count.

Once the bad files are recovered manually, scrub status displays error count and corrupted objects as zero.
Comment 6 errata-xmlrpc 2016-03-01 05:57:46 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://rhn.redhat.com/errata/RHBA-2016-0193.html