Bug 1285428

Source file is ok
Summary is ok
License is ok
Description is ok
URL and Source0 are ok
All tests passed

$ rpm -qp --requires perl-Crypt-ScryptKDF-0.009-1.fc24.x86_64.rpm | sort | uniq -c
      1 libc.so.6()(64bit)
      1 libc.so.6(GLIBC_2.14)(64bit)
      1 libc.so.6(GLIBC_2.2.5)(64bit)
      1 libc.so.6(GLIBC_2.4)(64bit)
      1 libperl.so.5.22()(64bit)
      1 perl(:MODULE_COMPAT_5.22.0)
      1 perl(Crypt::OpenSSL::Random)
      1 perl(Exporter)
      1 perl(MIME::Base64)
      1 perl(XSLoader)
      1 perl(strict)
      1 perl(warnings)
      1 rpmlib(CompressedFileNames) <= 3.0.4-1
      1 rpmlib(FileDigests) <= 4.6.0-1
      1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
      1 rpmlib(PayloadIsXz) <= 5.2-1
      1 rtld(GNU_HASH)

Binary requires are Ok.

$ rpm -qp --provides perl-Crypt-ScryptKDF-0.009-1.fc24.x86_64.rpm | sort | uniq -c
      1 perl(Crypt::ScryptKDF) = 0.009
      1 perl-Crypt-ScryptKDF = 0.009-1.fc24
      1 perl-Crypt-ScryptKDF(x86-64) = 0.009-1.fc24
Binary provides are Ok.

$ rpmlint ./perl-Crypt-ScryptKDF*
perl-Crypt-ScryptKDF.src: W: spelling-error Summary(en_US) Scrypt -> Crypt, S crypt, Crypts
perl-Crypt-ScryptKDF.src: W: spelling-error %description -l en_US Scrypt -> Crypt, S crypt, Crypts
perl-Crypt-ScryptKDF.x86_64: W: spelling-error Summary(en_US) Scrypt -> Crypt, S crypt, Crypts
perl-Crypt-ScryptKDF.x86_64: W: spelling-error %description -l en_US Scrypt -> Crypt, S crypt, Crypts
perl-Crypt-ScryptKDF.x86_64: W: wrong-file-end-of-line-encoding /usr/share/doc/perl-Crypt-ScryptKDF/README
2 packages and 1 specfiles checked; 0 errors, 5 warnings.

FIX: Please fix the encoding of README


BuildRequires are almost ok
FIX: Please add gcc and perl-devel, because it is XS package
FIX: Please remove BR perl(ExtUtils::CBuilder), it is not used
TODO: perl(strict) and perl(warnings) should be part of the first section BRs,
      because they are used in Build.PL

Please correct all 'FIX' issues and consider fixing 'TODO' items and provide new spec file.

dfateyev's scratch build of perl-Crypt-ScryptKDF-0.009-2.fc20.denf.src.rpm for epel7 completed http://koji.fedoraproject.org/koji/taskinfo?taskID=11979120

Thanks for the review, Jitka.

- README eol encoding fixed;
- BR are justified, deps from TODO moved on top.

Spec URL: http://www.fateyev.com/RPMS/Fedora22/perl-Crypt-ScryptKDF.spec
SRPM URL: http://www.fateyev.com/RPMS/Fedora22/perl-Crypt-ScryptKDF-0.009-2.fc24.src.rpm

Koji rawhide scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=11979197

It looks good now.

Approved.

Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/perl-Crypt-ScryptKDF

perl-Crypt-ScryptKDF-0.009-2.el6 has been submitted as an update to Fedora EPEL 6. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2015-ce955af3d1

perl-Crypt-ScryptKDF-0.009-2.el7 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2015-73571cdca5

perl-Crypt-ScryptKDF-0.009-2.fc22 has been submitted as an update to Fedora 22. https://bodhi.fedoraproject.org/updates/FEDORA-2015-f7567178e6

perl-Crypt-ScryptKDF-0.009-2.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2015-a0b2afd9a0

perl-Crypt-ScryptKDF-0.009-2.el7 has been pushed to the Fedora EPEL 7 testing repository. If problems still persist, please make note of it in this bug report.
If you want to test the update, you can install it with
$ su -c 'yum --enablerepo=epel-testing update perl-Crypt-ScryptKDF'
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2015-73571cdca5

perl-Crypt-ScryptKDF-0.009-2.el6 has been pushed to the Fedora EPEL 6 testing repository. If problems still persist, please make note of it in this bug report.
If you want to test the update, you can install it with
$ su -c 'yum --enablerepo=epel-testing update perl-Crypt-ScryptKDF'
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2015-ce955af3d1

perl-Crypt-ScryptKDF-0.009-2.fc22 has been pushed to the Fedora 22 testing repository. If problems still persist, please make note of it in this bug report.
If you want to test the update, you can install it with
$ su -c 'dnf --enablerepo=updates-testing update perl-Crypt-ScryptKDF'
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2015-f7567178e6

perl-Crypt-ScryptKDF-0.009-2.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report.
If you want to test the update, you can install it with
$ su -c 'dnf --enablerepo=updates-testing update perl-Crypt-ScryptKDF'
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2015-a0b2afd9a0

perl-Crypt-ScryptKDF-0.009-2.fc22 has been pushed to the Fedora 22 stable repository. If problems still persist, please make note of it in this bug report.

perl-Crypt-ScryptKDF-0.009-2.fc23 has been pushed to the Fedora 23 stable repository. If problems still persist, please make note of it in this bug report.

perl-Crypt-ScryptKDF-0.009-2.el7 has been pushed to the Fedora EPEL 7 stable repository. If problems still persist, please make note of it in this bug report.

perl-Crypt-ScryptKDF-0.009-2.el6 has been pushed to the Fedora EPEL 6 stable repository. If problems still persist, please make note of it in this bug report.