Bug 1286374
| Summary: | fedpkg commands fail when under non-ASCII path | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Göran Uddeborg <goeran> |
| Component: | fedpkg | Assignee: | cqi |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | 23 | CC: | cqi, dennis, lsedlar, pbabinca, s |
| Target Milestone: | --- | Keywords: | Reopened |
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | fedpkg-1.24-2.fc24 fedpkg-1.24-3.el6 fedpkg-1.24-3.el7 fedpkg-1.24-3.fc23 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2016-08-22 16:49:57 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Göran Uddeborg
2015-11-28 18:50:33 UTC
Patch is done, being under review. https://pagure.io/fedpkg/pull-request/28 https://pagure.io/rpkg/pull-request/64 1.20 is quite an old version. With current 1.23 (or even git master) I can't replicate. The issue lies most likely in rpkg. With fedpkg-1.20 and pyrpkg-1.40 I get the same error. (In reply to Lubomír Sedlář from comment #2) > 1.20 is quite an old version. With current 1.23 (or even git master) I can't > replicate. This is interesting. I reproduced this bug with the master branch. Steps 1. make a directory named göran 2. cd göran && fedpkg clone -a gnome-calendar 3. cd gnome-calendar && fedpkg switch-branch f24 && fedpkg -d -v srpm Actual results: Creating repo object from /home/vagrant/packages/göran/gnome-calendar Could not execute srpm: 'ascii' codec can't decode byte 0xc3 in position 45: ordinal not in range(128) Traceback (most recent call last): File "/home/vagrant/rhpkg-env/bin/fedpkg", line 6, in <module> exec(compile(open(__file__).read(), __file__, 'exec')) File "/code/fedpkg/src/bin/fedpkg", line 16, in <module> main() File "/code/fedpkg/src/fedpkg/__main__.py", line 69, in main sys.exit(client.args.command()) File "/code/rpkg/src/pyrpkg/cli.py", line 1244, in srpm self.cmd.srpm(hashtype=self.args.hash) File "/code/rpkg/src/pyrpkg/__init__.py", line 2429, in srpm % (self.module_name, self.ver, self.rel)) File "/code/rpkg/src/pyrpkg/__init__.py", line 809, in ver self.load_nameverrel() File "/code/rpkg/src/pyrpkg/__init__.py", line 630, in load_nameverrel joined_cmd = ' '.join(cmd) UnicodeDecodeError: 'ascii' codec can't decode byte 0xc3 in position 45: ordinal not in range(128) Huh, I must have beed doing something wrong then. I can replicate and also verify the proposed patches fix the issue. PRs have been merged. fedpkg-1.24-2.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2016-8049bff436 fedpkg-1.24-2.fc22 has been submitted as an update to Fedora 22. https://bodhi.fedoraproject.org/updates/FEDORA-2016-e1cf369714 fedpkg-1.24-2.el7 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-e5e5513a38 fedpkg-1.24-2.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2016-3540ed2e2b fedpkg-1.24-2.el6 has been submitted as an update to Fedora EPEL 6. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-ecfcc317bf fedpkg-1.24-2.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-3540ed2e2b fedpkg-1.24-2.el6 has been pushed to the Fedora EPEL 6 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-ecfcc317bf fedpkg-1.24-2.el7 has been pushed to the Fedora EPEL 7 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-e5e5513a38 fedpkg-1.24-2.fc22 has been pushed to the Fedora 22 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-e1cf369714 fedpkg-1.24-2.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-8049bff436 fedpkg-1.24-2.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report. fedpkg-1.24-3.el6 has been submitted as an update to Fedora EPEL 6. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-ecfcc317bf fedpkg-1.24-3.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2016-3540ed2e2b fedpkg-1.24-3.el7 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-e5e5513a38 fedpkg-1.24-3.fc22 has been submitted as an update to Fedora 22. https://bodhi.fedoraproject.org/updates/FEDORA-2016-e1cf369714 fedpkg-1.24-3.el6 has been pushed to the Fedora EPEL 6 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-ecfcc317bf fedpkg-1.24-3.el7 has been pushed to the Fedora EPEL 7 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-e5e5513a38 fedpkg-1.24-3.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-3540ed2e2b fedpkg-1.24-3.fc22 has been pushed to the Fedora 22 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-e1cf369714 fedpkg-1.24-3.el6 has been pushed to the Fedora EPEL 6 stable repository. If problems still persist, please make note of it in this bug report. fedpkg-1.24-3.el7 has been pushed to the Fedora EPEL 7 stable repository. If problems still persist, please make note of it in this bug report. fedpkg-1.24-3.fc23 has been pushed to the Fedora 23 stable repository. If problems still persist, please make note of it in this bug report. |