Bug 1286404

Summary:	Rebalance updates layout commit hash before healing directory on all subvols.
Product:	[Community] GlusterFS	Reporter:	Sakshi <sabansal>
Component:	distribute	Assignee:	Sakshi <sabansal>
Status:	CLOSED NOTABUG	QA Contact:
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	mainline	CC:	bugs, smohan
Target Milestone:	---	Keywords:	Triaged
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2016-03-14 06:19:27 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Sakshi 2015-11-29 04:04:23 UTC

Description of problem:
Rebalance after healing the directory sets the layout commit hash as the volume commit hash for the local subvols. Hence if there were multiple nodes and rebalance on one node has healed the directory, then the layout commit hashes on one node may be same as volume commit hash and the others will still be unequal.
This is a problem, as the client may read the updated commit hash and assume that the entire directory is healed which is not the case.  

Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1. Create a distribute volume and ensure that the bricks are distributed across atleast two different nodes.
2. Add more bricks and start rebalance.
3. Ensure that the rebalance for any directory is completed on one node and not on others. 

Actual results:
The layout commit hash for that directory will be updated on the some of the subvols even though the directory is not healed on all subvols.

Expected results:
Until the directory is not healed across all subvols, the layout commit hash must not be same as volume level commit hash.
 

Additional info:

Comment 1 Vijay Bellur 2015-11-29 04:39:53 UTC

REVIEW: http://review.gluster.org/12781 (dht: layout commit hash must be changed if all subvols do not have same commit hash) posted (#1) for review on master by Sakshi Bansal

Comment 2 Vijay Bellur 2015-11-29 06:42:22 UTC

REVIEW: http://review.gluster.org/12781 (dht: layout commit hash must be changed if all subvols do not have same commit hash) posted (#2) for review on master by Sakshi Bansal

Comment 3 Vijay Bellur 2015-12-01 09:08:26 UTC

REVIEW: http://review.gluster.org/12781 (dht: layout commit hash must be changed if all subvols do not have same commit hash) posted (#3) for review on master by Sakshi Bansal

Comment 4 Vijay Bellur 2015-12-11 09:53:11 UTC

REVIEW: http://review.gluster.org/12781 (dht: layout commit hash must be changed if all subvols do not have same commit hash) posted (#4) for review on master by Raghavendra G (rgowdapp)

Comment 5 Vijay Bellur 2016-01-14 07:45:23 UTC

REVIEW: http://review.gluster.org/12781 (dht: layout commit hash must be changed if all subvols do not have same commit hash) posted (#5) for review on master by Sakshi Bansal

Comment 6 Sakshi 2016-03-14 06:19:27 UTC

We don't need this patch as commit-hash is set to invalid if commit-hash differs across subvols. Hence closing the bug.