Bug 1286457
| Summary: | python3-parse_type requires python3-enum34, but enum is built into python3 | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Zbigniew Jędrzejewski-Szmek <zbyszek> | ||||||
| Component: | python-parse_type | Assignee: | Matěj Cepl <mcepl> | ||||||
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||||
| Severity: | unspecified | Docs Contact: | |||||||
| Priority: | unspecified | ||||||||
| Version: | 23 | CC: | amigadave, mcepl, mcepl, zbyszek | ||||||
| Target Milestone: | --- | Keywords: | Reopened | ||||||
| Target Release: | --- | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Whiteboard: | |||||||||
| Fixed In Version: | python-parse_type-0.3.4-5.fc23 python-parse_type-0.3.4-6.el7 python-parse_type-0.3.4-5.el7 python-parse_type-0.3.4-6.el6 python-parse_type-0.3.4-5.el6 python-parse_type-0.3.4-6.fc22 python-parse_type-0.3.4-5.fc22 python-parse_type-0.3.4-6.fc23 | Doc Type: | Bug Fix | ||||||
| Doc Text: | Story Points: | --- | |||||||
| Clone Of: | Environment: | ||||||||
| Last Closed: | 2016-02-20 23:00:17 UTC | Type: | Bug | ||||||
| Regression: | --- | Mount Type: | --- | ||||||
| Documentation: | --- | CRM: | |||||||
| Verified Versions: | Category: | --- | |||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||
| Embargoed: | |||||||||
| Bug Depends On: | |||||||||
| Bug Blocks: | 1283713 | ||||||||
| Attachments: |
|
||||||||
|
Description
Zbigniew Jędrzejewski-Szmek
2015-11-29 17:37:44 UTC
Created attachment 1105930 [details] remove the python3-enum34 dependency The attached patch removes the python3-enum34 dependency and applies a patch for the bundled parse module to allow the tests to pass against Python 3.5. This builds fine in Rawhide, but if the change is to be applied on branches where a version of Python 3 that is less than 3.4, some versioned requirements would need to be added. Successful scratch build including the change: http://koji.fedoraproject.org/koji/taskinfo?taskID=12195985 I don't understand what you are talking about: matej@mitmanek: python-parse (f23)$ fedpkg switch-branch f23 Switched to branch 'f23' matej@mitmanek: python-parse (f23)$ grep enum *.spec matej@mitmanek: python-parse (f23)$ It would help if you looked in the correct repository: python-parse_type, not python-parse. Created attachment 1106066 [details] fix dependencies and add test patch I see that a patch got added to git, but it works the wrong way round; removing the python-enum34 dependency (which is required when building against Python 2) and adding the python3-enum34 dependency (which is not required in Python 3 versions greater than 3.4) when Python 3 support is enabled: http://pkgs.fedoraproject.org/cgit/python-parse_type.git/commit/?id=025f6a5255980bfba1cda52b898029be38bfbd1a Also, the patch against the bundled parse to ensure that the tests pass with Python 3.5 was removed. Thus, attached is a patch (best applied with git am) which looks remarkably like my first patch, and allows the package to build in Rawhide: http://koji.fedoraproject.org/koji/taskinfo?taskID=12200670 I see that another commit got added to git: http://pkgs.fedoraproject.org/cgit/python-parse_type.git/commit/?id=76681986354530faa0eae8d0fa4df64a3d1091d2 The python-enum34 Requires and BuildRequires are duplicated (line 44 and 45, and line 28 and 48). It looks like the else block for "with python3" can simply be removed, as no extra dependencies are required in Python 3 support is disabled. python-parse_type-0.3.4-5.el6 has been submitted as an update to Fedora EPEL 6. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2015-df9f80d61b python-parse_type-0.3.4-5.fc22 has been submitted as an update to Fedora 22. https://bodhi.fedoraproject.org/updates/FEDORA-2015-f373c3f64c python-parse_type-0.3.4-5.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2015-7134c8610d python-parse_type-0.3.4-5.el7 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2015-296d93567c python-parse_type-0.3.4-6.fc22 has been submitted as an update to Fedora 22. https://bodhi.fedoraproject.org/updates/FEDORA-2015-55616cb314 python-parse_type-0.3.4-6.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2015-83747d604e python-parse_type-0.3.4-6.el7 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2015-f94e9f87b1 python-parse_type-0.3.4-6.el6 has been submitted as an update to Fedora EPEL 6. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2015-3b2abb8a18 python-parse_type-0.3.4-5.fc22 has been pushed to the Fedora 22 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with $ su -c 'dnf --enablerepo=updates-testing update python-parse_type' You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2015-f373c3f64c python-parse_type-0.3.4-5.el6 has been pushed to the Fedora EPEL 6 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with $ su -c 'yum --enablerepo=epel-testing update python-parse_type' You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2015-df9f80d61b python-parse_type-0.3.4-5.el7 has been pushed to the Fedora EPEL 7 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with $ su -c 'yum --enablerepo=epel-testing update python-parse_type' You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2015-296d93567c python-parse_type-0.3.4-5.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with $ su -c 'dnf --enablerepo=updates-testing update python-parse_type' You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2015-7134c8610d python-parse_type-0.3.4-5.fc23 has been pushed to the Fedora 23 stable repository. If problems still persist, please make note of it in this bug report. python-parse_type-0.3.4-6.fc22 has been pushed to the Fedora 22 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with $ su -c 'dnf --enablerepo=updates-testing update python-parse_type' You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2015-55616cb314 python-parse_type-0.3.4-6.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with $ su -c 'dnf --enablerepo=updates-testing update python-parse_type' You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2015-83747d604e python-parse_type-0.3.4-6.el6 has been pushed to the Fedora EPEL 6 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with $ su -c 'yum --enablerepo=epel-testing update python-parse_type' You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2015-3b2abb8a18 python-parse_type-0.3.4-6.el7 has been pushed to the Fedora EPEL 7 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with $ su -c 'yum --enablerepo=epel-testing update python-parse_type' You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2015-f94e9f87b1 python-parse_type-0.3.4-6.el7 has been pushed to the Fedora EPEL 7 stable repository. If problems still persist, please make note of it in this bug report. python-parse_type-0.3.4-5.el7 has been pushed to the Fedora EPEL 7 stable repository. If problems still persist, please make note of it in this bug report. python-parse_type-0.3.4-6.el6 has been pushed to the Fedora EPEL 6 stable repository. If problems still persist, please make note of it in this bug report. python-parse_type-0.3.4-5.el6 has been pushed to the Fedora EPEL 6 stable repository. If problems still persist, please make note of it in this bug report. python-parse_type-0.3.4-6.fc22 has been pushed to the Fedora 22 stable repository. If problems still persist, please make note of it in this bug report. python-parse_type-0.3.4-5.fc22 has been pushed to the Fedora 22 stable repository. If problems still persist, please make note of it in this bug report. python-parse_type-0.3.4-6.fc23 has been pushed to the Fedora 23 stable repository. If problems still persist, please make note of it in this bug report. |