Bug 1287178

Summary: Dashboard edit - make it possible to drop into an empty column
Product: Red Hat CloudForms Management Engine Reporter: Martin Hradil <mhradil>
Component: UI - OPSAssignee: Martin Hradil <mhradil>
Status: CLOSED ERRATA QA Contact: Satyajit Bulage <sbulage>
Severity: medium Docs Contact:
Priority: high    
Version: 5.5.0CC: cpelland, dclarizi, hkataria, jhardy, jprause, mfeifer, mpovolny, obarenbo
Target Milestone: GA   
Target Release: 5.6.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: 5.6.0.0 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
: 1288189 (view as bug list) Environment:
Last Closed: 2016-06-29 15:14:32 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1288189    

Description Martin Hradil 2015-12-01 17:14:26 UTC
Description of problem:


Version-Release number of selected component (if applicable):
5.5

How reproducible:
always

Steps to Reproduce:
1. Go to CI > Reports > Dashboards.. 
2. Edit a dashboard.
3. Move all widgets out from one column
4. Try moving a widget back to the empty column


Actual results:

it will be impossible to move them back, because that column will have height of 0 or 1 pixels.


Expected results:

the widget should snap to the empty column


Additional info:

Comment 4 CFME Bot 2015-12-02 19:45:41 UTC
New commit detected on ManageIQ/manageiq/master:
https://github.com/ManageIQ/manageiq/commit/143c22ce590e4fceb8ca6d83ebf1c044f46bbd3d

commit 143c22ce590e4fceb8ca6d83ebf1c044f46bbd3d
Author:     Martin Hradil <mhradil>
AuthorDate: Thu Nov 26 16:09:37 2015 +0000
Commit:     Martin Hradil <mhradil>
CommitDate: Tue Dec 1 17:14:55 2015 +0000

    Dashboard edit - make it possible to drop into an empty column
    
    Go to CI > Reports > Dashboards.. and edit a dashboard.
    
    Move all widgets out from one column.. it will be impossible to move them back, because that column will have height of 0 or 1 pixels.
    
    This forces a height of at least 1 widget even if empty, in edit mode.
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1287178

 app/assets/stylesheets/main.scss                 |  2 +-
 app/assets/stylesheets/patternfly_overrides.scss | 13 ++++++++++---
 app/views/report/_db_widgets.html.haml           |  7 ++++---
 3 files changed, 15 insertions(+), 7 deletions(-)

Comment 5 CFME Bot 2015-12-07 19:03:33 UTC
New commit detected on cfme/5.5.z:
https://code.engineering.redhat.com/gerrit/gitweb?p=cfme.git;a=commitdiff;h=6bd603e034c9cce48b85bc50f3954d79682d44b6

commit 6bd603e034c9cce48b85bc50f3954d79682d44b6
Merge: aa153af b39f609
Author:     Dan Clarizio <dclarizi>
AuthorDate: Mon Dec 7 14:00:21 2015 -0500
Commit:     Dan Clarizio <dclarizi>
CommitDate: Mon Dec 7 14:00:21 2015 -0500

    Merge branch 'bz1287178-dashboard-edit-55' into '5.5.z'
    
    Dashboard edit - make it possible to drop into an empty column
    
    Go to CI > Reports > Dashboards.. and edit a dashboard.
    
    Move all widgets out from one column.. it will be impossible to move them back, because that column will have height of 0 or 1 pixels.
    
    This forces a height of at least 1 widget even if empty, in edit mode.
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1288189
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1287178
    (cherry picked from commit 143c22ce590e4fceb8ca6d83ebf1c044f46bbd3d)
    
    https://github.com/ManageIQ/manageiq/pull/5622/
    clean cherry pick
    
    See merge request !568

 app/assets/stylesheets/main.scss                 |  2 +-
 app/assets/stylesheets/patternfly_overrides.scss | 13 ++++++++++---
 app/views/report/_db_widgets.html.haml           |  7 ++++---
 3 files changed, 15 insertions(+), 7 deletions(-)

Comment 6 CFME Bot 2015-12-07 19:03:37 UTC
New commit detected on cfme/5.5.z:
https://code.engineering.redhat.com/gerrit/gitweb?p=cfme.git;a=commitdiff;h=b39f609ef8a9e628f3f3072348a252280fcc15c9

commit b39f609ef8a9e628f3f3072348a252280fcc15c9
Author:     Martin Hradil <mhradil>
AuthorDate: Thu Nov 26 16:09:37 2015 +0000
Commit:     Martin Hradil <mhradil>
CommitDate: Wed Dec 2 12:35:01 2015 +0000

    Dashboard edit - make it possible to drop into an empty column
    
    Go to CI > Reports > Dashboards.. and edit a dashboard.
    
    Move all widgets out from one column.. it will be impossible to move them back, because that column will have height of 0 or 1 pixels.
    
    This forces a height of at least 1 widget even if empty, in edit mode.
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1287178
    (cherry picked from commit 143c22ce590e4fceb8ca6d83ebf1c044f46bbd3d)

 app/assets/stylesheets/main.scss                 |  2 +-
 app/assets/stylesheets/patternfly_overrides.scss | 13 ++++++++++---
 app/views/report/_db_widgets.html.haml           |  7 ++++---
 3 files changed, 15 insertions(+), 7 deletions(-)

Comment 7 Satyajit Bulage 2016-04-18 05:58:25 UTC
Able to snap widget to the empty column
Verified version:-5.6.0.1-beta2.20160413141124_e25ac0e

Comment 9 errata-xmlrpc 2016-06-29 15:14:32 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2016:1348