Bug 1287819

Summary:	HID: multitouch: enable palm rejection if device implements confidence usage
Product:	[Fedora] Fedora	Reporter:	Guillaume Kulakowski <guillaume>
Component:	kernel	Assignee:	Kernel Maintainer List <kernel-maint>
Status:	CLOSED ERRATA	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	23	CC:	btissoir, gansalmon, itamar, jonathan, kernel-maint, madhu.chinakonda, mchehab
Target Milestone:	---
Target Release:	---
Hardware:	All
OS:	Linux
URL:	https://github.com/advancingu/XPS13Linux/issues/3
Whiteboard:
Fixed In Version:	kernel-4.2.7-300.fc23 kernel-4.2.7-200.fc22	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2015-12-16 08:25:00 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Guillaume Kulakowski 2015-12-02 18:39:15 UTC

Description of problem:
Currently, there isn't palm rejection if device implements confidence usage.

The usage Confidence is mandary to Windows Precision Touchpad devices. The appearance of this usage is checked in hidinput_connect but the quirk MT_QUIRK_VALID_IS_CONFIDENCE is not applied to device accordingly. Apply this quirk and also remove quirk MT_QUIRK_ALWAYS_VALID to enable palm rejection for the WIN 8 touchpad devices which have implemented usage Confidence in its input reports.

Additional info:
There is a patch: https://git.kernel.org/cgit/linux/kernel/git/jikos/hid.git/commit/?h=for-next&id=25a84db15b3f3a24d3ea7d2baf90693bcff34b0c

This patch is queued for 4.5 merge. It can be a good thing to add this patch on Fedora Kernel ?

Comment 1 Josh Boyer 2015-12-02 19:27:36 UTC

Benjamin, is this worth backporting to a 4.3/4.4 based kernel?  I'm not sure if it depends on other commits.

Comment 2 Benjamin Tissoires 2015-12-02 22:22:31 UTC

No there are no dependencies, it should be fine on its own. Having this in a fedora kernel would also be good for me to be sure we did not break other touchpads :)

So I am all for backporting it and see if we have other bugs reports.

Thanks!

Comment 3 Josh Boyer 2015-12-03 16:05:05 UTC

Thanks!  Added on all branches now.

Comment 4 Guillaume Kulakowski 2015-12-03 16:17:41 UTC

Hi,

> Thanks!  Added on all branches now.
Is there a build on koji.

Best regards,

Comment 5 Josh Boyer 2015-12-03 16:45:47 UTC

Not yet.  It will be included in whatever build happens next.  For rawhide, that just kicked off and will be 4.4.0-0.rc3.git4.1 I think.  The rest of the branches will get updates filed and bodhi will leave comments in this bug.

Comment 6 Fedora Update System 2015-12-10 14:44:15 UTC

kernel-4.2.7-300.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2015-ac9a19888e

Comment 7 Fedora Update System 2015-12-10 14:45:29 UTC

kernel-4.2.7-200.fc22 has been submitted as an update to Fedora 22. https://bodhi.fedoraproject.org/updates/FEDORA-2015-c4ed00a68f

Comment 8 Fedora Update System 2015-12-11 06:00:32 UTC

kernel-4.2.7-300.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report.
If you want to test the update, you can install it with
$ su -c 'dnf --enablerepo=updates-testing update kernel'
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2015-ac9a19888e

Comment 9 Fedora Update System 2015-12-11 19:57:07 UTC

kernel-4.2.7-200.fc22 has been pushed to the Fedora 22 testing repository. If problems still persist, please make note of it in this bug report.
If you want to test the update, you can install it with
$ su -c 'dnf --enablerepo=updates-testing update kernel'
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2015-c4ed00a68f

Comment 10 Fedora Update System 2015-12-16 08:24:12 UTC

kernel-4.2.7-300.fc23 has been pushed to the Fedora 23 stable repository. If problems still persist, please make note of it in this bug report.

Comment 11 Fedora Update System 2015-12-16 09:51:08 UTC

kernel-4.2.7-200.fc22 has been pushed to the Fedora 22 stable repository. If problems still persist, please make note of it in this bug report.

Comment 12 Fedora Update System 2015-12-16 14:35:16 UTC

kernel-4.2.7-300.fc23 has been pushed to the Fedora 23 stable repository. If problems still persist, please make note of it in this bug report.