Bug 1287878

Summary:	glusterfs does not allow passing standard SElinux mount options to fuse
Product:	[Community] GlusterFS	Reporter:	Niels de Vos <ndevos>
Component:	scripts	Assignee:	Manikandan <mselvaga>
Status:	CLOSED CURRENTRELEASE	QA Contact:
Severity:	high	Docs Contact:
Priority:	high
Version:	3.6.7	CC:	bugs, mselvaga, ndevos, smohan
Target Milestone:	---	Keywords:	SELinux, Triaged
Target Release:	---
Hardware:	x86_64
OS:	All
Whiteboard:
Fixed In Version:	glusterfs-v3.6.8	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:	1287763	Environment:
Last Closed:	2016-02-04 08:49:01 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1287763
Bug Blocks:	1267567

Description Niels de Vos 2015-12-02 22:10:23 UTC

+++ This bug was initially created as a clone of Bug #1287763 +++
+++                                                           +++
+++ Use this bug to provide a backport to release-3.6         +++

Description of problem:

With older versions of gluster, say 3.5.3, glusterfs supports setting selinux context over fuse.glusterfs mountpoint. After 3.6.1, it throws an error : "Invalid option: context". 

The problem is because of a change in mount.glusterfs script. With older versions, it works fine.

Version-Release number of selected component (if applicable):


How reproducible:
Always in versions from 3.6

Steps to Reproduce:
http://www.gluster.org/pipermail/gluster-users.old/2015-January/020014.html

Actual results:
It throws an error "Invalid option: context"

Expected results:
Inform FUSE that the glusterfs sub-filesystem supports SElinux while passing mount options and allow to set selinux context over the mountpoint.


Additional info:

When you set selinux context, the same can be verfied in /proc/mounts:

vm1:sel /qwe1 fuse.glusterfs rw,context=system_u:object_r:user_home_t:s0,relatime,user_id=0,group_id=0,default_    permissions,allow_other,max_read=131072 0 0

--- Additional comment from Vijay Bellur on 2015-12-02 21:56:01 CET ---

REVIEW: http://review.gluster.org/12858 (fuse: pass default SElinux mount options on to the kernel) posted (#1) for review on master by Niels de Vos (ndevos)

Comment 1 Vijay Bellur 2015-12-03 11:14:10 UTC

REVIEW: http://review.gluster.org/12871 (fuse: pass default SElinux mount options on to the kernel) posted (#1) for review on release-3.6 by Manikandan Selvaganesh (mselvaga)

Comment 2 Vijay Bellur 2015-12-16 11:27:27 UTC

COMMIT: http://review.gluster.org/12871 committed in release-3.6 by Raghavendra Bhat (raghavendra) 
------
commit b55959c5909b3c32aca18f0c77eced134b38db56
Author: Niels de Vos <ndevos>
Date:   Wed Dec 2 21:19:56 2015 +0100

    fuse: pass default SElinux mount options on to the kernel
    
    In order to set default SElinux contexts on a Gluster mount, the
    standard SElinux mount options need to be passed to the kernel. The
    mount(8) manual page lists "context", "fscontext", "defcontext" and
    "rootcontext" as valid options.
    
            Backport of http://review.gluster.org/#/c/12858/
    
    Cherry-picked from commit 5e81233f0a3c153e03c437a164ac2ca21314bdec
    > BUG: 1287763
    > Change-Id: I015fe27e4c6ff36a030e3480b23141aca2d91fc2
    > Signed-off-by: Niels de Vos <ndevos>
    > Reviewed-on: http://review.gluster.org/12858
    > Tested-by: NetBSD Build System <jenkins.org>
    > Tested-by: Gluster Build System <jenkins.com>
    > Reviewed-by: Humble Devassy Chirammal <humble.devassy>
    > Reviewed-by: Manikandan Selvaganesh <mselvaga>
    
    BUG: 1287878
    Change-Id: I015fe27e4c6ff36a030e3480b23141aca2d91fc2
    Signed-off-by: Manikandan Selvaganesh <mselvaga>
    Reviewed-on: http://review.gluster.org/12871
    Reviewed-by: Niels de Vos <ndevos>
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Raghavendra Bhat <raghavendra>

Comment 3 Kaushal 2016-02-04 08:49:01 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-v3.6.8, please open a new bug report.

glusterfs-v3.6.8 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] https://www.gluster.org/pipermail/gluster-users/2016-January/025161.html
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user