Bug 1288195
| Summary: | log improvements:- enabling quota on a volume reports numerous entries of "contribution node list is empty which is an error" in brick logs | |||
|---|---|---|---|---|
| Product: | [Community] GlusterFS | Reporter: | Neil Van Lysel <nvanlysel> | |
| Component: | quota | Assignee: | Manikandan <mselvaga> | |
| Status: | CLOSED CURRENTRELEASE | QA Contact: | ||
| Severity: | medium | Docs Contact: | ||
| Priority: | high | |||
| Version: | 3.5.5 | CC: | bugs, mselvaga, ndevos, nvanlysel, rwheeler, shwetha.h.panduranga, smohan, vmallika | |
| Target Milestone: | --- | Keywords: | Triaged | |
| Target Release: | --- | |||
| Hardware: | x86_64 | |||
| OS: | Linux | |||
| Whiteboard: | ||||
| Fixed In Version: | glusterfs-3.5.8 | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | ||
| Clone Of: | 812206 | |||
| : | 1302310 (view as bug list) | Environment: | ||
| Last Closed: | 2016-03-04 11:15:27 UTC | Type: | Bug | |
| Regression: | --- | Mount Type: | --- | |
| Documentation: | --- | CRM: | ||
| Verified Versions: | Category: | --- | ||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | ||
| Cloudforms Team: | --- | Target Upstream Version: | ||
| Embargoed: | ||||
| Bug Depends On: | ||||
| Bug Blocks: | 1302310 | |||
|
Description
Neil Van Lysel
2015-12-03 19:18:07 UTC
Hi Neil Van, This issue has been fixed in 3.7. Do you have plans to upgrade to 3.7? Thanks, Vijay Hi Vijay, Thanks for the quick response. I do not plan on upgrading to 3.7. Is it possible to backport this fix into the 3.5 branch? Thanks, Neil Hi Neil, Thanks for your quick response too :-) Since it's an older version, we need to check the regressions that the patch can cause when we backport to 3.5. Surely, we will check on this soon and depending on that, we will backport it so that the fix will be available in one of the next upcoming minor release of 3.5. -- Thanks & Regards, Manikandan Selvaganesh. Cool! Thank you very much!! Neil REVIEW: http://review.gluster.org/12990 (quota : avoid "contribution node is empty" error logs) posted (#1) for review on release-3.5 by Manikandan Selvaganesh (mselvaga) Hi Neil, I have back ported a patch to 3.5 that fixes the issue you have reported. Since the entire marker and quota code has almost been re-factored, it's very hard for us to back port all the fixes, also it could not be completely fixed with the older approach. It would be better if you could upgrade to the latest version. Mostly, you could expect this fix in the next upcoming minor release of 3.5. -- Thanks & Regards, Manikandan Selvaganesh. Thanks! Neil REVIEW: http://review.gluster.org/12990 (quota : avoid "contribution node is empty" error logs) posted (#2) for review on release-3.5 by Manikandan Selvaganesh (mselvaga) COMMIT: http://review.gluster.org/12990 committed in release-3.5 by Niels de Vos (ndevos) ------ commit a31f716d3bde1a8c403feff62b05b3eeba0b3ec2 Author: Manikandan Selvaganesh <mselvaga> Date: Thu Dec 17 10:55:37 2015 +0530 quota : avoid "contribution node is empty" error logs In versions older than 3.7, "contribution node list is empty which is an error" gets logged numerous number of times. It is completely fixed in 3.7. Since the entire marker and quota code has almost been refactored, it is hard to backport the complete fix and also it could not be fixed with the older approach. As a temporary fix, to avoid numerous logs, the patch just supresses the log level. 3.6 Patch -> http://review.gluster.org/#/c/13304/ Change-Id: Ie666ba99c7bb16b9ce249b581e09857734589f51 BUG: 1288195 Signed-off-by: Manikandan Selvaganesh <mselvaga> Reviewed-on: http://review.gluster.org/12990 Smoke: Gluster Build System <jenkins.com> CentOS-regression: Gluster Build System <jenkins.com> NetBSD-regression: NetBSD Build System <jenkins.org> Reviewed-by: Niels de Vos <ndevos> Reviewed-by: Vijaikumar Mallikarjuna <vmallika> GlusterFS 3.5.8 has been released and should fix this bug: http://www.gluster.org/pipermail/announce/2016-March/000054.html |