Bug 1288557

Summary:	Automate Method quota doesn't correctly handle sub 1GB storage requests
Product:	Red Hat CloudForms Management Engine	Reporter:	Pete Savage <psavage>
Component:	Automate	Assignee:	Tina Fitzgerald <tfitzger>
Status:	CLOSED NOTABUG	QA Contact:	Dave Johnson <dajohnso>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	5.5.0	CC:	jhardy, mkanoor, obarenbo, psavage, tfitzger
Target Milestone:	GA
Target Release:	5.6.0
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2015-12-22 17:12:03 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Pete Savage 2015-12-04 14:54:02 UTC

Description of problem: Automate Method doesn't correctly handle sub 1GB storage requests


Version-Release number of selected component (if applicable): 5.5.0.13


How reproducible: 100%


Steps to Reproduce:
1. Apply a limit of 1GB in the / Service / Provisioning / StateMachines / ServiceProvisionRequestQuotaVerification / instance
2. Run a provisioning with 400Mb storage * 3
3.

Actual results: All three are allowed


Expected results: The last one should be stopped


Additional info:
This is happening because of the conversion from Bytes to GB, In the conversion an integer is obtained, which is rounded. In the logs we see {:allocated=>1, :requested=>0, :limit=>1

Requested = 0 because it's rounded down in the conversion to GB. This effectively means that the user can use up more storage than they are allowed.

Comment 2 Tina Fitzgerald 2015-12-17 20:04:09 UTC

Hi Pete,

This issue is resolved in the new consolidated quota.

Is it okay to close this ticket since this code is deprecated?

Thanks,
Tina

Comment 3 Tina Fitzgerald 2015-12-22 17:12:03 UTC

This issue is resolved in the new consolidated quota.