Bug 1289850

Summary:	Review Request: rubygem-mini_portile2 - Simplistic port-like solution for developers
Product:	[Fedora] Fedora	Reporter:	Mamoru TASAKA <mtasaka>
Component:	Package Review	Assignee:	Ilia Gradina <ilya.gradina>
Status:	CLOSED NEXTRELEASE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	ilya.gradina, package-review
Target Milestone:	---	Flags:	ilya.gradina: fedora-review+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2016-02-16 04:34:27 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Mamoru TASAKA 2015-12-09 07:16:33 UTC

Spec URL: https://mtasaka.fedorapeople.org/Review_request/gem-related/rubygem-mini_portile2.spec
SRPM URL: https://mtasaka.fedorapeople.org/Review_request/gem-related/rubygem-mini_portile2-2.0.0-1.fc.src.rpm
Description: 
Simplistic port-like solution for developers. It provides a standard and
simplified way to compile against dependency libraries without messing up your
system.

Fedora Account System Username: mtasaka

Comment 1 Mamoru TASAKA 2016-01-07 06:12:10 UTC

ping?

Comment 2 Ilia Gradina 2016-01-10 22:20:29 UTC

Hi Mamoru,
Sorry, that for a long time didn't answer.

1. release new version 2.1.0
https://github.com/flavorjones/mini_portile/archive/v2.1.0.tar.gz
2. I don't understand apropos tests. Why not use it :
"ruby -Ilib -e 'Dir.glob "./test/test_*.rb", &method(:require)' "
result :  18 tests, 23 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed

Comment 3 Mamoru TASAKA 2016-01-13 06:51:27 UTC

Thank you for comments.

https://mtasaka.fedorapeople.org/Review_request/gem-related/rubygem-mini_portile2.spec
https://mtasaka.fedorapeople.org/Review_request/gem-related/rubygem-mini_portile2-2.1.0-1.fc.src.rpm

Unfortunately, currently test suite cannot be executed due to missing BR on Fedora (however this is only for executing test suite : runtime dependency is all available on Fedora)

Comment 4 Mamoru TASAKA 2016-01-22 17:31:19 UTC

ping again?

Comment 5 Mamoru TASAKA 2016-01-22 17:32:40 UTC

This package is needed to upgrade rubygem-nokogiri to the latest.

Comment 6 Ilia Gradina 2016-01-22 17:47:47 UTC

Hi Mamoru,
Sorry for the wait.
I approve this package.

Comment 7 Mamoru TASAKA 2016-01-26 03:24:13 UTC

Thank you!

Comment 8 Gwyn Ciesla 2016-01-26 15:52:00 UTC

Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rubygem-mini_portile2

Comment 9 Mamoru TASAKA 2016-02-16 04:34:27 UTC

Already pushed into repository, closing. Thank you for review.