Bug 1289935
| Summary: | Glusterfind hook script failing if /var/lib/glusterd/glusterfind dir was absent | |||
|---|---|---|---|---|
| Product: | [Community] GlusterFS | Reporter: | Aravinda VK <avishwan> | |
| Component: | glusterfind | Assignee: | Aravinda VK <avishwan> | |
| Status: | CLOSED CURRENTRELEASE | QA Contact: | bugs <bugs> | |
| Severity: | unspecified | Docs Contact: | ||
| Priority: | unspecified | |||
| Version: | mainline | CC: | avishwan, khiremat | |
| Target Milestone: | --- | |||
| Target Release: | --- | |||
| Hardware: | Unspecified | |||
| OS: | Unspecified | |||
| Whiteboard: | ||||
| Fixed In Version: | glusterfs-3.8rc2 | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | ||
| Clone Of: | ||||
| : | 1315639 (view as bug list) | Environment: | ||
| Last Closed: | 2016-06-16 13:49:41 UTC | Type: | Bug | |
| Regression: | --- | Mount Type: | --- | |
| Documentation: | --- | CRM: | ||
| Verified Versions: | Category: | --- | ||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | ||
| Cloudforms Team: | --- | Target Upstream Version: | ||
| Embargoed: | ||||
| Bug Depends On: | ||||
| Bug Blocks: | 1315639 | |||
REVIEW: http://review.gluster.org/12923 (tools/glusterfind: Do not fail cleanup script on volume delete) posted (#1) for review on master by Aravinda VK (avishwan) REVIEW: http://review.gluster.org/12923 (tools/glusterfind: Do not fail cleanup script on volume delete) posted (#2) for review on master by Aravinda VK (avishwan) REVIEW: http://review.gluster.org/12923 (tools/glusterfind: Do not fail cleanup script on volume delete) posted (#3) for review on master by Aravinda VK (avishwan) REVIEW: http://review.gluster.org/12923 (tools/glusterfind: Do not fail cleanup script on volume delete) posted (#4) for review on master by Aravinda VK (avishwan) REVIEW: http://review.gluster.org/12923 (tools/glusterfind: Do not fail cleanup script on volume delete) posted (#5) for review on master by Aravinda VK (avishwan) COMMIT: http://review.gluster.org/12923 committed in master by Aravinda VK (avishwan) ------ commit 62047c80f541985bf9caa41336f471d95de3ce1c Author: Aravinda VK <avishwan> Date: Wed Dec 9 17:09:42 2015 +0530 tools/glusterfind: Do not fail cleanup script on volume delete If glusterfind dir is not present inside GLUSTERD_WORKDIR, then cleanup script Post Volume delete was failing. This patch safely handles the absence of glusterfind directory in GLUSTERD_WORKDIR BUG: 1289935 Change-Id: I9f7e6035e3dc6079927803df942b0f921218c79a Signed-off-by: Aravinda VK <avishwan> Reviewed-on: http://review.gluster.org/12923 Smoke: Gluster Build System <jenkins.com> NetBSD-regression: NetBSD Build System <jenkins.org> CentOS-regression: Gluster Build System <jenkins.com> Reviewed-by: Kotresh HR <khiremat> This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.8.0, please open a new bug report. glusterfs-3.8.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution. [1] http://blog.gluster.org/2016/06/glusterfs-3-8-released/ [2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user |
Description of problem: If during cleanup /var/lib/glusterd directory is deleted, glusterfind directory will not be present. The cleanup script expects glusterfind directory to be present. Version-Release number of selected component (if applicable): How reproducible: Always Steps to Reproduce: 1. Install Gluster, rm -rf /var/lib/glusterd except hooks directory. and restart glusterd 2. Create a Volume 3. Delete Volume Actual results: Hook execution errors seen in glusterd logs. [2015-11-11 13:03:41.906892] I [MSGID: 106495] [glusterd-handler.c:3049:__glusterd_handle_getwd] 0-glusterd: Received getwd req [2015-11-11 13:03:41.910931] E [run.c:190:runner_log] (-->/usr/lib64/glusterfs/3.7.5/xlator/mgmt/glusterd.so(+0xef3d2) [0x7fc7d60923d2] -->/usr/lib64/glusterfs/3.7.5/xlator/mgmt/glusterd.so(glusterd_hooks_run_hooks+0x470) [0x7fc7d6092060] -->/usr/lib64/libglusterfs.so.0(runner_log+0x11e) [0x7fc7e162868e] ) 0-management: Failed to execute script: /var/lib/glusterd/hooks/1/delete/post/S57glusterfind-delete-post.py --volname=VOL_ZIMBRA Expected results: No errors seen in Logs Additional info: When executed directly, # /var/lib/glusterd/hooks/1/delete/post/S57glusterfind-delete-post.py --volname=VOL_ZIMBRA Traceback (most recent call last): File "/var/lib/glusterd/hooks/1/delete/post/S57glusterfind-delete-post.py", line 60, in <module> main() File "/var/lib/glusterd/hooks/1/delete/post/S57glusterfind-delete-post.py", line 43, in main for session in os.listdir(glusterfind_dir): OSError: [Errno 2] No such file or directory: '/var/lib/glusterd/glusterfind'