Bug 1290199
Summary: | Review Request: cmake3 - Cross-platform make system | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Helio Chissini de Castro <helio> |
Component: | Package Review | Assignee: | Nobody's working on this, feel free to take it <nobody> |
Status: | CLOSED DUPLICATE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | besser82, helio, ngompa13, orion, package-review, riehecky, roidelapluie, roman |
Target Milestone: | --- | ||
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2016-03-07 09:15:01 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: |
Description
Helio Chissini de Castro
2015-12-09 20:25:38 UTC
Intended for EPEL 7 only Ah, fun, I'll have to compare with http://www.cora.nwra.com/~orion/fedora/cmake34-3.4.1-1.fc21.src.rpm I've been debating between cmake3 and cmake3X myself. We have cmake28 before. Minor releases can be disruptive as well. Isn't /opt a no go? https://fedoraproject.org/wiki/Packaging:Guidelines#Limited_usage_of_.2Fopt.2C_.2Fetc.2Fopt.2C_and_.2Fvar.2Fopt Why do you need a new package for CMake 3.x? Is it backward-compatible with 2.8.x? I still remember that pain with cmake28... Because some projects are now using cmake 3.X features. Any yes, there have been some backward-incompatible changes I believe. There are 2 requirements missing in the spec file BuildRequires: gcc-c++ BuildRequires: make Helio, Because minor versions can be backwards incompatible, I would strongly recommend you rename this to cmake34. This has been done in the past with cmake28 for EL6, and continuing that convention certainly doesn't hurt anything. @Helio Are you still interested to continue this review? besser82's scratch build of cmake3-3.5.0-0.2.rc3.fc25.src.rpm for el6-candidate failed http://koji.fedoraproject.org/koji/taskinfo?taskID=13250371 besser82's scratch build of cmake3-3.5.0-0.2.rc3.fc25.src.rpm for epel7-candidate failed http://koji.fedoraproject.org/koji/taskinfo?taskID=13250375 besser82's scratch build of cmake3-3.5.0-0.2.rc3.fc25.src.rpm for epel7-candidate failed http://koji.fedoraproject.org/koji/taskinfo?taskID=13250407 besser82's scratch build of cmake3-3.5.0-0.2.rc3.fc25.src.rpm for epel7-candidate failed http://koji.fedoraproject.org/koji/taskinfo?taskID=13250422 besser82's scratch build of cmake3-3.5.0-0.2.rc3.fc25.src.rpm for epel7-candidate failed http://koji.fedoraproject.org/koji/taskinfo?taskID=13250453 besser82's scratch build of cmake3-3.5.0-0.2.rc3.fc25.src.rpm for epel7-candidate failed http://koji.fedoraproject.org/koji/taskinfo?taskID=13250570 besser82's scratch build of cmake3-3.5.0-0.2.rc3.fc25.src.rpm for epel7-candidate failed http://koji.fedoraproject.org/koji/taskinfo?taskID=13250679 besser82's scratch build of cmake3-3.5.0-0.2.rc3.fc25.src.rpm for epel7-candidate failed http://koji.fedoraproject.org/koji/taskinfo?taskID=13250801 besser82's scratch build of cmake3-3.5.0-0.2.rc3.fc25.src.rpm for epel7-candidate failed http://koji.fedoraproject.org/koji/taskinfo?taskID=13250872 besser82's scratch build of cmake3-3.5.0-0.2.rc3.fc25.src.rpm for epel7-candidate failed http://koji.fedoraproject.org/koji/taskinfo?taskID=13250940 besser82's scratch build of cmake3-3.5.0-0.2.rc3.fc25.src.rpm for epel7-candidate failed http://koji.fedoraproject.org/koji/taskinfo?taskID=13252343 besser82's scratch build of cmake3-3.5.0-0.2.rc3.fc25.src.rpm for epel7-candidate completed http://koji.fedoraproject.org/koji/taskinfo?taskID=13256061 Since there was no activity from the bug reporter, I've setup a new review-request for this… Closing here as DUPLICATE. *** This bug has been marked as a duplicate of bug 1315193 *** |