Bug 1290231 (rubygem-nifti)

Summary:	Review Request: rubygem-nifti - A pure Ruby API to the NIfTI Neuroimaging Format
Product:	[Fedora] Fedora	Reporter:	Ilia Gradina <ilya.gradina>
Component:	Package Review	Assignee:	Igor Gnatenko <ignatenko>
Status:	CLOSED ERRATA	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	ignatenko, ilya.gradina, package-review
Target Milestone:	---	Flags:	ignatenko: fedora-review+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2016-01-16 13:23:48 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1276941

Description Ilia Gradina 2015-12-09 21:40:24 UTC

Spec URL: https://github.com/neurofedora/rubygem-nifti/raw/master/rubygem-nifti.spec
SRPM URL: https://github.com/neurofedora/rubygem-nifti/raw/master/rubygem-nifti-0.0.2-1.fc24.src.rpm
Description:  A pure Ruby API to the NIfTI Neuroimaging Format
Fedora Account System Username: ilgrad

Comment 1 Igor Gnatenko 2015-12-10 23:08:52 UTC

> Group: Development/Languages
not needed

> License:      LGPLv3
LGPLv3+

Comment 2 Ilia Gradina 2015-12-11 05:06:14 UTC

Hi Igor,

Thanks.

New Spec URL: https://github.com/neurofedora/rubygem-nifti/raw/master/rubygem-nifti.spec
New SRPM URL: https://github.com/neurofedora/rubygem-nifti/raw/master/rubygem-nifti-0.0.2-2.fc24.src.rpm

change license and delete group.

Comment 3 Igor Gnatenko 2015-12-12 13:30:26 UTC

> rubygem-nifti.src: E: description-line-too-long C NIfTI (Neuroimaging Informatics Technology Initiative) is an image format designed primarily
Split line by 80 characters.

> rubygem-nifti.src:85: W: mixed-use-of-spaces-and-tabs (spaces: line 3, tab: line 85)
No comments, just fix it. Use spaces in line #85.

>   sed -i  "s/config.color_enabled = true/config.color = true/g"    spec/spec_helper.rb
you can use:
sed -i "s/config.color_enabled =/config.color =/g" spec/spec_helper.rb


Other stuff looks good. You can fix all stuff during import into Fedora.

APPROVED.

Comment 4 Ilia Gradina 2015-12-14 20:22:03 UTC

Thx Igor,

New Spec URL: https://github.com/neurofedora/rubygem-nifti/raw/master/rubygem-nifti.spec
New SRPM URL: https://github.com/neurofedora/rubygem-nifti/raw/master/rubygem-nifti-0.0.2-3.fc24.src.rpm

Comment 5 Igor Gnatenko 2015-12-14 20:32:54 UTC

Did you requested package in pkgdb?

Comment 6 Ilia Gradina 2015-12-14 20:34:14 UTC

(In reply to Igor Gnatenko from comment #5)
> Did you requested package in pkgdb?

Yes

Comment 7 Upstream Release Monitoring 2015-12-14 20:37:40 UTC

ilgrad's scratch build of rubygem-nifti-0.0.2-3.fc24.src.rpm for rawhide completed http://koji.fedoraproject.org/koji/taskinfo?taskID=12188869

Comment 8 Gwyn Ciesla 2015-12-15 14:44:05 UTC

Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rubygem-nifti

Comment 9 Fedora Update System 2015-12-15 19:41:30 UTC

rubygem-nifti-0.0.2-3.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2015-9a13fa60b9

Comment 10 Fedora Update System 2015-12-17 01:59:45 UTC

rubygem-nifti-0.0.2-3.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report.
If you want to test the update, you can install it with
$ su -c 'dnf --enablerepo=updates-testing update rubygem-nifti'
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2015-9a13fa60b9

Comment 11 Fedora Update System 2016-01-16 13:23:46 UTC

rubygem-nifti-0.0.2-3.fc23 has been pushed to the Fedora 23 stable repository. If problems still persist, please make note of it in this bug report.