Bug 1290495
| Summary: | Review Request: perl-Tie-Handle-Offset - Tied handle that hides the beginning of a file | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Petr Šabata <psabata> |
| Component: | Package Review | Assignee: | Petr Pisar <ppisar> |
| Status: | CLOSED CURRENTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | package-review, ppisar |
| Target Milestone: | --- | Flags: | ppisar:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | perl-Tie-Handle-Offset-0.003-1.fc23 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2016-02-16 15:23:51 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 1290499 | ||
|
Description
Petr Šabata
2015-12-10 16:51:11 UTC
ppisar's scratch build of perl-Tie-Handle-Offset-0.003-1.fc24.src.rpm for f24 completed http://koji.fedoraproject.org/koji/taskinfo?taskID=12147428 I will assume the SRPM file is <https://psabata.fedorapeople.org/pkgs/perl-Tie-Handle-Offset/perl-Tie-Handle-Offset-0.003-1.fc23.src.rpm>. URL and Source0 addresses are usable. Ok. Source archive is original (SHA-256: 0b1c46f0323832d9646e37ac51aca36789a30cfa3dbd3aef913d3218445ffdae). Ok. Summary is applicable to both modules. Ok. Description is applicable to both modules. Ok. License verified from README, LICENSE, lib/Tie/Handle/Offset.pm, lib/Tie/Handle/SkipHeader.pm, t/offset.t, t/skip-header.t, dist.ini. Ok. No XS code, noarch BuildArch is Ok. Build-requires are Ok. All tests pass. Ok. $ rpmlint perl-Tie-Handle-Offset.spec ../SRPMS/perl-Tie-Handle-Offset-0.003-1.fc24.src.rpm ../RPMS/noarch/perl-Tie-Handle-Offset-0.003-1.fc24.noarch.rpm 2 packages and 1 specfiles checked; 0 errors, 0 warnings. rpmlint is Ok. $ rpm -q -lv -p ../RPMS/noarch/perl-Tie-Handle-Offset-0.003-1.fc24.noarch.rpm drwxr-xr-x 2 root root 0 Dec 11 07:54 /usr/share/doc/perl-Tie-Handle-Offset -rw-r--r-- 1 root root 565 Apr 5 2012 /usr/share/doc/perl-Tie-Handle-Offset/Changes -rw-r--r-- 1 root root 1417 Apr 5 2012 /usr/share/doc/perl-Tie-Handle-Offset/README -rw-r--r-- 1 root root 1711 Apr 5 2012 /usr/share/doc/perl-Tie-Handle-Offset/README.PATCHING drwxr-xr-x 2 root root 0 Dec 11 07:54 /usr/share/licenses/perl-Tie-Handle-Offset -rw-r--r-- 1 root root 11500 Apr 5 2012 /usr/share/licenses/perl-Tie-Handle-Offset/LICENSE -rw-r--r-- 1 root root 1813 Dec 11 07:54 /usr/share/man/man3/Tie::Handle::Offset.3pm.gz -rw-r--r-- 1 root root 1444 Dec 11 07:54 /usr/share/man/man3/Tie::Handle::SkipHeader.3pm.gz drwxr-xr-x 2 root root 0 Dec 11 07:54 /usr/share/perl5/vendor_perl/Tie drwxr-xr-x 2 root root 0 Dec 11 07:54 /usr/share/perl5/vendor_perl/Tie/Handle -rw-r--r-- 1 root root 3967 Apr 5 2012 /usr/share/perl5/vendor_perl/Tie/Handle/Offset.pm -rw-r--r-- 1 root root 1409 Apr 5 2012 /usr/share/perl5/vendor_perl/Tie/Handle/SkipHeader.pm File permissions and layout are Ok. $ rpm -q --requires -p ../RPMS/noarch/perl-Tie-Handle-Offset-0.003-1.fc24.noarch.rpm | sort -f | uniq -c 1 perl(:MODULE_COMPAT_5.22.0) 1 perl(strict) 1 perl(Tie::Handle) 1 perl(Tie::Handle::Offset) 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsXz) <= 5.2-1 FIX: Run-require `perl(warnings)' (lib/Tie/Handle/Offset.pm:2). $ rpm -q --provides -p ../RPMS/noarch/perl-Tie-Handle-Offset-0.003-1.fc24.noarch.rpm | sort -f | uniq -c 1 perl(Tie::Handle::Offset) = 0.003 1 perl(Tie::Handle::SkipHeader) = 0.003 1 perl-Tie-Handle-Offset = 0.003-1.fc24 Binary provides are Ok. $ resolvedeps rawhide ../RPMS/noarch/perl-Tie-Handle-Offset-0.003-1.fc24.noarch.rpm Binary dependencies resolvable. Ok. Package builds in F24 (http://koji.fedoraproject.org/koji/taskinfo?taskID=12147428). Ok. Otherwise the package is in line with Fedora and Perl packaging guidelines. Please correct the `FIX' item before building the pacakge. Resolution: Package APPROVED. (In reply to Petr Pisar from comment #2) > I will assume the SRPM file is > <https://psabata.fedorapeople.org/pkgs/perl-Tie-Handle-Offset/perl-Tie- > Handle-Offset-0.003-1.fc23.src.rpm>. Yes, indeed, thanks. > FIX: Run-require `perl(warnings)' (lib/Tie/Handle/Offset.pm:2). Good catch. perl-Tie-Handle-Offset-0.003-1.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2015-cfafdd23e0 perl-Tie-Handle-Offset-0.003-1.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with $ su -c 'dnf --enablerepo=updates-testing update perl-Tie-Handle-Offset' You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2015-cfafdd23e0 perl-Tie-Handle-Offset-0.003-1.fc23 has been pushed to the Fedora 23 stable repository. If problems still persist, please make note of it in this bug report. |