Bug 1290913

> Remove:
> rm -rf $RPM_BUILD_ROOT

For that see the rationale at: https://fedorahosted.org/rpmdevtools/ticket/25

But else: yes, some people use these tools when preparing a package for a Fedora review request. And things like the empty %doc line are not a good idea either.

As a compromise, why not add a comment line to the %install section tool's output?

| %install
| # cleaning up the Buildroot here is only necessary for EL5
| # or if the redhat-rpm-config package is not installed
| rm -rf $RPM_BUILD_ROOT
| %make_install

I think it's an upstream/downstream thing. I don't know (or care) what the upstream default should be, but the Fedora template should follow our guidelines. It really doesn't make sense to have stuff in the Fedora template which is not useful for Fedora. Since it is not possible to serve all cases properly, imho the Fedora package should just follow the guidelines as much as possible, without any legacy stuff.

(In reply to Zbigniew Jędrzejewski-Szmek from comment #0)
> Update:
> make %{?_smp_mflags} → %make_build

https://git.fedorahosted.org/cgit/rpmdevtools.git/commit/?id=dcf1005d2cca7ce2a541718425f84d65fe8b8d00

> %setup -q → %autosetup

https://git.fedorahosted.org/cgit/rpmdevtools.git/commit/?id=cd37dabffc135170311bdef3f2fa712c44e90d89

> In %files, add something like %license LICENSE to remind people to use the
> new macro.

See bug 1256815.

> For initial python spec file, the new template should be used:
> https://fedoraproject.org/wiki/Packaging:Python#Example_common_spec_file

Probably, but at least some modifications should be made, at least use the python3_pkgversion stuff for EPEL Python 3.

(In reply to Michael Schwendt from comment #1)
> As a compromise, why not add a comment line to the %install section tool's
> output?

No, that would make it "wrong" for everyone out of the box, requiring manual removal of the comments, and the comments are subject to bitrot.

(In reply to Zbigniew Jędrzejewski-Szmek from comment #2)
> Since it is not possible to serve all cases properly, imho [...]

IMNSHO we already do a good job of serving all cases properly right now. It's amazing how people have the energy to nitpick over this single harmless line, which does not make the produced specfiles improper in any environment. I'm not going to remove it.

rpmdevtools-8.7-1.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2016-e11971c7e9

rpmdevtools-8.7-1.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2016-9a18dce7e1

rpmdevtools-8.7-1.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-9a18dce7e1

rpmdevtools-8.7-1.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-e11971c7e9

rpmdevtools-8.8-1.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2016-e11971c7e9

rpmdevtools-8.8-1.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2016-9a18dce7e1

rpmdevtools-8.9-1.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-e11971c7e9

rpmdevtools-8.9-1.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-9a18dce7e1

rpmdevtools-8.9-1.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report.

rpmdevtools-8.9-1.fc23 has been pushed to the Fedora 23 stable repository. If problems still persist, please make note of it in this bug report.