Bug 1291200
Summary: | perl-GD-2.56-5.fc24 FTBFS: Failed test 'image comparison test 7' | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Petr Pisar <ppisar> |
Component: | perl-GD | Assignee: | Paul Howarth <paul> |
Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | unspecified | Docs Contact: | |
Priority: | unspecified | ||
Version: | rawhide | CC: | paul, perl-devel, tcallawa |
Target Milestone: | --- | ||
Target Release: | --- | ||
Hardware: | Unspecified | ||
OS: | Unspecified | ||
URL: | http://koji.fedoraproject.org/koji/taskinfo?taskID=12051912 | ||
Whiteboard: | |||
Fixed In Version: | perl-GD-2.56-6.fc24 | Doc Type: | Bug Fix |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2015-12-14 15:12:37 UTC | Type: | Bug |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: |
Description
Petr Pisar
2015-12-14 09:38:16 UTC
Please note this blocks perl-Business-ISBN that blocks perl-URI that blocks perl-HTML-Parser that blocks another 1300 packages. Maybe we should move URI::urn::isbn from perl-URI into a new sub-package (for example perl-URI-urn-isbn). That new subpackage would still require perl-Business-ISBN, but it wouldn't be required by perl-URI. (We already have the Business::ISBN BuildRequire conditionalized by %perl_bootstrap, but for some reason, the run Require is not. That does not make sense for me.) The test failure is caused by upgrading freetype from 2.6.1-1.fc24 to 2.6.2-1.fc24. (In reply to Petr Pisar from comment #1) > (We already > have the Business::ISBN BuildRequire conditionalized by %perl_bootstrap, but > for some reason, the run Require is not. That does not make sense for me.) Omitting a BuildRequire during bootstrapping generally results in fewer tests being run but the resulting binary package is exactly the same as it would have been with the BuildRequire present. On the other hand, omitting a run Require results in a different binary package, and hence different buildroots for every package that is built using the bootstrapped package. So you'd want to rebuild all of those packages too post-bootstrap to make sure all their tests ran successfully, which would potentially extend the bootstrap process quite significantly. I think it might be worthwhile to disable the image comparison test: https://rt.cpan.org/Public/Bug/Display.html?id=100294 (In reply to Paul Howarth from comment #3) > (In reply to Petr Pisar from comment #1) > > (We already > > have the Business::ISBN BuildRequire conditionalized by %perl_bootstrap, but > > for some reason, the run Require is not. That does not make sense for me.) > > Omitting a BuildRequire during bootstrapping generally results in fewer > tests being run but the resulting binary package is exactly the same as it > would have been with the BuildRequire present. > > On the other hand, omitting a run Require results in a different binary > package, and hence different buildroots for every package that is built > using the bootstrapped package. So you'd want to rebuild all of those > packages too post-bootstrap to make sure all their tests ran successfully, > which would potentially extend the bootstrap process quite significantly. > I know (*). But what's the purpose of omitting some tests? Especially on perl_bootstrap? With current perl-URI.spec you will get binary package that cannot be installed either, so it should not have any effect on build graph when bootstrapping. (* Pure theoretically, having installed additional packages at build time should be idempotent. That's what I expect from good build script.) > I think it might be worthwhile to disable the image comparison test: > https://rt.cpan.org/Public/Bug/Display.html?id=100294 Ah. yet another instance of the failure. That would be probably the simplest fix. I made that failing text test a TODO test. Thanks. |