Bug 1292217

Summary:	package command fails due to missing requires on libguestfs-tools-c
Product:	[Fedora] Fedora	Reporter:	Roland Grunberg <rgrunber>
Component:	vagrant-libvirt	Assignee:	Vít Ondruch <vondruch>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	high	Docs Contact:
Priority:	high
Version:	rawhide	CC:	dima85, fedora, hhorak, madam, msekleta, rjones, tbarron, vondruch
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Linux
Whiteboard:
Fixed In Version:	vagrant-libvirt-0.0.37-2.fc26	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2017-02-06 12:49:00 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Roland Grunberg 2015-12-16 18:39:37 UTC

(Assuming the user has already set read permissions for the base image under /var/lib/libvirt/images/ )

The first error is due to missing requires on libguestfs-tools-c , which provides virt-sysprep

$ vagrant package 624a8d7 --output foo.box
WARNING: Nokogiri was built against LibXML version 2.9.2, but has dynamically loaded 2.9.3
==> f23lbox: translation missing: en.vagrant_libvirt.package_domain
==> f23lbox: Image has backing image, copying image and rebasing ...
/home/rgrunberg/.vagrant.d/gems/gems/vagrant-libvirt-0.0.32/lib/vagrant-libvirt/action/package_domain.rb:40:in ``': No such file or directory - virt-sysprep (Errno::ENOENT)
	from /home/rgrunberg/.vagrant.d/gems/gems/vagrant-libvirt-0.0.32/lib/vagrant-libvirt/action/package_domain.rb:40:in `call'
	from /usr/share/vagrant/lib/vagrant/action/warden.rb:34:in `call'
	from /usr/share/vagrant/lib/vagrant/action/builtin/config_validate.rb:25:in `call'
	from /usr/share/vagrant/lib/vagrant/action/warden.rb:34:in `call'
	from /usr/share/vagrant/lib/vagrant/action/builder.rb:116:in `call'
	from /usr/share/vagrant/lib/vagrant/action/runner.rb:66:in `block in run'
	from /usr/share/vagrant/lib/vagrant/util/busy.rb:19:in `busy'
	from /usr/share/vagrant/lib/vagrant/action/runner.rb:66:in `run'
	from /usr/share/vagrant/lib/vagrant/machine.rb:214:in `action_raw'
	from /usr/share/vagrant/lib/vagrant/machine.rb:191:in `block in action'
	from /usr/share/vagrant/lib/vagrant/environment.rb:516:in `lock'
	from /usr/share/vagrant/lib/vagrant/machine.rb:178:in `call'
	from /usr/share/vagrant/lib/vagrant/machine.rb:178:in `action'
	from /usr/share/vagrant/plugins/commands/package/command.rb:83:in `package_vm'
	from /usr/share/vagrant/plugins/commands/package/command.rb:72:in `block in package_target'
	from /usr/share/vagrant/lib/vagrant/plugin/v2/command.rb:226:in `block in with_target_vms'
	from /usr/share/vagrant/lib/vagrant/plugin/v2/command.rb:220:in `each'
	from /usr/share/vagrant/lib/vagrant/plugin/v2/command.rb:220:in `with_target_vms'
	from /usr/share/vagrant/plugins/commands/package/command.rb:70:in `package_target'
	from /usr/share/vagrant/plugins/commands/package/command.rb:44:in `execute'
	from /usr/share/vagrant/lib/vagrant/cli.rb:42:in `execute'
	from /usr/share/vagrant/lib/vagrant/environment.rb:301:in `cli'
	from /usr/share/vagrant/bin/vagrant:179:in `<main>'

Comment 1 Gerard Ryan 2016-01-17 21:09:09 UTC

Installing libguestfs-tools-c fixed this issue for me. Thanks Roland!

Comment 2 Vít Ondruch 2016-08-08 11:51:05 UTC

Hmmm, not sure I want to add 'Requires: %{_bindir}/virt-sysprep' ... probably Recommends would be better ... thoughts?

Comment 3 Richard W.M. Jones 2016-08-08 12:39:39 UTC

Can't offer much advice except to read:
https://fedoraproject.org/wiki/Packaging:Guidelines#Weak_dependencies

and don't require "libguestfs-tools" (which will pull in Perl).

Comment 4 Fedora End Of Life 2016-11-24 14:16:58 UTC

This message is a reminder that Fedora 23 is nearing its end of life.
Approximately 4 (four) weeks from now Fedora will stop maintaining
and issuing updates for Fedora 23. It is Fedora's policy to close all
bug reports from releases that are no longer maintained. At that time
this bug will be closed as EOL if it remains open with a Fedora  'version'
of '23'.

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, simply change the 'version' 
to a later Fedora version.

Thank you for reporting this issue and we are sorry that we were not 
able to fix it before Fedora 23 is end of life. If you would still like 
to see this bug fixed and are able to reproduce it against a later version 
of Fedora, you are encouraged  change the 'version' to a later Fedora 
version prior this bug is closed as described in the policy above.

Although we aim to fix as many bugs as possible during every release's 
lifetime, sometimes those efforts are overtaken by events. Often a 
more recent Fedora release includes newer upstream software that fixes 
bugs or makes them obsolete.

Comment 5 Vít Ondruch 2016-11-25 15:27:01 UTC

This is very likely still issue ...

Comment 6 Michal Sekletar 2016-12-23 13:07:47 UTC

(In reply to Vít Ondruch from comment #5)
> This is very likely still issue ...

Indeed. I encountered this problem today. Btw, I am also +1 on Recommends: libguestfs-tools-c in vagrant-libvirt.spec.