Bug 1292221

Created attachment 1106507 [details]
faxgetty systemd service file copied from mgetty

Description of problem:
RPM lacks a systemd service file for faxgetty activation
 
Version-Release number of selected component (if applicable):
https://dl.fedoraproject.org/pub/epel/7/SRPMS/h/hylafax+-5.5.6-1.el7.src.rpm
 
How reproducible:
Always
 
Steps to Reproduce:
$ rpm -qpl hylafax+-5.5.6-1.el7.x86_64.rpm |grep service
 
Actual results:
/usr/lib/systemd/system/hylafax-faxq.service
/usr/lib/systemd/system/hylafax-hfaxd.service
 
Expected results:
/usr/lib/systemd/system/hylafax-faxq.service
/usr/lib/systemd/system/hylafax-hfaxd.service
/usr/lib/systemd/system/hylafax-faxgetty@.service or faxgetty@.service

Additional info:
I took RHEL7 mgetty systemd file and replaced mgetty->faxgetty and attached it
to this bug.
 
You decide whether it should be hylafax-faxgetty@.service or faxgetty@.service
 
RPM scripts and systemctl:
- The mgetty's rpm only does "systemctl daemon-reload", nothing more.
- For installation, there's nothing to be done, the user has to activate it
  manually depending on the device in use, ie:
  systemctl enable faxgetty@ttyS0
- However, when uninstalling/upgrading something could be done.
  The following examples are using faxgetty@.service (not hylafax-faxgetty)
  and need testing:
 
# for preun
for device_file in /var/spool/hylafax/FIFO.tty*
do
    if [ -p $device_file ]; then
        device=${device_file#*FIFO.}
        /bin/systemctl --no-reload disable faxgetty@${device}.service > /dev/null 2>&1 || :
        /bin/systemctl stop faxgetty@${device}.service > /dev/null 2>&1 || :
    fi
done
 
# for postun
for device_file in /var/spool/hylafax/FIFO.tty*
do
    if [ -p $device_file ]; then
        device=${device_file#*FIFO.}
        /bin/systemctl try-restart faxgetty@${device}.service >/dev/null 2>&1 || :
    fi
done

More tests could be done to check whether each FIFO.tty* file actually has a corresponding systemd service enabled (ie: if user really has enabled faxgetty for that device), but maybe it's overkill, at least for now.