Bug 1292236

Summary: Syslinux/Extlinux command line interface broken
Product: [Fedora] Fedora Reporter: poma <pomidorabelisima>
Component: syslinuxAssignee: Peter Jones <pjones>
Status: CLOSED DUPLICATE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: rawhideCC: mattdm, pjones
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2016-02-16 15:29:32 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description poma 2015-12-16 19:38:02 UTC
Description of problem:
Syslinux/Extlinux command line interface broken

Version-Release number of selected component (if applicable):
syslinux-6.03-6.fc2[34]

How reproducible:
101%

Steps to Reproduce:
1. Interrupt boot in progress - [Esc]
2. Run cmd at boot prompt, e.g.   
   boot: reboot + [Enter]

Actual results:
"Skip" to the menu

Expected results:
Reboot

Additional info:
CLI works with:
syslinux-extlinux-nonlinux-6.04-11.git20151210.fc24.noarch
the last built, tested and operational.

Comment 1 poma 2015-12-19 10:03:46 UTC
Also tested with:
syslinux-extlinux-nonlinux-6.04-0.12.20151210git721a0af.fc24.noarch
syslinux-efi64-6.04-0.12.20151210git721a0af.fc24.x86_64

Comment 2 poma 2016-02-15 23:50:22 UTC
ldlinux: Fix return pointer to local data
http://git.zytor.com/syslinux/syslinux.git/commit/?id=8dc6d75

The command-line parsing used to return a pointer to a local array. The
code used to work by chance, but now, gcc 5 is able to detect it and
return a NULL pointer instead.

The buffer is now marked static. This shouldn't be a problem as only one
command line can be read at a time.
...

it also makes complete GCC 5 related patches:
- bios: Fix alignment change with gcc 5
  http://git.zytor.com/syslinux/syslinux.git/commit/?id=e5f2b57
- bios: Don't try to guess the sections alignment
  http://git.zytor.com/syslinux/syslinux.git/commit/?id=0cc9a99

Comment 3 poma 2016-02-16 15:29:32 UTC
So they are no longer two, but one in #1308298.

*** This bug has been marked as a duplicate of bug 1308298 ***