Bug 1292371

Summary: vdsm logs the wrong xml when dehibernating
Product: [oVirt] vdsm Reporter: Francesco Romani <fromani>
Component: CoreAssignee: Francesco Romani <fromani>
Status: CLOSED CURRENTRELEASE QA Contact: sefi litmanovich <slitmano>
Severity: low Docs Contact:
Priority: low    
Version: 4.17.11CC: bkorren, bugs, danken, eedri, sbonazzo
Target Milestone: ovirt-3.6.2Flags: danken: ovirt-3.6.z?
rule-engine: planning_ack?
rule-engine: devel_ack+
rule-engine: testing_ack+
Target Release: 4.17.15   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2016-02-18 11:18:48 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: Virt RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Francesco Romani 2015-12-17 08:39:54 UTC 
Description of problem:
When dehibernating (aka restoring state aka migrating from file) VDSM logs the wrong XML.
The XML being logged is the one which would be created if the VM will be started from scratch again, not the one actually used, and store in the VM state.

Version-Release number of selected component (if applicable):
4.17.x

How reproducible:
100%

Steps to Reproduce:
1. hibernate a VM
2. dehibernate a VM
3. check the logs, compare what Vdsm logs to what Vdsm stored in the recovery file, and to what libvirt sees (virsh -r dumpxml $DOMAIN)

Actual results:
wrong (and meaningless) XML is logged

Expected results:
Vdsm logs the actual XML it sent to libvirt

Additional info:
This change affects only logging, to help troubleshooting. No changes in flow.
Comment 1 Sandro Bonazzola 2015-12-23 15:00:52 UTC 
QE note, not in vdsm-4.17.14
Comment 2 Barak Korren 2015-12-29 14:48:59 UTC 
RHEV build 3.6.2-3 released
http://bob.eng.lab.tlv.redhat.com/builds/3.6/3.6.2-3/
Comment 3 sefi litmanovich 2016-01-07 13:26:42 UTC 
Verified with rhevm-3.6.2-0.1.el6.noarch on both vdsm-4.17.14-0.el7ev.noarch and vdsm-4.17.15-0.el7ev.noarch hosts.

In both cases after hibernate and de-hibernate the xml in vdsm log correlates to the xml from qemu.
Comment 4 sefi litmanovich 2016-01-07 13:27:01 UTC 
Verified with rhevm-3.6.2-0.1.el6.noarch on both vdsm-4.17.14-0.el7ev.noarch and vdsm-4.17.15-0.el7ev.noarch hosts.

In both cases after hibernate and de-hibernate the xml in vdsm log correlates to the xml from qemu.