Bug 1292387

Summary: [ovirt-guest-agent] Windows 10 and Windows 8.1 are reported as Win 8, Windows Server 2012 R2 as Windows Server 2012
Product: Red Hat Enterprise Virtualization Manager Reporter: Vinzenz Feenstra [evilissimo] <vfeenstr>
Component: ovirt-guest-agentAssignee: Vinzenz Feenstra [evilissimo] <vfeenstr>
Status: CLOSED CURRENTRELEASE QA Contact: Jiri Belka <jbelka>
Severity: medium Docs Contact:
Priority: high    
Version: 3.5.6CC: bugs, didi, ecohen, gklein, jbelka, lsurette, lveyde, mgoldboi, michal.skrivanek, mkenneth, omachace, phou, rbalakri, sbonazzo, tjelinek, yeylon
Target Milestone: ovirt-3.5.7Keywords: ZStream
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard: virt
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Windows 8.1 and Windows 10 were misreported as Windows 8 in the UI (similarly Windows 2012R2 as 2012). This is now fixed
 Story Points: ---
Clone Of: 1279980 Environment:
Last Closed: 2016-01-18 13:35:26 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: Virt RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 1279980    
Bug Blocks: 1232584, 1273808    

Description Vinzenz Feenstra [evilissimo] 2015-12-17 09:47:23 UTC 
+++ This bug was initially created as a clone of Bug #1279980 +++

Description of problem:

~~~
ed875d98-e407-4b07-967a-363cbecf3bb3
        Status = Up
        acpiEnable = true
        emulatedMachine = rhel6.5.0
        pid = 11785
        memGuaranteedSize = 930
        transparentHugePages = true
        displaySecurePort = 5900
        spiceSslCipherSuite = DEFAULT
        cpuType = Westmere
        smp = 2
        hypervEnable = true
        custom = {}
        vmType = kvm
        memSize = 2048
        smpCoresPerSocket = 1
        vmName = jb-w10-x64
...
~~~

~~~
ed875d98-e407-4b07-967a-363cbecf3bb3
        Status = Up
        displayInfo = [{'tlsPort': '5900', 'ipAddress': '10.34.62.40', 'port': '-1', 'type': 'spice'}]
        memUsage = 35
        acpiEnable = true
        pid = 11785
...
        appsList = ['QEMU guest agent', 'RHEV-Spice-Agent64 3.5.2', 'RHEV-Serial64 3.5.3', 'RHEV-Agent64 3.5.7', 'RHEV-Network64 3.5.2', 'RHEV-Block64 3.5.3', 'RHEV-SSO64 3.5.2', 'RHEV-Tools 3.5.10', 'RHEV-Balloo
n64 3.5.3', 'RHEV-SCSI64 3.5.2']
        guestOs = Win 8
        guestFQDN = DESKTOP-2A7IVG7.rhev.lab.eng.brq.redhat.com
        hash = 5295256131457450912
...
~~~

~~~
...
Dummy-1::INFO::2015-11-10 15:59:55,345::ovirtguestservice::94::root::Stopping OVirt Guest Agent service
Dummy-1::INFO::2015-11-10 16:00:48,424::ovirtguestservice::80::root::Starting OVirt Guest Agent service
Dummy-1::DEBUG::2015-11-10 16:00:48,424::ovirtagentlogic::162::root::AgentLogicBase:: __init__() entered
Dummy-1::DEBUG::2015-11-10 16:00:48,438::guestagentwin32::218::root::WinOsTypeHandler::getWinOsType osType = 'Win 8'
Dummy-1::DEBUG::2015-11-10 16:00:48,438::guestagentwin32::633::root::WinVdsAgent:: run() entered
Dummy-1::DEBUG::2015-11-10 16:00:48,517::ovirtagentlogic::186::root::AgentLogicBase:: run() entered
Dummy-2::DEBUG::2015-11-10 16:00:48,517::ovirtagentlogic::203::root::AgentLogicBase:: doWork() entered
Dummy-2::DEBUG::2015-11-10 16:00:48,517::ovirtagentlogic::249::root::AgentLogicBase::doListen() - entered
Dummy-2::DEBUG::2015-11-10 16:00:48,517::ovirtagentlogic::256::root::AgentLogicBase::doListen() - in loop before vio.read
Dummy-2::DEBUG::2015-11-10 16:00:48,627::guestagentwin32::495::root::Active user: user@DESKTOP-2A7IVG7
Dummy-2::DEBUG::2015-11-10 16:00:48,627::ovirtagentlogic::337::root::AgentLogicBase::sendUserInfo - cur_user = 'user@DESKTOP-2A7IVG7'
...
~~~

Version-Release number of selected component (if applicable):
RHEV-Agent64 3.5.7 / RHEV-toolsSetup_3.5_10.iso

How reproducible:
100%

Steps to Reproduce:
1. install WGT on either Win 10 32bit or 64 bit
2. check what guestOs is about
3.

Actual results:
windows 10 detected as windows 8

Expected results:
should be detected as windows 10

Additional info:

--- Additional comment from Michal Skrivanek on 2015-11-13 14:05:02 CET ---

actually Windows 8.1 is already reported as "Windows 8"

--- Additional comment from Vinzenz Feenstra [evilissimo] on 2015-11-25 10:06:22 CET ---



--- Additional comment from Vinzenz Feenstra [evilissimo] on 2015-11-27 15:35:44 CET ---

Additional Note:

This BZ will also fix Win 2012R2 being reported as Win2012 and includes already the upcoming Win2016 Server
Comment 4 Michal Skrivanek 2015-12-21 13:37:15 UTC 
pending a Windows build
Comment 7 Jiri Belka 2016-01-06 16:30:05 UTC 
with 3.6.3 WGT iso

- w2k12r2

        guestOs = Win 2012 R2
        guestOsInfo = {'kernel': '', 'arch': 'x86_64', 'version': '6.3', 'distribution': '', 'type': 'windows', 'codename': 'Win 2012 R2'}

- w10 64bit

        guestOs = Win 10
        guestOsInfo = {'kernel': '', 'arch': 'x86_64', 'version': '10.0', 'distribution': '', 'type': 'windows', 'codename': 'Win 10'}

- w8.1 64bit

        guestOs = Win 8.1
        guestOsInfo = {'kernel': '', 'arch': 'x86_64', 'version': '6.3', 'distribution': '', 'type': 'windows', 'codename': 'Win 8.1'}

        guestOs = Win 2008 R2
        guestOsInfo = {'kernel': '', 'arch': 'x86_64', 'version': '6.1', 'distribution': '', 'type': 'windows', 'codename': 'Win 2008 R2'}
Comment 8 Gil Klein 2016-01-07 09:02:07 UTC 
Moved to assigned based on comment #6 + #7
Comment 9 Vinzenz Feenstra [evilissimo] 2016-01-07 09:04:36 UTC 
Lev, when you fixed the build put it back to ON_QA please
Comment 11 Lev Veyde 2016-01-07 10:30:40 UTC 
(In reply to Vinzenz Feenstra [evilissimo] from comment #9)
> Lev, when you fixed the build put it back to ON_QA please

The build can be tested, i'll release a new build soon with the fix for the missing SOURCES and LICENSES files, but beyond that the RPM should be OK for both 3.5 and 3.6.
Comment 15 Jiri Belka 2016-01-07 17:08:48 UTC 
As #7 was about 3.6.3 WGT this is about 3.5-14 WGT iso (guestOsInfo is 3.6 feature only):

- w2k12r2

        guestOs = Win 2012 R2

- w10 64bit

        guestOs = Win 10


- w8.1 64bit

        guestOs = Win 8.1
Comment 16 Eyal Edri 2016-01-18 13:35:26 UTC 
3.5.7 was released.