Bug 1292961

Summary: [DOCS] [RFE] Flag in Hosts file to keep ansible from overwriting the node-config and master-config
Product: OpenShift Container Platform Reporter: Ryan Howe <rhowe>
Component: DocumentationAssignee: Timothy <tpoitras>
Status: CLOSED CURRENTRELEASE QA Contact: Xiaoli Tian <xtian>
Severity: medium Docs Contact: Vikram Goyal <vigoyal>
Priority: low    
Version: 3.1.0CC: aos-bugs, bleanhar, erich, jdetiber, jokerman, mmccomas, rhowe, vigoyal
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2016-08-29 06:00:12 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Ryan Howe 2015-12-18 21:02:43 UTC
Description of problem: Wanting a flag that can be set in the /etc/ansible/host file to keep the playbook from overwriting the node-config.yaml and master-config.yaml 



Version-Release number of selected component (if applicable):
3.1

Comment 4 Dan McPherson 2016-04-14 18:38:41 UTC
@bleanhar This would have gone into 3.1.1 right?

Comment 5 Brenton Leanhardt 2016-04-14 19:01:52 UTC
Yes, that PR was definitely released so we just need to have it formally verified.

Comment 6 Ma xiaoqiang 2016-04-15 00:32:17 UTC
The user do not want to overwrite the master and node configuration file, the RP#1095 only make sure that the service will not be restarted if the configuration file is not changed. I think the PR is not sufficient.

Comment 8 Brenton Leanhardt 2016-05-06 14:33:32 UTC
I think it would be better to simply add support for whatever the admin needs to set.  If you tell us the most urgent settings we'll have it added in.

Comment 9 Brenton Leanhardt 2016-05-06 18:08:59 UTC
Another thing to mention is that whenever the master and node configuration files are updated a backup is created so that an admin could merge their settings with the configuration ansible is installing.  We realize that's not ideal so it's better just to support the other values.

Comment 10 Brenton Leanhardt 2016-05-12 15:22:04 UTC
I'd like to close this bug in favor of adding support for whatever configuration settings are most urgent.

Comment 11 Eric Rich 2016-05-13 13:19:28 UTC
(In reply to Brenton Leanhardt from comment #8)
> I think it would be better to simply add support for whatever the admin
> needs to set.  If you tell us the most urgent settings we'll have it added
> in.

I am going to try and link this request to the docs as much as possible (with the top 5 being the priority). Anywhere we mention to an admin where they should modify the node-config.yaml and master-config.yaml is likely what we want to focus on. 

List: 

Custom Certificates: 
https://docs.openshift.com/enterprise/3.2/install_config/certificate_customization.html

Configure Authentication: 
https://docs.openshift.com/enterprise/3.2/install_config/configuring_authentication.html

Configure Networking (SDN): 
https://docs.openshift.com/enterprise/3.2/install_config/configuring_sdn.html

Proxy Configurations: 
https://docs.openshift.com/enterprise/3.2/install_config/http_proxies.html

Defaults and Overrides: 
https://docs.openshift.com/enterprise/3.2/install_config/build_defaults_overrides.html

Web Console Modifications: 
https://docs.openshift.com/enterprise/3.2/install_config/web_console_customization.html

Configuring IaaS Platform: 
  AWS: https://docs.openshift.com/enterprise/3.2/install_config/configuring_aws.html
  GCE: https://docs.openshift.com/enterprise/3.2/install_config/configuring_gce.html
  OpenStack: https://docs.openshift.com/enterprise/3.2/install_config/configuring_openstack.html

Comment 13 Jason DeTiberus 2016-05-31 15:51:15 UTC
The vast majority of these (I haven't validated each and every configuration option from the links) are already configurable through openshift-ansible, at least when using the Advanced installation.

The one glaringly standing out as unsupported right now is the GCE cloud provider.

Comment 14 Eric Rich 2016-05-31 17:40:27 UTC
(In reply to Jason DeTiberus from comment #13)
> The vast majority of these (I haven't validated each and every configuration
> option from the links) are already configurable through openshift-ansible,
> at least when using the Advanced installation.
> 
> The one glaringly standing out as unsupported right now is the GCE cloud
> provider.

If this is the case, then lets work with this as a documentation bug? and ask Docs, if they can update the install steps to explain how to configure openshif for the configurations denoted. 

With this in place, we can then link the sections denoted to the configuration examples, in the install section. Thought?

Comment 23 Timothy 2016-07-27 08:47:16 UTC
OK, I think I've covered all of these. 
Docs PR: https://github.com/openshift/openshift-docs/pull/2350

This is going to need a lengthy review. Some of the topics got a light restructure.

So, tech review, please? :)

Here are the topics I've touched/added sections to:

Custom Certificates: 
http://file.bne.redhat.com/tpoitras/2016/ansiblehosts/openshift-enterprise/ansibleflaginhosts-BZ1292961/install_config/certificate_customization.html

Configure Authentication: 
http://file.bne.redhat.com/tpoitras/2016/ansiblehosts/openshift-enterprise/ansibleflaginhosts-BZ1292961/install_config/configuring_authentication.html#identity-providers-ansible

Configure Networking (SDN): 
http://file.bne.redhat.com/tpoitras/2016/ansiblehosts/openshift-enterprise/ansibleflaginhosts-BZ1292961/install_config/configuring_sdn.html#configuring-the-pod-network-with-ansible

Proxy Configurations: 
http://file.bne.redhat.com/tpoitras/2016/ansiblehosts/openshift-enterprise/ansibleflaginhosts-BZ1292961/install_config/http_proxies.html#configuring-hosts-for-proxies

Defaults and Overrides: 
http://file.bne.redhat.com/tpoitras/2016/ansiblehosts/openshift-enterprise/ansibleflaginhosts-BZ1292961/install_config/build_defaults_overrides.html#setting-global-build-defaults

Web Console Modifications: 
http://file.bne.redhat.com/tpoitras/2016/ansiblehosts/openshift-enterprise/ansibleflaginhosts-BZ1292961/install_config/web_console_customization.html

AWS:
http://file.bne.redhat.com/tpoitras/2016/ansiblehosts/openshift-enterprise/ansibleflaginhosts-BZ1292961/install_config/configuring_aws.html#aws-configuring-masters

OpenStack:
http://file.bne.redhat.com/tpoitras/2016/ansiblehosts/openshift-enterprise/ansibleflaginhosts-BZ1292961/install_config/configuring_openstack.html#openstack-configuring-masters

Comment 30 Timothy 2016-08-19 03:43:02 UTC
Ack from Eric, Peer review complete. Merging! https://github.com/openshift/openshift-docs/pull/2350

Comment 32 Red Hat Bugzilla 2023-09-14 03:15:06 UTC
The needinfo request[s] on this closed bug have been removed as they have been unresolved for 1000 days