Bug 1293015

Summary: kernel-tests: scripts need fixes to run under Python3
Product: [Fedora] Fedora Reporter: Craig Rodrigues <rodrigc>
Component: kernelAssignee: Kernel Maintainer List <kernel-maint>
Status: CLOSED CURRENTRELEASE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: low Docs Contact:
Priority: unspecified    
Version: 23CC: gansalmon, itamar, jforbes, jonathan, kernel-maint, madhu.chinakonda, mchehab, pviktori
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2015-12-21 21:13:33 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
0001-Use-print-as-a-function-for-Python-3.-PEP-3105.patch.txt
none
0002-Use-repr-instead-of-backticks.-PEP-3099.patch.txt
none
0003-Fix-exception-handling-syntax.-PEP-3110.patch.txt
none
0004-Use-input-instead-of-raw_input-.-PEP-3111.patch.txt
none
0005-Remove-extra-parentheses.patch.txt none

Description Craig Rodrigues 2015-12-19 06:44:42 UTC
Created attachment 1107592 [details]
0001-Use-print-as-a-function-for-Python-3.-PEP-3105.patch.txt

I originally sent this e-mail: https://lists.fedoraproject.org/archives/list/python-devel%40lists.fedoraproject.org/thread/3EP3MBRQNGC56VTUWFA74L3Y7VKYXC5P/

but was told that I should follow up with a bug.

The kernel-tests scripts at https://git.fedorahosted.org/git/kernel-tests.git
have Python code which does not run under Python3.

The attached patches fix these problems.

Comment 1 Craig Rodrigues 2015-12-19 06:45:16 UTC
Created attachment 1107593 [details]
0002-Use-repr-instead-of-backticks.-PEP-3099.patch.txt

Comment 2 Craig Rodrigues 2015-12-19 06:45:48 UTC
Created attachment 1107594 [details]
0003-Fix-exception-handling-syntax.-PEP-3110.patch.txt

Comment 3 Craig Rodrigues 2015-12-19 06:46:52 UTC
Created attachment 1107595 [details]
0004-Use-input-instead-of-raw_input-.-PEP-3111.patch.txt

Comment 4 Justin M. Forbes 2015-12-21 21:13:33 UTC
These were applied.  Thanks!

Comment 5 Craig Rodrigues 2015-12-21 21:32:56 UTC
Created attachment 1108487 [details]
0005-Remove-extra-parentheses.patch.txt

Comment 6 Craig Rodrigues 2015-12-21 21:56:59 UTC
(In reply to Craig Rodrigues from comment #5)
> Created attachment 1108487 [details]
> 0005-Remove-extra-parentheses.patch.txt

Thanks for accepting my patches.  Here is another small fix, and then I'm done. :)

On a separate note, I submitted similar small fix to kerneltest-harness: https://github.com/jmflinuxtx/kerneltest-harness/pull/21

but I guess I can follow up that on github rather than in this bug.

Comment 7 Justin M. Forbes 2015-12-21 22:12:41 UTC
Yup, I saw your updates there, but I want the others to have a look at them before I apply. Guessing this won't happen until the new year with the holidays here and half the folks already on vacation.

Comment 8 Petr Viktorin (pviktori) 2016-05-10 20:35:16 UTC
Hello,
Should a separate bug be opened for that last patch?