Bug 1293045
| Summary: | Review Request: fontopia - the console font editor | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Mohammed Isam <mohammed_isam1984> |
| Component: | Package Review | Assignee: | Zbigniew Jędrzejewski-Szmek <zbyszek> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | package-review, zbyszek |
| Target Milestone: | --- | Keywords: | Reopened |
| Target Release: | --- | Flags: | zbyszek:
fedora-review+
|
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2016-02-26 06:57:42 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Mohammed Isam
2015-12-19 16:00:37 UTC
You could use %make_build instead of 'make %{?_smp_flags}' and %make_install instead of 'make install ...'.
Use https in the URL and Source0 links.
License file COPYING is marked as %doc instead of %license
See: http://fedoraproject.org/wiki/Packaging/LicensingGuidelines#License_Text
fontopia.src: W: file-size-mismatch fontopia-1.0.tar.gz = 424272, http://sites.google.com/site/mohammedisam2000/home/projects/fontopia-1.0.tar.gz = 416640
(In reply to Zbigniew Jędrzejewski-Szmek from comment #1) Fixed spec file as above.. Please Check the new version Spec URL: http://sites.google.com/site/mohammedisam2000/home/projects/fontopia.spec SRPM URL: http://sites.google.com/site/mohammedisam2000/home/projects/fontopia-1.0-2.fc23.src.rpm + license is OK (GPLv3+)
+ license file is present, %license is used
+ latest version
+ builds and install OK
+ scriptlets match guidelines
+ standard macros are used
You could %exlude %{_pkgdocdir}/COPYING to avoid duplicated file (and a warning from rpmlint).
Unfortunately you violate one significant guideline: the package uses stuff packaged as %doc at runtime. When installed with --exludedocs, internal help is missing and other things are broken too.
(In reply to Zbigniew Jędrzejewski-Szmek from comment #3) > You could %exlude %{_pkgdocdir}/COPYING to avoid duplicated file (and a > warning from rpmlint). Fixed. > Unfortunately you violate one significant guideline: the package uses stuff > packaged as %doc at runtime. When installed with --exludedocs, internal help > is missing and other things are broken too. Yes, it is a real mess. I moved all the mentioned files into the main executable itself. Yes, it is bigger (much bigger) but at least it is standalone and eliminates this problem. I hope. Spec URL: http://sites.google.com/site/mohammedisam2000/home/projects/fontopia.spec SRPM URL: http://sites.google.com/site/mohammedisam2000/home/projects/fontopia-1.1-1.fc23.src.rpm %{_docdir}/fontopia is actually %{_pkgdocdir}.
%exclude %{_docdir}/COPYING is not going to work, you need %exclude %{_pkgdocdir}/COPYING.
rpmlint:
fontopia.src: W: spelling-error %description -l en_US glyphs -> glyph, glyph s
fontopia.src: W: spelling-error %description -l en_US unsetting -> insetting, unsettling, unseating
fontopia.x86_64: W: spelling-error %description -l en_US glyphs -> glyph, glyph s
fontopia.x86_64: W: spelling-error %description -l en_US unsetting -> insetting, unsettling, unseating
All OK.
Package is APPROVED.
(In reply to Zbigniew Jędrzejewski-Szmek from comment #5) > %{_docdir}/fontopia is actually %{_pkgdocdir}. > %exclude %{_docdir}/COPYING is not going to work, you need %exclude > %{_pkgdocdir}/COPYING. Fixed. > rpmlint: > fontopia.x86_64: W: spelling-error %description -l en_US glyphs -> glyph, > glyph s > fontopia.x86_64: W: spelling-error %description -l en_US unsetting -> > insetting, unsettling, unseating Harmless spelling mistakes I think right. > Package is APPROVED. Great! Spec URL: http://sites.google.com/site/mohammedisam2000/home/projects/fontopia.spec SRPM URL: http://sites.google.com/site/mohammedisam2000/home/projects/fontopia-1.1-2.fc23.src.rpm Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/fontopia fontopia-1.1-2.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2016-ca75e185d5 fontopia-1.1-2.fc22 has been submitted as an update to Fedora 22. https://bodhi.fedoraproject.org/updates/FEDORA-2016-1742894a43 fontopia-1.1-2.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-ca75e185d5 fontopia-1.1-2.fc22 has been pushed to the Fedora 22 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-1742894a43 fontopia-1.1-2.fc23 has been pushed to the Fedora 23 stable repository. If problems still persist, please make note of it in this bug report. fontopia-1.1-2.fc22 has been pushed to the Fedora 22 stable repository. If problems still persist, please make note of it in this bug report. fontopia-1.1-4.el6 has been submitted as an update to Fedora EPEL 6. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-32cedeb2f6 fontopia-1.1-4.el6 has been pushed to the Fedora EPEL 6 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-32cedeb2f6 fontopia-1.1-4.el6 has been pushed to the Fedora EPEL 6 stable repository. If problems still persist, please make note of it in this bug report. |