Bug 1293561
Summary: | Octave has appdata.xml but doesn't show up in Gnome Software | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Colin Macdonald <cbm> | ||||||
Component: | gnome-software | Assignee: | Richard Hughes <rhughes> | ||||||
Status: | CLOSED CURRENTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||||
Severity: | unspecified | Docs Contact: | |||||||
Priority: | unspecified | ||||||||
Version: | 26 | CC: | alex, fkluknav, jaromir.capik, klember, mmahut, orion, rakesh.pandit, rhughes, susi.lehtola | ||||||
Target Milestone: | --- | ||||||||
Target Release: | --- | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Whiteboard: | |||||||||
Fixed In Version: | Doc Type: | Bug Fix | |||||||
Doc Text: | Story Points: | --- | |||||||
Clone Of: | Environment: | ||||||||
Last Closed: | 2018-05-29 12:14:14 UTC | Type: | Bug | ||||||
Regression: | --- | Mount Type: | --- | ||||||
Documentation: | --- | CRM: | |||||||
Verified Versions: | Category: | --- | |||||||
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||
Cloudforms Team: | --- | Target Upstream Version: | |||||||
Embargoed: | |||||||||
Attachments: |
|
Description
Colin Macdonald
2015-12-22 07:01:36 UTC
Sorry I've combined two issues here, should've filed two bugs. To clarify, my patch does not fix this issue, it just improves the spec file. Created attachment 1108677 [details]
0001-validate-appdata.xml-file.patch
So this looks like the key bit:
> (org.gnome.Software:16784): Gs-DEBUG: removing incompatible
> www.octave.org-octave.desktop from project group GNU
If I remove this line from www.octave.org-octave.appdata.xml
<project_group>GNU</project_group>
then "killall gnome-software; gnome-software --verbose" correctly shows Octave.
I'm curious about this. Re-assigning to gnome-software to bring in those folks. While http://people.freedesktop.org/~hughsient/appdata/ doesn't seem to be completely explicit that <project_group> should/must be a desktop environment, gnome-software appears to assume that it is and uses it to exclude "incompatible" software. Richard - what's the intent here? I'm not Richard and don't really know the whole story here, but looking at the code the list of allowed values for <project_group> is taken from https://github.com/hughsie/appstream-glib/blob/master/libappstream-glib/as-environment-ids.txt Thanks! I filed https://github.com/hughsie/appstream-glib/issues/73 for appstream-util to validate against that list. Send fix to upstream Octave: https://savannah.gnu.org/patch/?8842. @Orion, we could probably do this in the octave.spec to fix this... octave-4.0.0-8.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2015-8f6ad2a67a octave-4.0.0-8.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2015-8f6ad2a67a octave-4.0.0-8.fc23 has been pushed to the Fedora 23 stable repository. If problems still persist, please make note of it in this bug report. Richard - can you comment on this? From the description of <project_group>, the octave folk feel that GNU would be an appropriate description for octave. If this tag is to be limited to a specific set of desktop environments, this needs to be made more specific. This message is a reminder that Fedora 23 is nearing its end of life. Approximately 4 (four) weeks from now Fedora will stop maintaining and issuing updates for Fedora 23. It is Fedora's policy to close all bug reports from releases that are no longer maintained. At that time this bug will be closed as EOL if it remains open with a Fedora 'version' of '23'. Package Maintainer: If you wish for this bug to remain open because you plan to fix it in a currently maintained version, simply change the 'version' to a later Fedora version. Thank you for reporting this issue and we are sorry that we were not able to fix it before Fedora 23 is end of life. If you would still like to see this bug fixed and are able to reproduce it against a later version of Fedora, you are encouraged change the 'version' to a later Fedora version prior this bug is closed as described in the policy above. Although we aim to fix as many bugs as possible during every release's lifetime, sometimes those efforts are overtaken by events. Often a more recent Fedora release includes newer upstream software that fixes bugs or makes them obsolete. I looked at why octave isn't still showing up in the appstream metadata and apparently it's now erroring out because the <license> isn't a valid SPDX license: AppData ./tmp/fedora-26/octave-4.2.0-11.fc26/usr/share/appdata/www.octave.org-octave.appdata.xml license 'GPLv3+' invalid https://github.com/hughsie/createrepo_as_logs/blob/master/o/octave.log I've pushed a quick fix to rawhide, let's see if that makes it work tomorrow. I would appreciate if someone who knows how upstream patch submission works could forward this upstream. Thanks! http://pkgs.fedoraproject.org/cgit/rpms/octave.git/commit/?id=d752630df28336be61ccd8e7ac3cd33cd2fb09d1 Filed upstream: https://savannah.gnu.org/bugs/index.php?49952 This bug appears to have been reported against 'rawhide' during the Fedora 26 development cycle. Changing version to '26'. This message is a reminder that Fedora 26 is nearing its end of life. Approximately 4 (four) weeks from now Fedora will stop maintaining and issuing updates for Fedora 26. It is Fedora's policy to close all bug reports from releases that are no longer maintained. At that time this bug will be closed as EOL if it remains open with a Fedora 'version' of '26'. Package Maintainer: If you wish for this bug to remain open because you plan to fix it in a currently maintained version, simply change the 'version' to a later Fedora version. Thank you for reporting this issue and we are sorry that we were not able to fix it before Fedora 26 is end of life. If you would still like to see this bug fixed and are able to reproduce it against a later version of Fedora, you are encouraged change the 'version' to a later Fedora version prior this bug is closed as described in the policy above. Although we aim to fix as many bugs as possible during every release's lifetime, sometimes those efforts are overtaken by events. Often a more recent Fedora release includes newer upstream software that fixes bugs or makes them obsolete. Fedora 26 changed to end-of-life (EOL) status on 2018-05-29. Fedora 26 is no longer maintained, which means that it will not receive any further security or bug fix updates. As a result we are closing this bug. If you can reproduce this bug against a currently maintained version of Fedora please feel free to reopen this bug against that version. If you are unable to reopen this bug, please file a new report against the current release. If you experience problems, please add a comment to this bug. Thank you for reporting this bug and we are sorry it could not be fixed. I think this has all been dealt with upstream. |