Bug 1294359
| Summary: | Review Request: libsmartcols-bindings - Bindings for the util-linux libsmartcols library | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Igor Gnatenko <ignatenko> |
| Component: | Package Review | Assignee: | Lubomir Rintel <lkundrak> |
| Status: | CLOSED WONTFIX | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | lkundrak, package-review |
| Target Milestone: | --- | Flags: | lkundrak:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2016-07-07 09:14:13 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Igor Gnatenko
2015-12-27 16:33:27 UTC
Spec URL: https://ignatenkobrain.fedorapeople.org/for-review/libsmartcols-bindings.spec SRPM URL: https://ignatenkobrain.fedorapeople.org/for-review/libsmartcols-bindings-0.0.2-1.fc24.src.rpm lkundrak's scratch build of libsmartcols-bindings-0.0.2-1.fc23.src.rpm for f24 completed http://koji.fedoraproject.org/koji/taskinfo?taskID=12329771 * Named correctly
* Correclty versioned
* Using latest version
* Upstream sources match
* License tag okay
* License good for Fedora
* Builds fine in mock
* SPEC file clean and legible
APPROVED
A few notes:
0.) Doesn't seem to build for me locally (f23 with updated cmake):
> no theme named 'alabaster' found (missing theme.conf?)
Maybe you may want to depend on python-sphinx-alabaster or whatever provides the theme, since you're explicitly using it? It could be that it's dragged into the koji buildroot by dumb luck.
1.) The perl subpackage should probably provide perl(smartcols) = NVR (since it's not generated automatically as the package doesn't use a pure perl bootstrap wrapper).
> Maybe you may want to depend on python-sphinx-alabaster or whatever provides the theme, since you're explicitly using it? It could be that it's dragged into the koji buildroot by dumb luck. Because I'm running rawhide it is already default theme for sphinx (in upstream alos), so it is explicitly required by sphinx... But for f23 looks like it is not true. > 1.) The perl subpackage should probably provide perl(smartcols) = NVR (since it's not generated automatically as the package doesn't use a pure perl bootstrap wrapper). Will do! Thanks! Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/libsmartcols-bindings |