Bug 1294467

Summary:	Review Request: pidgin-window-merge - plugin for single window mode
Product:	[Fedora] Fedora	Reporter:	Jiri Eischmann <eischmann>
Component:	Package Review	Assignee:	Nobody's working on this, feel free to take it <nobody>
Status:	CLOSED ERRATA	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	jeischma, jgrulich, package-review, ppisar
Target Milestone:	---	Flags:	jgrulich: fedora-review+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:	pidgin-window-merge-0.3-5.fc22	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2020-04-22 14:56:07 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:

Description Jiri Eischmann 2015-12-28 11:06:00 UTC

Spec URL: https://dl.dropboxusercontent.com/u/1309518/pidgin-window-merge.spec
SRPM URL: https://dl.dropboxusercontent.com/u/1309518/pidgin-window-merge-0.3-4.fc23.src.rpm
Description: A plugin that merges contact and conversation windows of Pidgin into one. Since it's pretty difficult to use multi-window apps in GNOME 3, it's quite useful.
Fedora Account System Username: eischmann

Comment 1 Upstream Release Monitoring 2016-01-04 12:35:57 UTC

jgrulich's scratch build of pidgin-window-merge-0.3-4.fc23.src.rpm for f23 failed http://koji.fedoraproject.org/koji/taskinfo?taskID=12401941

Comment 2 Jan Grulich 2016-01-04 12:39:08 UTC

1) Rpmlint says:
pidgin-window-merge.src:15: W: mixed-use-of-spaces-and-tabs (spaces: line 15, tab: line 1)

Also there is unnecessary tab at the end of line 10.

2) In %prep you can just use
%setup -qn %{pname}-%{version} -a 1

Seems to work for me, you just need to adjust installation of that appdata file in %install section. You could also include the appdata file as an xml file without making a tarball from it.

3) Doesn't build → missing "BuildRequires: libappstream-glib"

Comment 3 Upstream Release Monitoring 2016-01-04 12:47:17 UTC

jgrulich's scratch build of pidgin-window-merge-0.3-4.fc23.src.rpm for f23 completed http://koji.fedoraproject.org/koji/taskinfo?taskID=12401948

Comment 4 Jiri Eischmann 2016-01-15 16:27:25 UTC

I've created a new srpm: https://dl.dropboxusercontent.com/u/1309518/pidgin-window-merge-0.3-5.fc23.src.rpm

1) this should be fixed.

2) I changed the metadata file location, now it's directly included in the spec file, makes it easier to distribute until upstream includes it in the tarball.

3) this is fixed.

Comment 5 Jan Grulich 2016-01-17 14:35:00 UTC

Looks good now, approved.

Comment 6 Gwyn Ciesla 2016-01-18 20:00:36 UTC

Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/pidgin-window-merge