Bug 1294704

URLs return 404 Not Found, and setuptools 19.2 is available...

oops, fixed.  19.2 isn't even in Fedora rawhide, but sure...

Spec URL: http://www.cora.nwra.com/~orion/fedora/python3-setuptools.spec
SRPM URL: http://www.cora.nwra.com/~orion/fedora/python3-setuptools-19.2-1.el7.src.rpm

* Tue Dec 29 2015 Orion Poplawski <orion.com> - 19.2-1
- Update to 19.2

Scratch build - https://koji.fedoraproject.org/koji/taskinfo?taskID=12345583

Summary and %description should say "Python 3" because this is Python 3 only.

Summary and %description for the binary package should probably say "Python %{python3_version}" instead of "Python 3".

Group tags should go away.

with_check deserves a comment why it's not on by default. For now I think it's because pytest and mock are not available yet, but still.

%with_check and %build_wheel would be better implemented using the standard %bcond_with/out.

pip3 in %install should probably be made more specific. pip-%{python3_version}?

psfl.txt and zpl.txt should be %license, not %doc.

What is the source for psfl.txt and zpl.txt?

psfl.txt talks about Python 2.1.1. Should it be updated to something newer?

Rest of the docs would be better installed as "%doc docs/*" to avoid one unnecessary dir.

/usr/lib/python3.4/site-packages/setuptools/command/easy_install.py has a wrong shebang, "/usr/bin/env python". I believe /usr/bin/env should not be used in the first place for system installed stuff like this, and "python" should probably be "python%{python3_version}" or "%{__python3}"

(In reply to Ville Skyttä from comment #4)
> Summary and %description should say "Python 3" because this is Python 3 only.
>
> Summary and %description for the binary package should probably say "Python
> %{python3_version}" instead of "Python 3".

The name of the package "python3X-setuptools" will be displayed next to summaries and description and I think makes this point.
 
> Group tags should go away.

Gone.

> with_check deserves a comment why it's not on by default. For now I think
> it's because pytest and mock are not available yet, but still.

Added in a bootstrap flag.

> %with_check and %build_wheel would be better implemented using the standard
> %bcond_with/out.

Perhaps, but I'm going to stick with staying closer to the Fedora setuptools package here.
 
> pip3 in %install should probably be made more specific.
> pip-%{python3_version}?

Looks like probably pip%{python3_version}.

> psfl.txt and zpl.txt should be %license, not %doc.
> 
> What is the source for psfl.txt and zpl.txt?
> 
> psfl.txt talks about Python 2.1.1. Should it be updated to something newer?

I've done so.  And added ASL 2.0 since there appear to be some files under that license.  It's a bit of a mess and there is an upstream issue with no response:

https://bitbucket.org/pypa/setuptools/issues/132/missing-license

> Rest of the docs would be better installed as "%doc docs/*" to avoid one
> unnecessary dir.

Fixed.
 
> /usr/lib/python3.4/site-packages/setuptools/command/easy_install.py has a
> wrong shebang, "/usr/bin/env python". I believe /usr/bin/env should not be
> used in the first place for system installed stuff like this, and "python"
> should probably be "python%{python3_version}" or "%{__python3}"

Removed the unneeded shbang.

Spec URL: http://www.cora.nwra.com/~orion/fedora/python3-setuptools.spec
SRPM URL: http://www.cora.nwra.com/~orion/fedora/python3-setuptools-19.2-2.el7.src.rpm

* Wed Dec 29 2015 Orion Poplawski <orion.com> - 19.2-2
- Drop group tag
- Add bootstrap conditional
- Use specific pip version
- Use %%license
- Update license and license source
- Strip unneeded shbangs

Copr: https://copr.fedoraproject.org/coprs/g/python/python3_epel7/

(In reply to Orion Poplawski from comment #5)
> (In reply to Ville Skyttä from comment #4)
> > Summary and %description should say "Python 3" because this is Python 3 only.
> >
> > Summary and %description for the binary package should probably say "Python
> > %{python3_version}" instead of "Python 3".
> 
> The name of the package "python3X-setuptools" will be displayed next to
> summaries and description

Really, everywhere?

> and I think makes this point.

By that argument you could leave the words python and setuptools out of the summary and description as well. It wouldn't be a good idea to do that either, just like it is not a good idea to knowingly leave inaccurate and possibly misleading versioning information there that would be very easy to fix. I won't block the review because of this, but I suggest you reconsider.

> > Rest of the docs would be better installed as "%doc docs/*" to avoid one
> > unnecessary dir.
>
> Fixed.

Makefile and conf.py in docs don't seem useful, I suggest removing them before the first build.

Accepted.

Okay, I've added the version to summary/description and cleaned up the docs.  Thanks for the review.

Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/python3-setuptools

python3-setuptools-19.2-3.el7 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2015-c515c5de8e

python3-setuptools-19.2-3.el7 has been pushed to the Fedora EPEL 7 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2015-c515c5de8e

Orion, have you managed to get rid of multiple "wrong magic value" rpmlint messages? Or is it a permanent rpmlint issue?
--------------
python34-setuptools.noarch: E: python-bytecode-wrong-magic-value /usr/lib/python3.4/site-packages/_markerlib/__pycache__/__init__.cpython-34.pyc expected 3260 (3.4), found 3310 (unknown)
python34-setuptools.noarch: E: python-bytecode-wrong-magic-value /usr/lib/python3.4/site-packages/setuptools/command/__pycache__/bdist_rpm.cpython-34.pyc expected 3260 (3.4), found 3310 (unknown)
python34-setuptools.noarch: E: python-bytecode-wrong-magic-value /usr/lib/python3.4/site-packages/setuptools/command/__pycache__/build_py.cpython-34.pyc expected 3260 (3.4), found 3310 (unknown)

That's a bug in the el7 rpmlint; it has a wrong value for Python 3.4 bytecode.

Properly fixing it needs to be done in the el7 rpmlint package, but you can try monkey-patching it in rpmlint's configs, for example in ~/.config/rpmlint:

import FilesCheck
FilesCheck._python_magic_values["3.4"] = 3310

(Seems to work, but importing checks in configs is generally discouraged and may have side effects.)

python3-setuptools-19.2-3.el7 has been pushed to the Fedora EPEL 7 stable repository. If problems still persist, please make note of it in this bug report.