Bug 1295249

Summary: Review Request: python-gatspy - General tools for Astronomical Time Series in Python
Product: [Fedora] Fedora Reporter: Christian Dersch <lupinix.fedora>
Component: Package ReviewAssignee: William Moreno <williamjmorenor>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: package-review, williamjmorenor
Target Milestone: ---Flags: williamjmorenor: fedora-review+
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2016-02-12 11:51:38 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 1295237    
Bug Blocks: 1159999    

Description Christian Dersch 2016-01-04 01:40:39 UTC
Spec URL: https://lupinix.fedorapeople.org/review/python-gatspy.spec
SRPM URL: https://lupinix.fedorapeople.org/review/python-gatspy-0.2.1-1.fc23.src.rpm

Description: Gatspy contains efficient, well-documented implementations of several common routines for Astronomical time series analysis, including the Lomb-Scargle periodogram, the Supersmoother method, and others.

Fedora Account System Username: lupinix

Thank you for review in advance!

Comment 1 Christian Dersch 2016-01-17 20:04:38 UTC
Any news on this?

Comment 2 Upstream Release Monitoring 2016-01-18 22:51:59 UTC
williamjmorenor's scratch build of python-gatspy-0.2.1-1.fc23.src.rpm for rawhide failed http://koji.fedoraproject.org/koji/taskinfo?taskID=12597308

Comment 3 William Moreno 2016-01-18 22:56:28 UTC
Sorry for the late feedback but my build is failing in f23 and rawhide.

Comment 4 Upstream Release Monitoring 2016-01-18 23:46:43 UTC
lupinix's scratch build of python-gatspy-0.2.1-2.fc23.src.rpm for rawhide completed http://koji.fedoraproject.org/koji/taskinfo?taskID=12597694

Comment 5 Christian Dersch 2016-01-19 00:11:04 UTC
Spec URL: https://lupinix.fedorapeople.org/review/python-gatspy.spec
SRPM URL: https://lupinix.fedorapeople.org/review/python-gatspy-0.2.1-2.fc23.src.rpm

Koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=12597694

Thank you for performing the review :) I had to disable the tests as they fetch some light curves from the internet, which doesn't work with Koji and is even not allowed for Fedora... https://fedoraproject.org/wiki/Packaging:Guidelines#Build_time_network_access

I think we can go on without tests so far, I filed a ticket upstream: https://github.com/astroML/gatspy/issues/21

Comment 6 Upstream Release Monitoring 2016-01-20 14:39:44 UTC
lupinix's scratch build of python-gatspy-0.2.1-3.fc23.src.rpm for rawhide failed http://koji.fedoraproject.org/koji/taskinfo?taskID=12620387

Comment 7 Upstream Release Monitoring 2016-01-20 14:51:14 UTC
lupinix's scratch build of python-gatspy-0.2.1-3.fc23.src.rpm for rawhide failed http://koji.fedoraproject.org/koji/taskinfo?taskID=12620459

Comment 8 Upstream Release Monitoring 2016-01-20 15:07:09 UTC
lupinix's scratch build of python-gatspy-0.2.1-3.fc23.src.rpm for rawhide failed http://koji.fedoraproject.org/koji/taskinfo?taskID=12620578

Comment 9 Upstream Release Monitoring 2016-01-20 16:01:26 UTC
lupinix's scratch build of python-gatspy-0.2.1-3.fc23.src.rpm for rawhide failed http://koji.fedoraproject.org/koji/taskinfo?taskID=12621044

Comment 10 Upstream Release Monitoring 2016-01-20 16:09:45 UTC
lupinix's scratch build of python-gatspy-0.2.1-3.fc23.src.rpm for rawhide completed http://koji.fedoraproject.org/koji/taskinfo?taskID=12621096

Comment 11 Christian Dersch 2016-01-20 17:01:40 UTC
Spec URL: https://lupinix.fedorapeople.org/review/python-gatspy.spec
SRPM URL: https://lupinix.fedorapeople.org/review/python-gatspy-0.2.1-3.fc23.src.rpm

Created patch which skips tests requiring network accesswhen being offline, submitted upstream (see comment in spec)

Comment 12 Christian Dersch 2016-02-03 00:32:19 UTC
Any news on this?

Comment 13 William Moreno 2016-02-03 17:07:45 UTC
License OK
%license macro OK
License in all subpackages OK
No bundled libs OK
No orphans packages OK
Macros OK
Naming OK
Build in Rawhide OK
Install FAILS
No bundleb egg.info OK

Remove al shebangs in prep to avoid the python3 package requires the python(abi).
Requires
--------
python3-gatspy (rpmlib, GLIBC filtered):
    python(abi)
    python3-astroML
    python3-supersmoother

Source checksums
----------------
http://pypi.python.org/packages/source/g/gatspy/gatspy-0.2.1.tar.gz :
  CHECKSUM(SHA256) this package     : 1bd1ac97b153285ee1a09354f1d3d1d7bb75b3951546aa219cb6e7d82a21ed6b
  CHECKSUM(SHA256) upstream package : 1bd1ac97b153285ee1a09354f1d3d1d7bb75b3951546aa219cb6e7d82a21ed6b

Check the python shebangs an this package will be ready.

Comment 14 Christian Dersch 2016-02-03 17:14:40 UTC
I don't understand the problem with python(abi) (as with astroquery):

Provides: python3-gatspy = 0.2.1-3.fc24
Requires(rpmlib): rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(FileDigests) <= 4.6.0-1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
Requires: python(abi) = 3.5
Recommends: python3-astroML-addons

http://koji.fedoraproject.org/koji/getfile?taskID=12621097&name=build.log&offset=-4000

Comment 15 William Moreno 2016-02-03 17:17:23 UTC
It is true, the dependency is fine.

Package aproved
===============

Comment 16 Christian Dersch 2016-02-03 17:29:55 UTC
Thank you very much :)

Comment 17 Gwyn Ciesla 2016-02-03 17:44:38 UTC
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/python-gatspy

Comment 18 Fedora Update System 2016-02-03 23:10:11 UTC
python-gatspy-0.2.1-3.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2016-6ebe790da3

Comment 19 Fedora Update System 2016-02-03 23:11:02 UTC
python-gatspy-0.2.1-3.fc22 has been submitted as an update to Fedora 22. https://bodhi.fedoraproject.org/updates/FEDORA-2016-f5ae03d868

Comment 20 Fedora Update System 2016-02-05 01:23:08 UTC
python-gatspy-0.2.1-3.fc22 has been pushed to the Fedora 22 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-f5ae03d868

Comment 21 Fedora Update System 2016-02-05 01:24:25 UTC
python-gatspy-0.2.1-3.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-6ebe790da3

Comment 22 Fedora Update System 2016-02-12 11:51:37 UTC
python-gatspy-0.2.1-3.fc23 has been pushed to the Fedora 23 stable repository. If problems still persist, please make note of it in this bug report.

Comment 23 Fedora Update System 2016-02-12 12:19:36 UTC
python-gatspy-0.2.1-3.fc22 has been pushed to the Fedora 22 stable repository. If problems still persist, please make note of it in this bug report.