Bug 1295258 (php-di)

Summary: Review Request: php-di - The dependency injection container for humans
Product: [Fedora] Fedora Reporter: Shawn Iwinski <shawn>
Component: Package ReviewAssignee: Remi Collet <fedora>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: fedora, package-review
Target Milestone: ---Keywords: Reopened
Target Release: ---Flags: fedora: fedora-review+
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2016-01-20 21:56:16 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 1295255, 1295256, 1295257, 1295260    
Bug Blocks: 1295259    
Attachments:
Description Flags
phpci.log
none
review.txt none

Description Shawn Iwinski 2016-01-04 01:58:48 UTC
Spec URL: https://raw.githubusercontent.com/siwinski/rpms/1e8547d8b4f9afaa46143c5beb8de02145a0a50e/php-di/php-di.spec

SRPM URL: https://siwinski.fedorapeople.org/SRPMS/php-di-5.2.0-1.fc23.noarch.rpm

Description:
The dependency injection container for humans.

Autoloader: /usr/share/php/DI/autoload.php


Fedora Account System Username: siwinski

Comment 2 Remi Collet 2016-01-05 15:32:35 UTC
Created attachment 1111894 [details]
phpci.log

phpCompatInfo version 5.0.0 DB built Dec 29 2015 09:34:25 CET static analyze results

Comment 3 Remi Collet 2016-01-05 15:33:07 UTC
Created attachment 1111895 [details]
review.txt

Generated by fedora-review 0.6.0 (3c5c9d7) last change: 2015-05-20
Command line :/usr/bin/fedora-review -b 1295258
Buildroot used: fedora-rawhide-x86_64

Comment 4 Upstream Release Monitoring 2016-01-05 15:34:23 UTC
remi's scratch build of php-di-5.2.0-1.fc23.src.rpm for rawhide completed http://koji.fedoraproject.org/koji/taskinfo?taskID=12420704

Comment 5 Remi Collet 2016-01-05 15:34:43 UTC
[x]: Package is named according to the Package Naming Guidelines.
    Per Guidelines should be php-php-di
    But I agree, php-di is simpler / cleaner

[x]: %check is present and all tests pass.
    OK with PHPUnit 4.8 and 5.1
    OK with PHP 5.6
    KO with PHP 7.0

There was 1 error:

1) DI\Test\IntegrationTest\Definitions\ObjectDefinitionTest::test_object_without_autowiring
DI\Definition\Exception\DefinitionException: Entry "object" cannot be resolved: The parameter "ar_flags" of __construct() has no type defined or guessable. It has a default value, but the default value can't be read through Reflection because it is a PHP internal class.
Full definition:
Object (
    class = ArrayObject
    scope = singleton
    lazy = false
    __construct(
        $array = array (
)
        $ar_flags = #UNDEFINED#
        $iterator_class = #UNDEFINED#
    )
)

Obviously failure with PHP 7 is not a blocker, so only FYI.

Comment 6 Remi Collet 2016-01-05 15:36:48 UTC
=== APPROVED ===

Comment 7 Shawn Iwinski 2016-01-05 17:15:37 UTC
THANKS for the review!

Comment 8 Gwyn Ciesla 2016-01-05 18:15:11 UTC
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/php-di

Comment 9 Fedora Update System 2016-01-07 20:02:38 UTC
php-di-symfony2-bridge-1.1.0-1.fc22 php-di-5.2.0-1.fc22 php-di-invoker-1.2.0-1.fc22 php-mnapoli-phpunit-easymock-0.2.1-1.fc22 php-di-phpdoc-reader-2.0.1-1.fc22 php-container-interop-1.1.0-1.fc22 has been submitted as an update to Fedora 22. https://bodhi.fedoraproject.org/updates/FEDORA-2016-7d61abd66d

Comment 10 Fedora Update System 2016-01-07 20:02:40 UTC
php-di-symfony2-bridge-1.1.0-1.el7 php-di-5.2.0-1.el7 php-di-invoker-1.2.0-1.el7 php-mnapoli-phpunit-easymock-0.2.1-1.el7 php-di-phpdoc-reader-2.0.1-1.el7 php-container-interop-1.1.0-1.el7 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-2cc24c1200

Comment 11 Fedora Update System 2016-01-07 20:03:20 UTC
php-di-symfony2-bridge-1.1.0-1.fc23 php-di-5.2.0-1.fc23 php-di-invoker-1.2.0-1.fc23 php-mnapoli-phpunit-easymock-0.2.1-1.fc23 php-di-phpdoc-reader-2.0.1-1.fc23 php-container-interop-1.1.0-1.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2016-24c3e6b59c

Comment 12 Fedora Update System 2016-01-07 20:03:24 UTC
php-container-interop-1.1.0-1.el6 has been submitted as an update to Fedora EPEL 6. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-63cd5fa5f4

Comment 13 Fedora Update System 2016-01-08 21:23:47 UTC
php-container-interop-1.1.0-1.el7, php-di-5.2.0-1.el7, php-di-invoker-1.2.0-1.el7, php-di-phpdoc-reader-2.0.1-1.el7, php-di-symfony2-bridge-1.1.0-1.el7, php-mnapoli-phpunit-easymock-0.2.1-1.el7 has been pushed to the Fedora EPEL 7 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-2cc24c1200

Comment 14 Fedora Update System 2016-01-09 04:25:19 UTC
php-container-interop-1.1.0-1.fc22, php-di-5.2.0-1.fc22, php-di-invoker-1.2.0-1.fc22, php-di-phpdoc-reader-2.0.1-1.fc22, php-di-symfony2-bridge-1.1.0-1.fc22, php-mnapoli-phpunit-easymock-0.2.1-1.fc22 has been pushed to the Fedora 22 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-7d61abd66d

Comment 15 Fedora Update System 2016-01-09 04:27:44 UTC
php-container-interop-1.1.0-1.fc23, php-di-5.2.0-1.fc23, php-di-invoker-1.2.0-1.fc23, php-di-phpdoc-reader-2.0.1-1.fc23, php-di-symfony2-bridge-1.1.0-1.fc23, php-mnapoli-phpunit-easymock-0.2.1-1.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-24c3e6b59c

Comment 16 Fedora Update System 2016-01-20 21:56:04 UTC
php-container-interop-1.1.0-1.fc23, php-di-5.2.0-1.fc23, php-di-invoker-1.2.0-1.fc23, php-di-phpdoc-reader-2.0.1-1.fc23, php-di-symfony2-bridge-1.1.0-1.fc23, php-mnapoli-phpunit-easymock-0.2.1-1.fc23 has been pushed to the Fedora 23 stable repository. If problems still persist, please make note of it in this bug report.

Comment 17 Fedora Update System 2016-01-21 04:48:50 UTC
php-container-interop-1.1.0-1.fc22, php-di-5.2.0-1.fc22, php-di-invoker-1.2.0-1.fc22, php-di-phpdoc-reader-2.0.1-1.fc22, php-di-symfony2-bridge-1.1.0-1.fc22, php-mnapoli-phpunit-easymock-0.2.1-1.fc22 has been pushed to the Fedora 22 stable repository. If problems still persist, please make note of it in this bug report.

Comment 18 Fedora Update System 2016-01-25 01:30:00 UTC
php-container-interop-1.1.0-1.el7, php-di-5.2.0-1.el7, php-di-invoker-1.2.0-1.el7, php-di-phpdoc-reader-2.0.1-1.el7, php-di-symfony2-bridge-1.1.0-1.el7, php-mnapoli-phpunit-easymock-0.2.1-1.el7 has been pushed to the Fedora EPEL 7 stable repository. If problems still persist, please make note of it in this bug report.