Bug 1295400

Summary:	Advanced search saved filter delete does not confirm.
Product:	Red Hat CloudForms Management Engine	Reporter:	Milan Falešník <mfalesni>
Component:	UI - OPS	Assignee:	Dávid Halász <dhalasz>
Status:	CLOSED ERRATA	QA Contact:	Taras Lehinevych <tlehinev>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	5.5.0	CC:	dajohnso, hkataria, jhardy, jprause, mfeifer, mpovolny, obarenbo
Target Milestone:	GA
Target Release:	5.6.0
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:	ui
Fixed In Version:	5.6.0.0	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:
Clones:	1295526 (view as bug list)		Environment:
Last Closed:	2016-06-29 15:24:50 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	Bug
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1295526

Description Milan Falešník 2016-01-04 11:01:00 UTC

Description of problem:
Advanced search - when you delete a saved filter, it does not ask you for confirmation as it used to do before, deleting the filter on click.

Version-Release number of selected component (if applicable):
5.5.2.0

How reproducible:
always

Steps to Reproduce:
1. Go to the Providers, advanced search, specify some random conditions as a filter and then save it
2. Load the filter.
3. Click Delete.

Actual results:
Filter gets deleted immediately

Expected results:
Deletion is confirmed by a JS dialog.

Additional info:

Comment 2 CFME Bot 2016-01-11 13:51:03 UTC

https://github.com/ManageIQ/manageiq/pull/6123

Comment 3 CFME Bot 2016-01-14 16:31:36 UTC

New commit detected on ManageIQ/manageiq/master:
https://github.com/ManageIQ/manageiq/commit/3ca3c267367342009c8268778d166d5732993aa3

commit 3ca3c267367342009c8268778d166d5732993aa3
Author:     Dávid Halász <dhalasz>
AuthorDate: Tue Jan 12 11:02:57 2016 +0100
Commit:     Dávid Halász <dhalasz>
CommitDate: Thu Jan 14 15:48:50 2016 +0100

    Rewritten `confirm` parameter to `data-confirm-ujs` in adv_search
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1295400

 app/views/layouts/_adv_search_footer.html.haml | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

Comment 4 CFME Bot 2016-01-20 03:42:35 UTC

https://github.com/ManageIQ/manageiq/pull/6191

Comment 5 CFME Bot 2016-01-20 03:42:39 UTC

Detected commit referencing this ticket while ticket status is MODIFIED.

Comment 6 Taras Lehinevych 2016-04-20 12:10:41 UTC

Verified in 5.6.0.1-beta2

Comment 8 errata-xmlrpc 2016-06-29 15:24:50 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2016:1348