Bug 1295418

Summary:	Close button on a work-in-progress dialog does not work
Product:	[Fedora] Fedora	Reporter:	Martin Kolman <mkolman>
Component:	virt-manager	Assignee:	Cole Robinson <crobinso>
Status:	CLOSED UPSTREAM	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	low	Docs Contact:
Priority:	unspecified
Version:	23	CC:	berrange, crobinso, mkolman, virt-maint
Target Milestone:	---
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2016-03-17 14:32:19 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Martin Kolman 2016-01-04 12:37:55 UTC

Description of problem:
The "x" close button in the upper left corner of a work in progress dialog can be clicked but does nothing.


Version-Release number of selected component (if applicable):
1.3.2-1

How reproducible:
always

Steps to Reproduce:
1. select a snapshot
2. delete it
3. on the "deleting snapshot" dialog try to click the close button

The same is most probably true for other long running actions, like creating a new snapshot.

Actual results:
Nothing happens.

Expected results:
The close button should probably not be shown if the work-in-progress dialog can't be closed.

But it stays there, something should happen if it is clicked - the operation should be either canceled/reverted or something like a "Do you really want to cancel this ?" dialog should show up.

Comment 1 Cole Robinson 2016-01-10 23:05:14 UTC

Thanks for the report. Only some operations are cancellable, so for the non-cancellable ones I've just hidden the X button

commit 9747cd5473a2036d19fd6da89ebf7c0b723c4f57
Author: Cole Robinson <crobinso>
Date:   Sun Jan 10 18:03:49 2016 -0500

    asyncjob: Only show X button if dialog is cancellable (bz 1295418)

Comment 2 Cole Robinson 2016-03-17 14:32:19 UTC

Just closing this as upstream, it will be pulled in whenever there's a new release. Not that important to backport