Bug 1295456
| Summary: | Review Request: python-urwidtrees - Tree Widget Container API for the urwid toolkit | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Tomas Tomecek <ttomecek> |
| Component: | Package Review | Assignee: | William Moreno <williamjmorenor> |
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | package-review, williamjmorenor |
| Target Milestone: | --- | Flags: | williamjmorenor:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2016-03-29 06:19:31 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 1293503 | ||
|
Description
Tomas Tomecek
2016-01-04 14:52:28 UTC
Any update? williamjmorenor's scratch build of python-urwidtrees-1.0.1.1-1.fc24.src.rpm for rawhide failed http://koji.fedoraproject.org/koji/taskinfo?taskID=12597310 Sorry for the late feedback but my build is failing in f23 and rawhide. ttomecek's scratch build of python-urwidtrees-1.0.1-1.fc22.src.rpm for rawhide failed http://koji.fedoraproject.org/koji/taskinfo?taskID=12647780 ttomecek's scratch build of python-urwidtrees-1.0.1-1.fc22.src.rpm for rawhide failed http://koji.fedoraproject.org/koji/taskinfo?taskID=12647826 ttomecek's scratch build of python-urwidtrees-1.0.1-1.fc22.src.rpm for rawhide completed http://koji.fedoraproject.org/koji/taskinfo?taskID=12647868 Oh, it was working for me locally but I haven't tried koji, my bad, sorry about that. Here's a successful koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=12647868 I have also updated spec and srpm at fp: https://ttomecek.fedorapeople.org/urwidtrees/python-urwidtrees.spec https://ttomecek.fedorapeople.org/urwidtrees/python-urwidtrees-1.0.1-1.fc22.src.rpm The package named according to the Package Naming Guidelines OK
The spec file name must match the base package %{name} OK
The package must be licensed with a Fedora approved license OK
The License field match the actual license OK
The spec file must be written in American English OK
The spec file for the package MUST be legible OK
The package build in rawhide OK
BuildRequires OK
No bundled libraries OK
Directories ownership OK
Permissions on files OK
Consistently use macros OK
Source is code nor binary OK
Need work:
The text of the license must be included in %license.
See: https://fedoraproject.org/wiki/Packaging:LicensingGuidelines?rd=Packaging/LicensingGuidelines#License_Text
Large documentation files must go in a -doc subpackage. There is a sphinx doc than you can build and include as subpackage.
(In reply to William Moreno from comment #8) > Need work: > The text of the license must be included in %license. > See: > https://fedoraproject.org/wiki/Packaging:LicensingGuidelines?rd=Packaging/ > LicensingGuidelines#License_Text Upstream doesn't include it. Tried to ask for a release with license: https://github.com/pazz/urwidtrees/issues/23#issuecomment-168948700 > Large documentation files must go in a -doc subpackage. There is a sphinx > doc than you can build and include as subpackage. good point, will do There is a text with the license upstream: https://github.com/pazz/urwidtrees/blob/master/LICENSE.md You can patch it and include it in the rpm. ttomecek's scratch build of python-urwidtrees-1.0.0-1.gitfbcb183.fc22.src.rpm for rawhide failed http://koji.fedoraproject.org/koji/taskinfo?taskID=13090507 ttomecek's scratch build of python-urwidtrees-1.0.0-1.gitfbcb183.fc22.src.rpm for rawhide completed http://koji.fedoraproject.org/koji/taskinfo?taskID=13090685 Updated koji task: http://koji.fedoraproject.org/koji/taskinfo?taskID=13090686 spec: https://ttomecek.fedorapeople.org/urwidtrees/python-urwidtrees.spec srpm: https://ttomecek.fedorapeople.org/urwidtrees/python-urwidtrees-1.0-1.gitfbcb183.fc22.src.rpm Added %license to every subpackage. Added python-urwidtrees-doc subpackage with documentation. Synced version with upstream. Package Aproved =============== William, thanks a lot for the review. Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/python-urwidtrees This bug was accidentally moved from POST to MODIFIED via an error in automation, please see mmccune with any questions |