Bug 1295478
Summary: | Review Request: python-astroquery - Access astronomical online data resources | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Christian Dersch <lupinix.fedora> |
Component: | Package Review | Assignee: | William Moreno <williamjmorenor> |
Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | package-review, williamjmorenor |
Target Milestone: | --- | Flags: | williamjmorenor:
fedora-review+
|
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2016-02-12 11:51:33 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | |||
Bug Blocks: | 1159999 |
Description
Christian Dersch
2016-01-04 15:59:43 UTC
lupinix's scratch build of python-astroquery-0.3.0-1.fc23.src.rpm for rawhide completed http://koji.fedoraproject.org/koji/taskinfo?taskID=12403909 Any news on this? :) Spec URL: https://lupinix.fedorapeople.org/review/python-astroquery.spec SRPM URL: https://lupinix.fedorapeople.org/review/python-astroquery-0.3.1-1.fc23.src.rpm Koji rawhide build: http://koji.fedoraproject.org/koji/taskinfo?taskID=12638424 New upstream release 0.3.1 lupinix's scratch build of python-astroquery-0.3.1-1.fc23.src.rpm for rawhide completed http://koji.fedoraproject.org/koji/taskinfo?taskID=12638424 Package Review ============== [-]: %check is present and all tests pass. Looks like you can test this app with nosetest there are many test directories with test_ files. There is a docs directoy with sphinx documentation than you can build with sphinx and include in a docs subpackage. Also rpmlint is unhappy with many non executales files. ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. [x]: License file installed when any subpackage combination is installed. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [x]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [x]: Python eggs must not download any dependencies during the build process. [x]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: Packages should try to preserve timestamps of original installed files. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: python2-astroquery-0.3.0-1.fc24.noarch.rpm python3-astroquery-0.3.0-1.fc24.noarch.rpm python-astroquery-0.3.0-1.fc24.src.rpm python2-astroquery.noarch: E: explicit-lib-dependency python-html5lib python2-astroquery.noarch: W: spelling-error %description -l en_US astropy -> stroppy python2-astroquery.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/astroquery/alma/tests/data/downloadRequest787632764script.sh 644 /bin/bash python2-astroquery.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/astroquery/alma/tests/data/downloadRequest786572566script.sh 644 /bin/bash python2-astroquery.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/astroquery/alma/tests/data/downloadRequest786978956script.sh 644 /bin/bash python2-astroquery.noarch: E: zero-length /usr/lib/python2.7/site-packages/astroquery/alma/tests/data/empty.html python2-astroquery.noarch: E: zero-length /usr/lib/python2.7/site-packages/astroquery/cosmosim/tests/test_cosmosim.py python2-astroquery.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/astroquery/alma/tests/data/downloadRequest519752156script.sh 644 /bin/bash python3-astroquery.noarch: E: explicit-lib-dependency python3-html5lib python3-astroquery.noarch: W: spelling-error %description -l en_US astropy -> stroppy python3-astroquery.noarch: E: non-executable-script /usr/lib/python3.5/site-packages/astroquery/alma/tests/data/downloadRequest787632764script.sh 644 /bin/bash python3-astroquery.noarch: E: zero-length /usr/lib/python3.5/site-packages/astroquery/cosmosim/tests/test_cosmosim.py python3-astroquery.noarch: E: non-executable-script /usr/lib/python3.5/site-packages/astroquery/alma/tests/data/downloadRequest519752156script.sh 644 /bin/bash python3-astroquery.noarch: E: non-executable-script /usr/lib/python3.5/site-packages/astroquery/alma/tests/data/downloadRequest786978956script.sh 644 /bin/bash python3-astroquery.noarch: E: zero-length /usr/lib/python3.5/site-packages/astroquery/alma/tests/data/empty.html python3-astroquery.noarch: E: non-executable-script /usr/lib/python3.5/site-packages/astroquery/alma/tests/data/downloadRequest786572566script.sh 644 /bin/bash python-astroquery.src: W: spelling-error %description -l en_US astropy -> stroppy 3 packages and 0 specfiles checked; 14 errors, 3 warnings. Rpmlint (installed packages) ---------------------------- python2-astroquery.noarch: E: explicit-lib-dependency python-html5lib python2-astroquery.noarch: W: spelling-error %description -l en_US astropy -> stroppy python2-astroquery.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/astroquery/alma/tests/data/downloadRequest786978956script.sh 644 /bin/bash python2-astroquery.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/astroquery/alma/tests/data/downloadRequest787632764script.sh 644 /bin/bash python2-astroquery.noarch: E: zero-length /usr/lib/python2.7/site-packages/astroquery/alma/tests/data/empty.html python2-astroquery.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/astroquery/alma/tests/data/downloadRequest519752156script.sh 644 /bin/bash python2-astroquery.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/astroquery/alma/tests/data/downloadRequest786572566script.sh 644 /bin/bash python2-astroquery.noarch: E: zero-length /usr/lib/python2.7/site-packages/astroquery/cosmosim/tests/test_cosmosim.py python3-astroquery.noarch: E: explicit-lib-dependency python3-html5lib python3-astroquery.noarch: W: spelling-error %description -l en_US astropy -> stroppy python3-astroquery.noarch: E: non-executable-script /usr/lib/python3.5/site-packages/astroquery/alma/tests/data/downloadRequest786572566script.sh 644 /bin/bash python3-astroquery.noarch: E: non-executable-script /usr/lib/python3.5/site-packages/astroquery/alma/tests/data/downloadRequest787632764script.sh 644 /bin/bash python3-astroquery.noarch: E: zero-length /usr/lib/python3.5/site-packages/astroquery/cosmosim/tests/test_cosmosim.py python3-astroquery.noarch: E: zero-length /usr/lib/python3.5/site-packages/astroquery/alma/tests/data/empty.html python3-astroquery.noarch: E: non-executable-script /usr/lib/python3.5/site-packages/astroquery/alma/tests/data/downloadRequest519752156script.sh 644 /bin/bash python3-astroquery.noarch: E: non-executable-script /usr/lib/python3.5/site-packages/astroquery/alma/tests/data/downloadRequest786978956script.sh 644 /bin/bash 2 packages and 0 specfiles checked; 14 errors, 2 warnings. Requires -------- python2-astroquery (rpmlib, GLIBC filtered): python(abi) python-astropy python-beautifulsoup4 python-html5lib python-keyring python-requests python3-astroquery (rpmlib, GLIBC filtered): python(abi) python3-astropy python3-beautifulsoup4 python3-html5lib python3-keyring python3-requests Provides -------- python2-astroquery: python-astroquery python2-astroquery python3-astroquery: python3-astroquery Source checksums ---------------- http://pypi.python.org/packages/source/a/astroquery/astroquery-0.3.0.tar.gz : CHECKSUM(SHA256) this package : 4a09a26817ff164c860609d7b5aac11297d13b6cf6abdfe79660a598f54912b5 CHECKSUM(SHA256) upstream package : 4a09a26817ff164c860609d7b5aac11297d13b6cf6abdfe79660a598f54912b5 lupinix's scratch build of python-astroquery-0.3.1-2.fc23.src.rpm for rawhide failed http://koji.fedoraproject.org/koji/taskinfo?taskID=12640496 lupinix's scratch build of python-astroquery-0.3.1-2.fc23.src.rpm for f23 completed http://koji.fedoraproject.org/koji/taskinfo?taskID=12640777 Spec URL: https://lupinix.fedorapeople.org/review/python-astroquery.spec SRPM URL: https://lupinix.fedorapeople.org/review/python-astroquery-0.3.1-2.fc23.src.rpm Koji raehide: http://koji.fedoraproject.org/koji/taskinfo?taskID=12640871 Docs generation works with F23, but not Rawhide. Looks like astropy changed from 1.0.x to 1.1.x release => Disabled in spec, will be enabled when working again. I don't think this is a review blocker, astroquery doesn't work at all without internet conection. And with internet connection one can browse online docs too. Builds with enabled doc: Koji rawhide: http://koji.fedoraproject.org/koji/taskinfo?taskID=12640496 Koji F23: http://koji.fedoraproject.org/koji/taskinfo?taskID=12640777 Running the provided tests via nosetests doesn't make any sense. astroquery is made to query astronomical online services, so the tests do exactly that. But downloading stuff for buildtime, even for tests, is forbidden (and disabled in Koji) in our guidelines: https://fedoraproject.org/wiki/Packaging:Guidelines#Build_time_network_access Thank you for reviewing :) Any news on this? williamjmorenor's scratch build of python-astroquery-0.3.1-2.fc23.src.rpm for rawhide failed http://koji.fedoraproject.org/koji/taskinfo?taskID=12803970 williamjmorenor's scratch build of python-astroquery-0.3.1-2.fc23.src.rpm for f23 completed http://koji.fedoraproject.org/koji/taskinfo?taskID=12804154 License is OK License include with %license macro Not bundled libraries Not orphans directories Macros are fine Package build fine, you should disable docs generations in rawhide temporally. There is a rpmlit issue with zero length files than you must exclude in files or sed a comment in prep. python2-astroquery.noarch: E: zero-length /usr/lib/python2.7/site-packages/astroquery/cosmosim/tests/test_cosmosim.py python2-astroquery.noarch: E: zero-length /usr/lib/python2.7/site-packages/astroquery/alma/tests/data/empty.html python3-astroquery.noarch: E: zero-length /usr/lib/python3.4/site-packages/astroquery/alma/tests/data/empty.html python3-astroquery.noarch: E: zero-length /usr/lib/python3.4/site-packages/astroquery/cosmosim/tests/test_cosmosim.py The python3 package requires the python(abi) remove all shebangs in prep to avoid the python3 subpackage requires both python3 and python3 python3-astroquery (rpmlib, GLIBC filtered): /bin/bash python(abi) python3-astropy python3-beautifulsoup4 python3-html5lib python3-keyring python3-requests Source checksums ---------------- http://pypi.python.org/packages/source/a/astroquery/astroquery-0.3.1.tar.gz : CHECKSUM(SHA256) this package : ad67bf4f31bc9e0c45621a19f7200d701ff7b5df2d78e9ba7095e65a2f69c50d CHECKSUM(SHA256) upstream package : ad67bf4f31bc9e0c45621a19f7200d701ff7b5df2d78e9ba7095e65a2f69c50d Fix those issues and the package will be ready. What is the problem with python(abi)? From build.log: Provides: python3-astroquery = 0.3.1-2.fc24 Requires(rpmlib): rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(FileDigests) <= 4.6.0-1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 Requires: /bin/bash python(abi) = 3.5 So for python3 package wehabe a dep on python 3.5 abi as expected. https://kojipkgs.fedoraproject.org//work/tasks/872/12640872/build.log close to end of file That is true! the abi is unversioned. Just check the zero-length files to aprove the package. lupinix's scratch build of python-astroquery-0.3.1-3.fc23.src.rpm for rawhide failed http://koji.fedoraproject.org/koji/taskinfo?taskID=12808851 Spec URL: https://lupinix.fedorapeople.org/review/python-astroquery.spec SRPM URL: https://lupinix.fedorapeople.org/review/python-astroquery-0.3.1-3.fc23.src.rpm Koji rawhide: http://koji.fedoraproject.org/koji/taskinfo?taskID=12809152 lupinix's scratch build of python-astroquery-0.3.1-3.fc23.src.rpm for rawhide completed http://koji.fedoraproject.org/koji/taskinfo?taskID=12809152 Package Aproved =============== Maybe you can help with the review of #1304522 Thank you very much :) I'll have a look at your review request. Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/python-astroquery python-astroquery-0.3.1-3.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2016-9c8cac3e4d python-astroquery-0.3.1-3.fc22 has been submitted as an update to Fedora 22. https://bodhi.fedoraproject.org/updates/FEDORA-2016-5ffcbd08ef python-astroquery-0.3.1-3.fc22 has been pushed to the Fedora 22 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-5ffcbd08ef python-astroquery-0.3.1-3.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-9c8cac3e4d python-astroquery-0.3.1-3.fc23 has been pushed to the Fedora 23 stable repository. If problems still persist, please make note of it in this bug report. python-astroquery-0.3.1-3.fc22 has been pushed to the Fedora 22 stable repository. If problems still persist, please make note of it in this bug report. |