Bug 1296043

Summary:	Wrong usage of dict functions
Product:	[Community] GlusterFS	Reporter:	Pranith Kumar K <pkarampu>
Component:	core	Assignee:	Pranith Kumar K <pkarampu>
Status:	CLOSED CURRENTRELEASE	QA Contact:
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	mainline	CC:	bugs
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	glusterfs-3.9.0	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2017-03-27 18:15:34 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Pranith Kumar K 2016-01-06 09:36:24 UTC

Description of problem:
It seems like two ways to create dictionary is causing problems. There are quite a few dict_new()/dict_destroy() or get_new_dict()/dict_unref() in the code base. So we should stop exposing the functions without ref/unref i.e. get_new_dict()/dict_destroy().

Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

Comment 1 Vijay Bellur 2016-01-06 09:37:37 UTC

REVIEW: http://review.gluster.org/13183 (dict: Don't expose get_new_dict/dict_destroy) posted (#1) for review on master by Pranith Kumar Karampuri (pkarampu)

Comment 2 Vijay Bellur 2016-03-01 10:06:03 UTC

REVIEW: http://review.gluster.org/13183 (dict: Don't expose get_new_dict/dict_destroy) posted (#2) for review on master by Pranith Kumar Karampuri (pkarampu)

Comment 3 Mike McCune 2016-03-28 23:18:47 UTC

This bug was accidentally moved from POST to MODIFIED via an error in automation, please see mmccune with any questions

Comment 4 Vijay Bellur 2016-06-24 11:43:48 UTC

REVIEW: http://review.gluster.org/13183 (dict: Don't expose get_new_dict/dict_destroy) posted (#3) for review on master by Pranith Kumar Karampuri (pkarampu)

Comment 5 Vijay Bellur 2016-06-29 07:10:57 UTC

REVIEW: http://review.gluster.org/13183 (dict: Don't expose get_new_dict/dict_destroy) posted (#4) for review on master by Pranith Kumar Karampuri (pkarampu)

Comment 6 Vijay Bellur 2016-07-18 09:29:14 UTC

REVIEW: http://review.gluster.org/13183 (dict: Don't expose get_new_dict/dict_destroy) posted (#5) for review on master by Pranith Kumar Karampuri (pkarampu)

Comment 7 Vijay Bellur 2016-07-19 03:24:22 UTC

REVIEW: http://review.gluster.org/13183 (dict: Don't expose get_new_dict/dict_destroy) posted (#6) for review on master by Pranith Kumar Karampuri (pkarampu)

Comment 8 Vijay Bellur 2016-07-22 02:13:59 UTC

REVIEW: http://review.gluster.org/13183 (dict: Don't expose get_new_dict/dict_destroy) posted (#7) for review on master by Pranith Kumar Karampuri (pkarampu)

Comment 9 Vijay Bellur 2016-07-26 06:47:36 UTC

COMMIT: http://review.gluster.org/13183 committed in master by Pranith Kumar Karampuri (pkarampu) 
------
commit d2bd17e5a53d0ffa375df1a5ad957556be2f2b83
Author: Pranith Kumar K <pkarampu>
Date:   Wed Jan 6 14:30:08 2016 +0530

    dict: Don't expose get_new_dict/dict_destroy
    
    get_new_dict/dict_destroy is causing confusion where, dict_new/dict_destroy or
    get_new_dict/dict_unref are used instead of dict_new/dict_unref.
    
    Change-Id: I4cc69f5b6711d720823395e20fd624a0c6c1168c
    BUG: 1296043
    Signed-off-by: Pranith Kumar K <pkarampu>
    Reviewed-on: http://review.gluster.org/13183
    Smoke: Gluster Build System <jenkins.org>
    CentOS-regression: Gluster Build System <jenkins.org>
    NetBSD-regression: NetBSD Build System <jenkins.org>
    Reviewed-by: Jeff Darcy <jdarcy>
    Reviewed-by: Krutika Dhananjay <kdhananj>

Comment 10 Shyamsundar 2017-03-27 18:15:34 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.9.0, please open a new bug report.

glusterfs-3.9.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://lists.gluster.org/pipermail/gluster-users/2016-November/029281.html
[2] https://www.gluster.org/pipermail/gluster-users/