Bug 1296206

Summary: Geo-Replication Session goes "FAULTY" when application logs rolled on master
Product: [Community] GlusterFS Reporter: Milind Changire <mchangir>
Component: geo-replicationAssignee: Milind Changire <mchangir>
Status: CLOSED CURRENTRELEASE QA Contact:
Severity: high Docs Contact:
Priority: high    
Version: mainlineCC: avishwan, bugs, byarlaga, chrisw, csaba, hamiller, hostingnuggets, nlevinki, sankarshan, storage-qa-internal
Target Milestone: ---Keywords: ZStream
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: glusterfs-3.8rc2 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: 1264986 Environment:
Last Closed: 2016-06-16 13:53:44 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 1264986, 1296208    
Bug Blocks:    

Comment 1 Vijay Bellur 2016-01-06 16:03:10 UTC
REVIEW: http://review.gluster.org/13186 (geo-rep: avoid creating multiple entries with same gfid) posted (#2) for review on master by Milind Changire (mchangir)

Comment 2 Vijay Bellur 2016-01-06 17:22:16 UTC
REVIEW: http://review.gluster.org/13186 (geo-rep: avoid creating multiple entries with same gfid) posted (#3) for review on master by Milind Changire (mchangir)

Comment 3 Vijay Bellur 2016-01-07 06:29:45 UTC
REVIEW: http://review.gluster.org/13186 (geo-rep: avoid creating multiple entries with same gfid) posted (#4) for review on master by Milind Changire (mchangir)

Comment 4 Milind Changire 2016-01-08 06:53:23 UTC
Public comments:
The issue manifest when nightly logs are rolled over by customer application using log4j.

Investigation revealed that there is an issue with CREATE + RENAME log replay from geo-rep.

Patch http://review.gluster.org/13186 is available to resolve the issue.

Comment 5 Vijay Bellur 2016-01-29 08:28:25 UTC
REVIEW: http://review.gluster.org/13316 (georep: avoid creating multiple entries with same gfid) posted (#1) for review on master by Milind Changire (mchangir)

Comment 6 Vijay Bellur 2016-03-01 07:58:10 UTC
COMMIT: http://review.gluster.org/13316 committed in master by Jeff Darcy (jdarcy) 
------
commit 87d93fac9fcc4b258b7eb432ac4151cdd043534f
Author: Milind Changire <mchangir>
Date:   Fri Jan 29 13:53:07 2016 +0530

    georep: avoid creating multiple entries with same gfid
    
    Problem:
    CREATE + RENAME changelogs replayed by geo-replication cause
    stale old-name entries with same gfid on slave nodes.
    A gfid is a unique key in the file-system and should not be
    assigned to multiple entries.
    
    Solution:
    Create entry on slave only if lstat(gfid) at aux-mount fails.
    This applies to files as well as directories.
    
    Change-Id: Ice3340f4ae1251c2dcef024a2388c4d33b5d4919
    BUG: 1296206
    Signed-off-by: Milind Changire <mchangir>
    Reviewed-on: http://review.gluster.org/13316
    Smoke: Gluster Build System <jenkins.com>
    Reviewed-by: Kotresh HR <khiremat>
    Reviewed-by: Aravinda VK <avishwan>
    NetBSD-regression: NetBSD Build System <jenkins.org>
    CentOS-regression: Gluster Build System <jenkins.com>

Comment 7 Mike McCune 2016-03-28 23:03:07 UTC
This bug was accidentally moved from POST to MODIFIED via an error in automation, please see mmccune with any questions

Comment 8 Niels de Vos 2016-06-16 13:53:44 UTC
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.8.0, please open a new bug report.

glusterfs-3.8.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://blog.gluster.org/2016/06/glusterfs-3-8-released/
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user