Bug 1296294

Description of problem:

Attempting to deploy an Overcloud that includes subscription-maanger registration of nodes uses multiple subscriptions if the key being used contains them.

This occurs because NodeExtraConfig provides no means of separating out Compute and Control nodes, and the registration guidelines in the OSP7 documentation only reflect the use of that.

Is NodeExtraConfigComputePre/NodeExtraConfigControlPre the right place for this?

Version-Release number of selected component (if applicable):

OSP7

How reproducible:

Always

Steps to Reproduce:
1. Configure a key with multiple subscription entitlements
2. Deploy an Overcloud with Compute and Control nodes that require *different* entitlements

Actual results:

Nodes register correctly but take up two subscriptions entitlement

Expected results:

Node should only take up one entitlement

Additional info:

Following the documentation here: https://access.redhat.com/documentation/en-US/Red_Hat_Enterprise_Linux_OpenStack_Platform/7/html/Director_Installation_and_Usage/sect-Advanced-Scenario_3_Using_the_CLI_to_Create_an_Advanced_Overcloud_with_Ceph_Nodes.html#sect-Advanced-Registering_the_Overcloud

... specifically, section 6.3.7. There's no (documented) way to specify different registration details for Controller and Compute nodes.

Situation - customer has 24x Compute nodes and 3x Controller nodes. They have 'OSP with Smart Management, standard' licenses for the Compute nodes, and 'OSP (without Guest OS) with Smart Management, standard' for the Controller nodes.