Bug 1296667

Summary: RFE: Please update to 0.5.1 and build the new lirc-drv-irman package
Product: [Fedora] Fedora Reporter: Alec Leamas <leamas.alec>
Component: libirmanAssignee: Jan ONDREJ <ondrejj>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 23CC: ondrejj
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: libirman-0.5.2-3.fc24 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2016-06-18 18:46:52 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Attachments:
Description Flags
Provisionary patch
none
New, bugfix patch none

Description Alec Leamas 2016-01-07 19:25:26 UTC
Created attachment 1112577 [details]
Provisionary patch

Description of problem:

We need to coordinate the lirc 0.9.4 release with a libirman update to 0.5.1. This is because the dependencies will change:
 - Prior to lirc 0.9.4  lirc depended on libirman. The lirc irman support was built by lirc and linked to the libirman library.
- With lirc 0.9.4 it's the other way around: libirman builds the lirc-drv-irman package, which is the plugin which enables irman support in lirc. This means that libirman depends on lirc, whereas lirc doesn't depend in libirman.

From a user perspective this means that when lirc 0.9.4 is released the irman support will be dropped. The resurrection happens when the new libirman 0.5.1 arrives. So, this requires some coordination.

There is no hurry, lirc 0.9.4 isn't released yet (probably weeks away). But I thought we should start talking about this.

Enclosing a patch. It builds the driver, and also does some other changes you might like or not, dunno. There is a build in https://copr.fedoraproject.org/coprs/leamas/lirc-0.9.4-preview/

Looking forward to hear from you

Comment 1 Jan ONDREJ 2016-01-08 06:29:56 UTC
Thank you for patch. I applied it to my fedora package git.
I can make a rebuild after release of libirman-0.5.1.
I can grant you access to libirman package in Fedora/EPEL, if you wish to maintain this change.

Comment 2 Alec Leamas 2016-01-08 12:00:06 UTC
(In reply to Jan ONDREJ from comment #1)
> Thank you for patch. I applied it to my fedora package git.

OK, great!

> I can make a rebuild after release of libirman-0.5.1.

libirman 0.5.1 is already out, but we have to wait for lirc 0.9.4 which now is a dependency. I'll be back when it hits updates-testing.

> I can grant you access to libirman package in Fedora/EPEL, if you wish to
> maintain this change.

As long as we keep in touch I actually prefer that you do this so we get more eyes on the code. 

While we are on it: I noticed the 'rm -rf $RPM_BUILD_ROOT' which you might want to remove - it's added automatically since long.

Comment 3 Alec Leamas 2016-01-11 15:55:30 UTC
Created attachment 1113629 [details]
New, bugfix patch

Sigh... Another patch is required, upstream last-minute lirc changes. This is on top of previous patch; if you havn't pushed you might want to squash them.

Comment 4 Jan ONDREJ 2016-01-11 17:25:46 UTC
OK, applied.

Comment 5 Alec Leamas 2016-06-02 14:27:55 UTC
*** Bug 1340271 has been marked as a duplicate of this bug. ***

Comment 6 Alec Leamas 2016-06-02 14:40:11 UTC
Sorry, the 0.9.4 release was delayed for a really long time for various reasons.  Actually , the time was long enough for me to forget my own bug. 

Anyway, there are patches available in bug #1340271. However, we need to cooperate so I can create  lirc-0-9.4 buildroots. I'm ready to do this when you are.

Comment 7 Jan ONDREJ 2016-06-02 15:42:21 UTC
OK, I think I applied all these patches in my git. Please, can you check Fedora git (master branch), if everything is OK?

If yes, can you please request lirc buildroot overrides?

If it will be ready, I can rebuild required packages.

Comment 8 Alec Leamas 2016-06-02 16:10:52 UTC
I cannot see the patches in master (did you push?). The patches updates to version 1:0.5.2 ?!

I have requested buildroots for  lirc-0.9.4-2.fc23 and lirc-0.9.4-3.fc24. They might need some time until available, use  "koji wait-repo f24-build --build=lirc-0.9.4-3.fc24" etc. to make sure they exists

Comment 9 Jan ONDREJ 2016-06-02 17:42:11 UTC
(In reply to Alec Leamas from comment #8)
> I cannot see the patches in master (did you push?).

Yes.

> The patches updates to version 1:0.5.2 ?!

Updated from 0.5.1 to 0.5.2 (without epoch, not needed) now.

> I have requested buildroots for  lirc-0.9.4-2.fc23 and lirc-0.9.4-3.fc24.
> They might need some time until available, use  "koji wait-repo f24-build
> --build=lirc-0.9.4-3.fc24" etc. to make sure they exists

Master branch built.
Building f24 branch.
http://koji.fedoraproject.org/koji/taskinfo?taskID=14355550

Do you request update of libirman with lirc or should I request it?

Comment 10 Alec Leamas 2016-06-02 17:50:00 UTC
Hm... I think we need the epoch. The prob lem is the package lirc-drv-irman. As of lirc-0.9.3 it was part of lirc, and thus we have lirc-drv-irman-0.9.3. Now, the same plugin package is built by libirman as libirman-0.5.2 which gives us lirc-drv-irman-0.5.2 which si supposed to update lirc-drv-irman-0.9.3. 

Obviously, this is a problem. Can it be handled without an epoch?

Comment 11 Alec Leamas 2016-06-02 18:06:59 UTC
And, dammit, here is a bug if you revert to using the epoch. In the -devel package:

Requires:       %{name} = %{version}-%{release}

should be

Requires:       %{name} = %{epoch}:%{version}-%{release}

Comment 12 Alec Leamas 2016-06-02 18:17:04 UTC
Nothing I'm aware of, what that now means "blushes" . Please build master and ans also in the buildroot-overrides.

Comment 13 Fedora Update System 2016-06-02 19:22:40 UTC
libirman-0.5.2-3.fc24 lirc-0.9.4-3.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2016-b57ca4dc1d

Comment 14 Fedora Update System 2016-06-03 09:25:40 UTC
libirman-0.5.2-3.fc24, lirc-0.9.4-3.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-b57ca4dc1d

Comment 15 Fedora Update System 2016-06-18 18:46:51 UTC
libirman-0.5.2-3.fc24, lirc-0.9.4-3.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report.