Bug 129704

From Bugzilla Helper:
User-Agent: Mozilla/5.0 (X11; U; Linux i586; en-US; rv:1.7)
Gecko/20040615 Firefox/0.9

Description of problem:
When trying to run rpm while another process is running an rpm
transaction, the error messages are:

  error: cannot get shared lock on /var/lib/rpm/Packages
  error: cannot open Packages index using db3 - Operation not
permitted (1)
  error: cannot open Packages database in /var/lib/rpm

In this message, the last part of the middle line is the result of
calling strerror(rc), where rc has been set to 1 rather than to errno,
independently of the nature of the failure.

This error message is misleading aas to the cause of the failure.

Version-Release number of selected component (if applicable):
rpm-4.3.1-0.3

How reproducible:
Always

Steps to Reproduce:
1. Due to the timing constraints, I suggest you compile the following
   C program with "gcc -o lock lock.c":
-----------------------8<-----------------------------
#include <unistd.h>
#include <fcntl.h>
 
int main(int argc, char *argv[])
{
    int fd = open(argv[1], O_RDWR, 0666);
    if (fd < 0) {
        perror("open");
        exit(1);
    }
    struct flock l;
    bzero(&l, sizeof(l));
    l.l_type = F_WRLCK;
    int ret = fcntl(fd, F_SETLK, &l);
    if (ret < 0) {
        perror("fcntl");
        exit(1);
    }
    sleep(30);
    exit(0);
}
-----------------------8<-----------------------------
2. ./lock /var/lib/rpm/Packages & sleep 2; rpm -e non-existent-package
3.
    

Actual Results:  
error: cannot get shared lock on /var/lib/rpm/Packages
error: cannot open Packages index using db3 - Operation not permitted (1)
                                              ^^^^^^^^^^^^^^^^^^^^^^^ ^^^
error: cannot open Packages database in /var/lib/rpm
error: package non-existent-package is not installed


Expected Results:  The underlined part of the error message should
read "Resource temporarily unavailable (11)" or "Permission denied
(13)" depending on whether the call to fcntl() sets errno to EAGAIN or
EACCESS.

Additional info: