Bug 1297177

Summary: nodejs-mysql should depend on nodejs-readable-stream
Product: [Fedora] Fedora Reporter: Robin Rainton <robin>
Component: nodejs-mysqlAssignee: Troy Dawson <tdawson>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: unspecified    
Version: 23CC: package-review, tdawson
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: nodejs-mysql-2.6.2-3.fc23 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2016-01-20 21:54:15 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Robin Rainton 2016-01-10 09:27:52 UTC 
Description of problem:

The nodejs-mysql package should depend on nodejs-readable-stream. Without this certain nodejs-mysql code cannot function and cause run-time errors.

Version-Release number of selected component (if applicable):

nodejs-mysql.noarch 2.6.2-2.fc23

How reproducible:

100%

Steps to Reproduce:
1. dnf install nodejs-mysql
2. Execute some node MySQL code. Eg. something like the first example here: http://www.codediesel.com/nodejs/querying-mysql-with-node-js/

Actual results:

This error occurs:

Error: Cannot find module 'readable-stream'
    at Function.Module._resolveFilename (module.js:338:15)
    at Function.Module._load (module.js:280:25)
    at Module.require (module.js:364:17)
    at require (module.js:380:17)
    at Object.<anonymous> (/usr/lib/node_modules/mysql/lib/protocol/sequences/Query.js:7:20)
    at Module._compile (module.js:456:26)
    at Object.Module._extensions..js (module.js:474:10)
    at Module.load (module.js:356:32)
    at Function.Module._load (module.js:312:12)
    at Module.require (module.js:364:17)

Expected results:

Query should work.

Additional info:

This can be solved by:

dnf install nodejs-readable-stream

This package just needs to be made a dependency.
Comment 1 Troy Dawson 2016-01-12 14:41:44 UTC 
Sorry about that.
Looks like I didn't review the dependencies the past couple of updates.
Working on it.
Comment 2 Fedora Update System 2016-01-12 20:49:42 UTC 
nodejs-mysql-2.6.2-3.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2016-9365dc1245
Comment 3 Fedora Update System 2016-01-13 07:53:19 UTC 
nodejs-mysql-2.6.2-3.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-9365dc1245
Comment 4 Fedora Update System 2016-01-20 21:54:13 UTC 
nodejs-mysql-2.6.2-3.fc23 has been pushed to the Fedora 23 stable repository. If problems still persist, please make note of it in this bug report.