Bug 1297209

Summary:	no-mtab (-n) mount option ignore next mount option
Product:	[Community] GlusterFS	Reporter:	Niels de Vos <ndevos>
Component:	fuse	Assignee:	Niels de Vos <ndevos>
Status:	CLOSED CURRENTRELEASE	QA Contact:
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	3.7.7	CC:	bugs, s.delcroix, vbellur
Target Milestone:	---	Keywords:	Triaged
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	glusterfs-3.7.9	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:	1297195	Environment:
Last Closed:	2016-04-19 07:21:07 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1297195
Bug Blocks:	1309567

Description Niels de Vos 2016-01-10 15:33:11 UTC

+++ This bug was initially created as a clone of Bug #1297195 +++
+++                                                           +++
+++ Use this bug to backport the fix to release-3.7.          +++

Description of problem:
The -n option does not take any arguments. It seems like this shift is removing the next option.

Version-Release number of selected component (if applicable):
all

How reproducible:
100%

Steps to Reproduce:
1. mount -t glusterfs -n -o ro storage.example.com:/volume /mnt
2. verify that the volume is mounted read-only (it is not)

Actual results:
The option after "-n" is skipped, if this is the "-o .." option, all mount options are ignored.

Expected results:
Mounting with "-n" should not affect any of the options it follows.

Additional info:

--- Additional comment from Vijay Bellur on 2016-01-10 13:15:44 CET ---

REVIEW: http://review.gluster.org/12988 (no-mtab (-n) mount option ignore next mount option) posted (#2) for review on master by Niels de Vos (ndevos)

Comment 1 Niels de Vos 2016-03-02 10:53:39 UTC

*** Bug 1311236 has been marked as a duplicate of this bug. ***

Comment 2 Vijay Bellur 2016-03-02 11:53:37 UTC

REVIEW: http://review.gluster.org/13579 (no-mtab (-n) mount option ignore next mount option) posted (#1) for review on release-3.7 by Niels de Vos (ndevos)

Comment 3 Vijay Bellur 2016-03-08 19:09:34 UTC

COMMIT: http://review.gluster.org/13579 committed in release-3.7 by Vijay Bellur (vbellur) 
------
commit 30d9fcc3b2426a0edeb20d6925e7ac63bae83354
Author: Niels de Vos <ndevos>
Date:   Wed Mar 2 11:54:59 2016 +0100

    no-mtab (-n) mount option ignore next mount option
    
    The -n option does not take any arguments. It seems like this shift is
    removing the next option. On my CentOS 7 system, automount calls
    mount.glusterfs with the parameters:
     host:/volume /mountpoint -n -o rw,acl,_netdev
    This causes the -o option to be siliently ignored.
    
    Cherry picked from commit 9e7cd9456532caa7b255978b4b435418c04e0db9:
    > Change-Id: Ice3c877f6ab346b04292e3dfed968d04d15077a5
    > BUG: 1297195
    > Signed-off-by: James Augustine <jcaugust81>
    > Reviewed-on: http://review.gluster.org/12988
    > Reviewed-by: Niels de Vos <ndevos>
    > Tested-by: Niels de Vos <ndevos>
    
    Change-Id: Ice3c877f6ab346b04292e3dfed968d04d15077a5
    BUG: 1297209
    Signed-off-by: Niels de Vos <ndevos>
    Reviewed-on: http://review.gluster.org/13579
    Smoke: Gluster Build System <jenkins.com>
    NetBSD-regression: NetBSD Build System <jenkins.org>
    CentOS-regression: Gluster Build System <jenkins.com>
    Reviewed-by: Vijay Bellur <vbellur>

Comment 4 Kaushal 2016-04-19 07:21:07 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.9, please open a new bug report.

glusterfs-3.7.9 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] https://www.gluster.org/pipermail/gluster-users/2016-March/025922.html
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user