Bug 1297312

Summary:	[cinder] revert operation when fail to add Cinder snapshot.
Product:	[oVirt] ovirt-engine	Reporter:	Maor <mlipchuk>
Component:	BLL.Storage	Assignee:	Maor <mlipchuk>
Status:	CLOSED CURRENTRELEASE	QA Contact:	Natalie Gavrielov <ngavrilo>
Severity:	high	Docs Contact:
Priority:	unspecified
Version:	4.0.0	CC:	amureini, bugs, gklein, sbonazzo, tnisan, ylavi
Target Milestone:	ovirt-3.6.2	Flags:	tnisan: ovirt-3.6.z? ylavi: planning_ack+ tnisan: devel_ack+ rule-engine: testing_ack?
Target Release:	3.6.2.6
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2016-02-23 13:31:51 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	Storage	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Maor 2016-01-11 07:43:51 UTC

Description of problem:
Once a new Cinder snapshot is failed to be created the failed operation should remove all the redundant volumes which were already created for the other Cinder snapshots  in the VM

Version-Release number of selected component (if applicable):


How reproducible:
100%

Steps to Reproduce:
1. Create a VM
2. Create several Cinder disks (5 disks for example)
3. Create a Snapshot
4. Fail the operation so the snapshot will not get created (Even by failing only of one of the volume's snapshot which was created)


Actual results:
The Cinder's snapshots for each Cinder disks are not being removed from Cinder after this failure

Expected results:
All the snapshots which were created in Cinder, for each volume, should be removed from Cinder.

Additional info:

Comment 1 Maor 2016-01-12 17:46:27 UTC

Please consider that for this fix to work on multiple disks the patch with the following change-id I2ca19ec44cba371813381e8f8b076e463eda4173 should be backported.

Until then, this fix should resolve the issue but mainly for one Cinder disk, for multiple disks there might be several corner cases which might not be supported.