Bug 1297362

Summary: [fork][userinterface_public_455]Save button on buildconfig editting page is disabled for Dockerfile and Binary build source
Product: OKD Reporter: Yadan Pei <yapei>
Component: Management ConsoleAssignee: Jakub Hadvig <jhadvig>
Status: CLOSED CURRENTRELEASE QA Contact: Yadan Pei <yapei>
Severity: medium Docs Contact:
Priority: medium    
Version: 3.xCC: aos-bugs, mmccomas, spadgett
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2016-05-12 17:15:43 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Yadan Pei 2016-01-11 10:26:22 UTC 
Description of problem:
After create build with Dockerfile,access the edit page of buildconfig, "Save" button is disabled even changed some settings(change "Build From" value from Imag Stream Tag to Docker Image Link, or change Trigger criteria). Save button is only activated after adding some environment variables.

Version-Release number of selected component (if applicable):
fork_ami_openshift3_userinterface_public_455_166 

How reproducible:
Always

Steps to Reproduce:
1.# cat Dockerfile 
FROM centos:7
RUN yum install -y httpd
2.oc new-build --dockerfile="$(cat ./Dockerfile)"
3.edit buildconfig on web console

Actual results:
3.Save button is disabled

Expected results:
3.Save button should be enabled for changing

Additional info:
Comment 1 Yadan Pei 2016-01-12 09:26:18 UTC 
Save button on buildconfig page is disabled also for Binary build source
Comment 2 Jakub Hadvig 2016-01-21 12:05:41 UTC 
This shall be fixed in the new fork_ami
Comment 3 Yadan Pei 2016-01-22 01:59:51 UTC 
checked on fork_ami_openshift3_userinterface_public_455_187, has been fixed
Comment 4 Yadan Pei 2016-01-25 01:45:07 UTC 
any updates to fork_ami_openshift3_userinterface_public_455_187? this issue reproduce again in testing today.
Comment 5 Samuel Padgett 2016-02-04 17:36:33 UTC 
(In reply to yapei from comment #4)
> any updates to fork_ami_openshift3_userinterface_public_455_187? this issue
> reproduce again in testing today.

Can you test again now that the origin PR has merged?
Comment 6 Samuel Padgett 2016-02-04 17:37:41 UTC 
Note that you have to change something in the form for the Save button to enable.
Comment 7 Yadan Pei 2016-02-05 06:18:45 UTC 
verified on devenv-rhel7_3335,

After accessing edit page, save button is disabled, change something will enable it. works as expected