Bug 1297528

Summary: Review Request: golang-github-duosecurity-duo_api_golang - Duo Security API for strong two-factor authentication
Product: [Fedora] Fedora Reporter: Ed Marshall <esm>
Component: Package ReviewAssignee: Robert-André Mauchin 🐧 <zebob.m>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: package-review, zebob.m
Target Milestone: ---Flags: zebob.m: fedora-review+
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2017-10-23 18:18:45 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Ed Marshall 2016-01-11 19:04:19 UTC
Spec URL: https://fedorapeople.org/~logic/vault/golang-github-duosecurity-duo_api_golang/golang-github-duosecurity-duo_api_golang.spec
SRPM URL: https://fedorapeople.org/~logic/vault/golang-github-duosecurity-duo_api_golang/golang-github-duosecurity-duo_api_golang-0-0.1.git16da9e7.fc24.src.rpm
Description: The Duo Auth API provides a low-level API for adding strong two-factor authentication to applications that cannot directly display rich web content.
Fedora Account System Username: logic

Comment 1 Fedora Update System 2016-01-12 09:52:47 UTC
plasma-workspace-5.5.3-4.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-8be45c9c9f

Comment 2 Ed Marshall 2016-01-12 09:53:38 UTC
I think someone typo'd a bug number. :)

Comment 4 Robert-André Mauchin 🐧 2017-10-04 16:29:40 UTC
 - Please add a commit date for versioning, as required by https://fedoraproject.org/wiki/Packaging:Versioning#Snapshots :

%global commit          2b2d787eb38e28ce4fd906321d717af19fad26a6
%global shortcommit     %(c=%{commit}; echo ${c:0:7})
%global commitdate      20160627

Name:           golang-%{provider}-%{project}-%{repo}
Version:        0
Release:        0.1.%{commitdate}git%{shortcommit}%{?dist}


   And:

* Sat Mar 04 2017 Ed Marshall <esm> - 0-0.1.20160627git2b2d787


Package accepted.


Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



===== MUST items =====

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "BSD (3 clause)", "Unknown or generated". 5 files have unknown
     license. Detailed output of licensecheck in /home/bob/packaging/review
     /golang-github-duosecurity-duo_api_golang/review-golang-github-
     duosecurity-duo_api_golang/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package must own all directories that it creates.
     Note: Directories without known owners: /usr/share/gocode/src,
     /usr/share/gocode, /usr/share/gocode/src/github.com
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[-]: Useful -debuginfo package or justification otherwise.
[-]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 20480 bytes in 2 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
     that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

===== SHOULD items =====

Generic:
[-]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
     Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in golang-
     github-duosecurity-duo_api_golang-devel , golang-github-duosecurity-
     duo_api_golang-unit-test-devel
[?]: Package functions as described.
[!]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
     files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Large data in /usr/share should live in a noarch subpackage if package
     is arched.
[x]: Spec file according to URL is the same as in SRPM.


Rpmlint
-------
Checking: golang-github-duosecurity-duo_api_golang-devel-0-0.1.20160627git2b2d787.fc28.noarch.rpm
          golang-github-duosecurity-duo_api_golang-unit-test-devel-0-0.1.20160627git2b2d787.fc28.x86_64.rpm
          golang-github-duosecurity-duo_api_golang-0-0.1.20160627git2b2d787.fc28.src.rpm
golang-github-duosecurity-duo_api_golang-devel.noarch: W: spelling-error %description -l en_US api -> API, pi, ape
golang-github-duosecurity-duo_api_golang-unit-test-devel.x86_64: W: spelling-error Summary(en_US) api -> API, pi, ape
golang-github-duosecurity-duo_api_golang-unit-test-devel.x86_64: W: spelling-error %description -l en_US api -> API, pi, ape
3 packages and 0 specfiles checked; 0 errors, 3 warnings.

Comment 5 Gwyn Ciesla 2017-10-05 12:19:33 UTC
(fedrepo-req-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-github-duosecurity-duo_api_golang

Comment 6 Fedora Update System 2017-10-07 20:35:26 UTC
golang-github-duosecurity-duo_api_golang-0-0.1.20160627git2b2d787.el7 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-a42c4b5cd2

Comment 7 Fedora Update System 2017-10-07 20:36:14 UTC
golang-github-duosecurity-duo_api_golang-0-0.1.20160627git2b2d787.fc26 has been submitted as an update to Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2017-69aa9af48d

Comment 8 Fedora Update System 2017-10-07 20:36:34 UTC
golang-github-duosecurity-duo_api_golang-0-0.1.20160627git2b2d787.fc27 has been submitted as an update to Fedora 27. https://bodhi.fedoraproject.org/updates/FEDORA-2017-c889b4e81f

Comment 9 Fedora Update System 2017-10-08 04:19:38 UTC
golang-github-duosecurity-duo_api_golang-0-0.1.20160627git2b2d787.el7 has been pushed to the Fedora EPEL 7 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-a42c4b5cd2

Comment 10 Fedora Update System 2017-10-08 04:24:19 UTC
golang-github-duosecurity-duo_api_golang-0-0.1.20160627git2b2d787.fc26 has been pushed to the Fedora 26 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-69aa9af48d

Comment 11 Fedora Update System 2017-10-08 06:25:18 UTC
golang-github-duosecurity-duo_api_golang-0-0.1.20160627git2b2d787.fc27 has been pushed to the Fedora 27 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-c889b4e81f

Comment 12 Fedora Update System 2017-10-12 15:19:46 UTC
golang-github-duosecurity-duo_api_golang-0-0.1.20160627git2b2d787.fc27 has been pushed to the Fedora 27 stable repository. If problems still persist, please make note of it in this bug report.

Comment 13 Fedora Update System 2017-10-15 23:51:01 UTC
golang-github-duosecurity-duo_api_golang-0-0.1.20160627git2b2d787.fc26 has been pushed to the Fedora 26 stable repository. If problems still persist, please make note of it in this bug report.

Comment 14 Fedora Update System 2017-10-23 18:18:45 UTC
golang-github-duosecurity-duo_api_golang-0-0.1.20160627git2b2d787.el7 has been pushed to the Fedora EPEL 7 stable repository. If problems still persist, please make note of it in this bug report.