Bug 1297770

Summary:	nethogs: build ignores $RPM_OPT_FLAGS
Product:	[Fedora] Fedora	Reporter:	barsnick
Component:	nethogs	Assignee:	Anderson Silva <ansilva>
Status:	CLOSED ERRATA	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	unspecified
Version:	rawhide	CC:	ansilva
Target Milestone:	---
Target Release:	---
Hardware:	All
OS:	All
Whiteboard:
Fixed In Version:	nethogs-0.8.2-2.20160101snap.fc23 nethogs-0.8.2-2.20160101snap.fc22 nethogs-0.8.2-2.20160101snap.el7	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2016-02-03 20:51:31 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:

Description barsnick 2016-01-12 12:34:17 UTC

Description of problem:
When building nethogs, the compiler arguments do not include $RPM_OPT_FLAGS

Version-Release number of selected component (if applicable):
0.8.2-1.20160101snap

How reproducible:
always

Steps to Reproduce:
1. build
2. check log:
https://kojipkgs.fedoraproject.org//packages/nethogs/0.8.2/1.20160101snap.fc24/data/logs/x86_64/build.log

Actual results:
g++ -Wall -Wextra [...]

Expected results:
g++ -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector [...]
or something like that.

Additional info:
The SPEC file should be setting
CXXFLAGS="${RPM_OPT_FLAGS}"
in addition to the already set
CFLAGS="${RPM_OPT_FLAGS}"
(There are uses of both in the Makefile.)

Comment 1 Anderson Silva 2016-01-12 14:20:17 UTC

I will address this by the end of the week. Thanks for the note.

Comment 2 Fedora Update System 2016-01-22 18:53:22 UTC

nethogs-0.8.2-2.20160101snap.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2016-d8f005ec35

Comment 3 Fedora Update System 2016-01-22 19:01:44 UTC

nethogs-0.8.2-2.20160101snap.fc22 has been submitted as an update to Fedora 22. https://bodhi.fedoraproject.org/updates/FEDORA-2016-9f9e3a8229

Comment 4 Fedora Update System 2016-01-22 19:07:56 UTC

nethogs-0.8.2-2.20160101snap.el7 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-75915b8111

Comment 5 Fedora Update System 2016-01-24 04:22:35 UTC

nethogs-0.8.2-2.20160101snap.el7 has been pushed to the Fedora EPEL 7 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-75915b8111

Comment 6 Fedora Update System 2016-01-24 04:50:33 UTC

nethogs-0.8.2-2.20160101snap.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-d8f005ec35

Comment 7 Fedora Update System 2016-01-24 04:50:34 UTC

nethogs-0.8.2-2.20160101snap.fc22 has been pushed to the Fedora 22 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-9f9e3a8229

Comment 8 Fedora Update System 2016-02-03 20:51:29 UTC

nethogs-0.8.2-2.20160101snap.fc23 has been pushed to the Fedora 23 stable repository. If problems still persist, please make note of it in this bug report.

Comment 9 Fedora Update System 2016-02-03 21:51:33 UTC

nethogs-0.8.2-2.20160101snap.fc22 has been pushed to the Fedora 22 stable repository. If problems still persist, please make note of it in this bug report.

Comment 10 Fedora Update System 2016-02-17 01:57:34 UTC

nethogs-0.8.2-2.20160101snap.el7 has been pushed to the Fedora EPEL 7 stable repository. If problems still persist, please make note of it in this bug report.