Bug 1297842

Summary:	[cinder] revert operation when deleting Cinder snapshot should not update the active flag of the snapshot's volume
Product:	[oVirt] ovirt-engine	Reporter:	Maor <mlipchuk>
Component:	BLL.Storage	Assignee:	Maor <mlipchuk>
Status:	CLOSED CURRENTRELEASE	QA Contact:	Natalie Gavrielov <ngavrilo>
Severity:	high	Docs Contact:
Priority:	unspecified
Version:	4.0.0	CC:	amureini, bugs, gklein, sbonazzo, tnisan, ylavi
Target Milestone:	ovirt-3.6.2	Flags:	amureini: ovirt-3.6.z? ylavi: planning_ack+ amureini: devel_ack+ rule-engine: testing_ack?
Target Release:	3.6.2.6
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2016-02-23 13:32:06 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	Storage	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Maor 2016-01-12 15:34:26 UTC

Description of problem:
The revert operation of delete Cinder snapshot (The OnFailed), should not change the active flag of the disk.

Version-Release number of selected component (if applicable):


How reproducible:
100%

Steps to Reproduce:
1. Create a VM with Cinder disk
2. Create a snapshot
3. Create another snapshot
4. delete the last snapshot and fail the operation of the delete

Actual results:
The first snapshot will become active and we will have two volumes which are active in the DB

Expected results:
We should not update the active volume

Additional info:

Comment 1 Maor 2016-01-12 17:48:06 UTC

Please consider that for this fix to work on multiple disks the patch with the following change-id I2ca19ec44cba371813381e8f8b076e463eda4173 should be backported.

Until then, this fix should resolve the issue but mainly for one Cinder disk, for multiple disks there might be several corner cases which might not be supported.

Comment 2 Red Hat Bugzilla Rules Engine 2016-01-13 11:27:47 UTC

Bug tickets must have version flags set prior to targeting them to a release. Please ask maintainer to set the correct version flags and only then set the target milestone.