Bug 1297862

Summary:	Ganesha hook script executes showmount and causes a hang
Product:	[Community] GlusterFS	Reporter:	Niels de Vos <ndevos>
Component:	ganesha-nfs	Assignee:	Niels de Vos <ndevos>
Status:	CLOSED CURRENTRELEASE	QA Contact:
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	3.7.7	CC:	bugs
Target Milestone:	---	Keywords:	Triaged
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	glusterfs-3.7.7	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:	1294446	Environment:
Last Closed:	2016-04-19 07:52:37 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1294446
Bug Blocks:

Description Niels de Vos 2016-01-12 16:27:02 UTC

+++ This bug was initially created as a clone of Bug #1294446 +++
+++                                                           +++
+++ Use this bug to backport the fix to release 3.7.          +++

Description of problem:
When rpcbind is not running on the server (or is firewalled), and a Gluster volume is started (after create or stop), a hook script calls 'showmount' and hangs.

Version-Release number of selected component (if applicable):
current master

How reproducible:
100%

Steps to Reproduce (from memory):
1. stop the rpcbind service (also rpcbind.sock on systemd based installations)
2. create a volume
3. set the 'ganesha.enable' volume option
4. start the volume

Actual results:
The 'gluster volume star ...' command hangs, 

Expected results:
No hang.

Additional info:
The cause seems to be the 'S31ganesha-start.sh' hook script. Instead of 'showmount', an equivalent dbus command could be used.

--- Additional comment from Vijay Bellur on 2015-12-28 10:40:26 CET ---

REVIEW: http://review.gluster.org/13098 (scripts: prevent running 'showmount' from the start/post hook script) posted (#1) for review on master by Niels de Vos (ndevos)

--- Additional comment from Niels de Vos on 2015-12-28 10:54:58 CET ---

(In reply to Niels de Vos from comment #0)
...
> Steps to Reproduce (from memory):
> 1. stop the rpcbind service (also rpcbind.sock on systemd based
> installations)
> 2. create a volume
> 3. set the 'ganesha.enable' volume option
> 4. start the volume

It does not seem to be required to set the 'ganesha.enable' volume option. The 'showmount' command that hangs, is executed before this option is checked.

--- Additional comment from Vijay Bellur on 2016-01-12 16:38:35 CET ---

COMMIT: http://review.gluster.org/13098 committed in master by Kaleb KEITHLEY (kkeithle) 
------
commit 2b2294d2a4ef221fccb6eb9f74e9b7dc233b9f1d
Author: Niels de Vos <ndevos>
Date:   Mon Dec 28 10:26:20 2015 +0100

    scripts: prevent running 'showmount' from the start/post hook script
    
    The 31ganesha-start.sh hook script tries to run 'showmount' to see if
    the volume that is getting started should get exported by NFS-Ganesha.
    It was reported that this caused the 'gluster volume start ...' command
    to hang in case rpcbind is not running.
    
    Instead of running 'showmount', we can use DBus to contact NFS-Ganesha
    directly, and request the available exports. This will immediately fail
    in case NFS-Ganesha is not running.
    
    BUG: 1294446
    Change-Id: I3aba1f86fead67116ca5adb1864a8be626c334fa
    Reported-by: Jeff Darcy <jdarcy>
    Signed-off-by: Niels de Vos <ndevos>
    Reviewed-on: http://review.gluster.org/13098
    Tested-by: Raghavendra Talur <rtalur>
    Reviewed-by: jiffin tony Thottan <jthottan>
    Reviewed-by: Kaleb KEITHLEY <kkeithle>

Comment 1 Vijay Bellur 2016-01-12 16:36:13 UTC

REVIEW: http://review.gluster.org/13230 (scripts: prevent running 'showmount' from the start/post hook script) posted (#1) for review on release-3.7 by Niels de Vos (ndevos)

Comment 2 Vijay Bellur 2016-01-14 11:34:50 UTC

COMMIT: http://review.gluster.org/13230 committed in release-3.7 by Kaleb KEITHLEY (kkeithle) 
------
commit 8dcc5596c5370fcbee6ac8fc89cc90ff1d5fd29a
Author: Niels de Vos <ndevos>
Date:   Tue Jan 12 17:35:34 2016 +0100

    scripts: prevent running 'showmount' from the start/post hook script
    
    The 31ganesha-start.sh hook script tries to run 'showmount' to see if
    the volume that is getting started should get exported by NFS-Ganesha.
    It was reported that this caused the 'gluster volume start ...' command
    to hang in case rpcbind is not running.
    
    Instead of running 'showmount', we can use DBus to contact NFS-Ganesha
    directly, and request the available exports. This will immediately fail
    in case NFS-Ganesha is not running.
    
    Cherry picked from commit 2b2294d2a4ef221fccb6eb9f74e9b7dc233b9f1d:
    > BUG: 1294446
    > Change-Id: I3aba1f86fead67116ca5adb1864a8be626c334fa
    > Reported-by: Jeff Darcy <jdarcy>
    > Signed-off-by: Niels de Vos <ndevos>
    > Reviewed-on: http://review.gluster.org/13098
    > Tested-by: Raghavendra Talur <rtalur>
    > Reviewed-by: jiffin tony Thottan <jthottan>
    > Reviewed-by: Kaleb KEITHLEY <kkeithle>
    
    BUG: 1297862
    Change-Id: I3aba1f86fead67116ca5adb1864a8be626c334fa
    Signed-off-by: Niels de Vos <ndevos>
    Reviewed-on: http://review.gluster.org/13230
    Tested-by: NetBSD Build System <jenkins.org>
    Reviewed-by: Kaleb KEITHLEY <kkeithle>

Comment 3 Kaushal 2016-04-19 07:52:37 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.7, please open a new bug report.

glusterfs-3.7.7 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] https://www.gluster.org/pipermail/gluster-users/2016-February/025292.html
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user