Bug 1298474
Summary: | dnf group upgrade produces strange and inconsistent results | ||||||
---|---|---|---|---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | David Jansen <jansen> | ||||
Component: | dnf | Assignee: | rpm-software-management | ||||
Status: | CLOSED EOL | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||
Severity: | unspecified | Docs Contact: | |||||
Priority: | unspecified | ||||||
Version: | 23 | CC: | christian.lupien, iand, jansen, jmracek, jsilhan, mluscon, packaging-team-maint, pnemade, vmukhame | ||||
Target Milestone: | --- | Keywords: | Triaged | ||||
Target Release: | --- | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Whiteboard: | |||||||
Fixed In Version: | Doc Type: | Bug Fix | |||||
Doc Text: | Story Points: | --- | |||||
Clone Of: | Environment: | ||||||
Last Closed: | 2016-12-06 14:27:45 UTC | Type: | Bug | ||||
Regression: | --- | Mount Type: | --- | ||||
Documentation: | --- | CRM: | |||||
Verified Versions: | Category: | --- | |||||
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
Cloudforms Team: | --- | Target Upstream Version: | |||||
Embargoed: | |||||||
Attachments: |
|
Description
David Jansen
2016-01-14 08:38:35 UTC
Can you please attach debugdata [1]? [1] https://github.com/rpm-software-management/dnf/wiki/Bug-Reporting#dependency-resolution-problem Created attachment 1117140 [details]
Debugdata from: dnf group upgrade 'Text-based Internet'
Not sure if its releted but... Prior to fc22 I used to use 'yum group update ..' after a distro-sync OS releasever upgrade in order to grab extra packages that are part of the new release's main package groups. Usually there were a few packages pulled in in each OS upgrade. With fc23 I did the same thing with dnf ... but it just says the group is already installed and suspiciously does nothing. eg: dnf groupupdate 'Minimal Install' dnf groupupdate 'Fedora Workstation' Is this expected behaviour? BTW I did these groupupdate's in the fc21->fc22 OS update also. This package has changed ownership in the Fedora Package Database. Reassigning to the new owner of this component. On Fedora 24, with dnf-1.1.10-1.fc24.noarch, I see the problem. When installing a group where optional packages are already installed (but without the with-optional option), then the /var/lib/dnf/groups.json full_list entry for that package will list all the mandatory, default and installed optional packages. When trying to upgrade the group next, things go wrong because it tries to erase packages it should not. I tracked the problem to the dnf/comps.py python source. The method group_upgrade of the Solver class does things wrong. new_set is only the mandatory and default pacakges from the comps file. old_set is the full_list from the groups.json file (persistor). Therefore upon upgrade, "remove = old_set - new_set" tries to remove all previously installed optional packages which is not correct. Even worst is that because of bug 1318852 (when group install/upgrade ends up in failure then full_list contains every mandatory, default and option, even those that are not installed) even more packages are tried to be deleted. All those deletes will probably break some dependencies and that produces the errors that are seen. I think the fix is to only fill full_list of groups.json with mandatory and default packages, not the optional one (unless they are asked for). It should also be noted that group upgrade does not behave as remove when removing packaging: it does not use the _removable_pkg method to check the yumdb reason for the package to see if its reason is group. This message is a reminder that Fedora 23 is nearing its end of life. Approximately 4 (four) weeks from now Fedora will stop maintaining and issuing updates for Fedora 23. It is Fedora's policy to close all bug reports from releases that are no longer maintained. At that time this bug will be closed as EOL if it remains open with a Fedora 'version' of '23'. Package Maintainer: If you wish for this bug to remain open because you plan to fix it in a currently maintained version, simply change the 'version' to a later Fedora version. Thank you for reporting this issue and we are sorry that we were not able to fix it before Fedora 23 is end of life. If you would still like to see this bug fixed and are able to reproduce it against a later version of Fedora, you are encouraged change the 'version' to a later Fedora version prior this bug is closed as described in the policy above. Although we aim to fix as many bugs as possible during every release's lifetime, sometimes those efforts are overtaken by events. Often a more recent Fedora release includes newer upstream software that fixes bugs or makes them obsolete. We made a lot of changes in handling of groups in dnf-2.0. It is now available in rawhide or from our testing repository ('dnf copr enable rpmsoftwaremanagement/dnf-nightly'). Please can you test it and if your problem still appears, reopen the bug report. |