Bug 1298622 (rubygem-minitest5)
Summary: | Review Request: rubygem-minitest5 - minitest provides a complete suite of testing facilities | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | greg.hellings |
Component: | Package Review | Assignee: | Mamoru TASAKA <mtasaka> |
Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | package-review, vondruch |
Target Milestone: | --- | Flags: | mtasaka:
fedora-review+
|
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2016-02-15 00:56:57 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: |
Description
greg.hellings
2016-01-14 15:14:19 UTC
Taking. I would appreciate it if you would review my review request (bug 1279755) mtasaka's scratch build of rubygem-minitest5-5.8.1-2.el7.src.rpm for epel7 completed http://koji.fedoraproject.org/koji/taskinfo?taskID=12684502 As this is basically EPEL branch request for existing rubygem-minitest master, approving as it is. ------------------------------------------------- This package (rubygem-minitest5) is APPROVED by mtasaka ------------------------------------------------- Some suggestions: http://pkgs.fedoraproject.org/cgit/rpms/rubygem-minitest.git/commit/?id=409c32489ff9a9746976f73a7b315cdbc4d3d3cd - Consider to update to 5.8.4 - Rakefile is not needed as this is alike "Makefile" on autotools system. - We suggest removing test/ directory on runtime package: https://fedoraproject.org/wiki/Packaging:Ruby?rd=Packaging/Ruby#Running_test_suites "Do not ship tests" Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rubygem-minitest5 Thanks! I've implemented all three of your suggestions in the newest package. rubygem-minitest5-5.8.4-1.el7 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-e9edb7ff2c What is the point of having this package in Fedora at this moment? It is already 4th source of Minitest. I would suggest to retire it in Fedora: https://fedoraproject.org/wiki/EPEL/FAQ#Is_it_possible_to_get_a_package_only_into_EPEL_and_not_Fedora.3F rubygem-minitest5-5.8.4-1.el7 has been pushed to the Fedora EPEL 7 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-e9edb7ff2c rubygem-minitest5-5.8.4-1.el7 has been pushed to the Fedora EPEL 7 stable repository. If problems still persist, please make note of it in this bug report. |